Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename top-level Kotlin functions and properties correctly #1807

Merged
merged 5 commits into from
Dec 12, 2024

Conversation

HosseinYousefi
Copy link
Member

If we generate two top-level Kotlin functions or properties with the same names in the same file, they'd have to be named differently not to collide with one another. This PR fixes that. Closes #1658.

@HosseinYousefi HosseinYousefi merged commit 4d81ce6 into main Dec 12, 2024
17 checks passed
@HosseinYousefi HosseinYousefi deleted the close-1658 branch December 12, 2024 03:17
@coveralls
Copy link

Coverage Status

coverage: 88.032% (+0.002%) from 88.03%
when pulling a79cdb3 on close-1658
into 49ce690 on main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Generating multiple Kotlin top-level functions in the same file can cause name collision
3 participants