Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support SDK-specific configs (home-path, environment). #1322

Merged
merged 1 commit into from
Jan 25, 2024

Conversation

isoos
Copy link
Collaborator

@isoos isoos commented Jan 24, 2024

  • Better environment handling for SDKs, removing almost-duplicate method. #1320 added config home, but there is still a chance that SDKs sharing the same home config directory would override each other's settings. The new SdkConfig ensures that complete separation is possible.
  • Also fixing a possible dartdoc glitch (not necessarily bug, rather a hard to debug issue) by explicitly calling the flutter binary (or its embedded dart binary) for Flutter packages. Apparently if FLUTTER_ROOT is set, and we are calling an unrelated Dart SDK, dartdoc implicitly sets the --sdk-dir parameter to <sdk-root>/bin/cache/dart-sdk/, which is absent is the regular Dart SDK, and dartdoc fails.

@isoos isoos requested review from jonasfj and sigurdm January 24, 2024 14:48
@isoos isoos merged commit 332fdfd into dart-lang:master Jan 25, 2024
5 checks passed
@isoos isoos deleted the sdk-config branch January 25, 2024 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants