Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CSS variable name + test to prevent failures. #8120

Merged
merged 1 commit into from
Oct 7, 2024
Merged

Fix CSS variable name + test to prevent failures. #8120

merged 1 commit into from
Oct 7, 2024

Conversation

isoos
Copy link
Collaborator

@isoos isoos commented Oct 7, 2024

Fixes #8106

@isoos isoos requested review from jonasfj and sigurdm October 7, 2024 12:18
@isoos isoos mentioned this pull request Oct 7, 2024
Closed
1 task
jonasfj
jonasfj approved these changes Oct 7, 2024
View reviewed changes
Copy link
Member

@jonasfj jonasfj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No strong feelings, just a slight concern about the churn we add here.

But I can also see more churn by adding more linters/tools that everyone will have to configure/install.

pkg/web_css/test/variables_test.dart Show resolved Hide resolved
@isoos
Copy link
Collaborator Author

isoos commented Oct 7, 2024

Having an unused variable is pretty harmless is it not?

I'd consider it the same as unused code/variable lints in the Dart code. Since we filter out those, we should filter out the same here.

@isoos isoos merged commit be26349 into dart-lang:master Oct 7, 2024
32 checks passed
@isoos isoos deleted the fix-css-variable branch October 7, 2024 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonasfj jonasfj jonasfj approved these changes

@sigurdm sigurdm Awaiting requested review from sigurdm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

site-header-nav backround color not displaying in mobile size
2 participants
@isoos @jonasfj