Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor completion suggestion + test + sort same-score items alphabetically #8125

Merged
merged 2 commits into from
Oct 11, 2024
Merged

Refactor completion suggestion + test + sort same-score items alphabetically #8125

merged 2 commits into from
Oct 11, 2024

Conversation

isoos
Copy link
Collaborator

@isoos isoos commented Oct 9, 2024

  • The first commit is only refactoring the logic without any behavior change.
  • The second commit introduces a second sort when the score is the same on two items.
  • Fixes the options e.g. when the user types license: and the option list is in reversed alphabetical order.

@isoos isoos requested a review from jonasfj October 9, 2024 10:28
@isoos isoos merged commit 36e7106 into dart-lang:master Oct 11, 2024
32 checks passed
@isoos isoos deleted the suggest branch October 11, 2024 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonasfj jonasfj jonasfj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@isoos @jonasfj