Update add helping messages

[AlexV525]

Resolves #4470

---

• I’ve reviewed the contributor guide and applied the relevant portions to this PR.

[sigurdm]

Personally I'd prefer just fixing the help-text. I think it is very hard to make regex updates inside yaml without breaking it.

[sigurdm]

Also note, that if you leave the quotes yaml should accept the the examples as given...

[AlexV525]

Personally I'd prefer just fixing the help-text. I think it is very hard to make regex updates inside yaml without breaking it.

Let's add more test cases when we meet them. :) There is nothing broken with the given pattern examples.

Also note, that if you leave the quotes yaml should accept the the examples as given...

Are you saying that 'foo:{"path":"../foo"}' should work? If yes then it still does after the change.

[sigurdm]

Are you saying that 'foo:{"path":"../foo"}' should work? If yes then it still does after the change.

I'm saying 'foo:{"hosted":"https://pub.dev"}' should work. And all other yaml that I cannot imagine, but I don't want to process it up-front.

[AlexV525]

I'm saying 'foo:{"hosted":"https://pub.dev"}' should work. And all other yaml that I cannot imagine, but I don't want to process it up-front.

Sure. All of the previous examples still work.

[sigurdm]

Does it not insert a space into the host url?

[sigurdm]

Does it not insert a space into the host url?

void main() {
  print('foo:{"hosted":"https://pub.dev"}'.replaceAllMapped( RegExp(r'([,:])(\S)'),
          (match) => '${match.group(1)} ${match.group(2)}'));
}

Prints

foo: {"hosted": "https: //pub.dev"}

[AlexV525]

The request has been updated to change messages only.

[sigurdm]

FYI: If you delete the golden file, and run the test it will be recreated correctly

[AlexV525]

FYI: If you delete the golden file, and run the test it will be recreated correctly

Yeah sorry about repeatedly commits. I thought it was just an easy update. 🥲

EDIT: FYI The generated header is different on Windows: # GENERATED BY: test\help_test.dart