-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dartc build failure: private DartNode.setParent() #10
Comments
Added Area-Compiler label. |
This comment was originally written by drfibonacci@google.com Set owner to mmend...@google.com. |
This comment was originally written by drfibonacci@google.com Added Accepted label. |
This comment was originally written by remi.forax...@gmail.com the correct way to fix it is to write: It's avoid to change the visibility of setParent. |
This comment was originally written by johnle...@google.com Should be fixed at r471 Set owner to johnle...@google.com. |
This comment was originally written by waqner...@gmail.com The fix works for me. |
This comment was originally written by johnle...@google.com Added Fixed label. |
This issue was originally filed by waqne...@gmail.com
What steps will reproduce the problem?
What is the expected output? What do you see instead?
dart/compiler/java/com/google/dart/compiler/ast/DartNode.java fails to compile with the following error:
[javac] /data/down/devel/dart/dart/compiler/java/com/google/dart/compiler/ast/DartNode.java:122: error: setParent(DartNode) has private access in DartNode
[javac] child.setParent(this);
[javac] ^
What version of the product are you using? On what operating system?
dart svn, javac 1.7.0 on arch linux
Please provide any additional information below.
Making setParent() protected instead of private fixes the issue for me, allowing it to be called from protected method becomeParentOf() of the same class.
The text was updated successfully, but these errors were encountered: