Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a bot to analyze the analyzer code base #29138

Closed
bwilkerson opened this issue Mar 22, 2017 · 2 comments
Closed

Add a bot to analyze the analyzer code base #29138

bwilkerson opened this issue Mar 22, 2017 · 2 comments
Assignees
@whesse
Labels
area-infrastructure Use area-infrastructure for SDK infrastructure issues, like continuous integration bot changes.

Comments

@bwilkerson
Copy link
Member

Please add a bot (probably a try bot at first) that will cause dartanalyzer to analyze the code in the analyzer packages.

I believe that the commands we want the bot to execute are

dartanalyzer --no-hints pkg/analysis_server
dartanalyzer --no-hints pkg/analyzer
dartanalyzer --no-hints pkg/analyzer_cli
dartanalyzer --no-hints pkg/analyzer_plugin

We could put all of the directories on a single line if that's more convenient.

The third line is somewhat problematic. There is a bug (#26212) in cli that causes it to ignore the exclusions listed in the analysis options file, which means we get lots of warnings in the 'analyzer_cli' package (because it contains test data that intentionally has errors in it). We'd need to comment this line out temporarily (or just omit it) until we can get the bug fixed.
@bwilkerson bwilkerson added the area-infrastructure Use area-infrastructure for SDK infrastructure issues, like continuous integration bot changes. label Mar 22, 2017
@whesse
Copy link
Contributor

whesse commented Mar 24, 2017

The bot is now added to the dart.fyi waterfall, without the analyzer_cli test, and is green. It can be moved to the main waterfall next week, or else when the analyzer_cli is added.

mithro pushed a commit to mithro/chromium-build that referenced this issue Jun 2, 2017
@whesse
Add new Dart analyze source recipe and builder to FYI
111855c 
BUG=dart-lang/sdk#29138

Change-Id: Iec27ba1f2acf0fc8271eb540730b20114b0eceaa
Reviewed-on: https://chromium-review.googlesource.com/458382
Commit-Queue: William Hesse <whesse@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
@athomas
Copy link
Member

athomas commented Mar 1, 2018

This bot is on the main waterfall and has been for a long time.

@athomas athomas closed this as completed Mar 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@whesse whesse

Labels
area-infrastructure Use area-infrastructure for SDK infrastructure issues, like continuous integration bot changes.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@whesse @bwilkerson @athomas