-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
debugging issues around specifying the latest patch release #108
Conversation
Note that the build failure here is due to the action now requiring |
// back to a double. | ||
if (int.tryParse(sdk) != null && !sdk.contains('.')) { | ||
// Convert a '3' to a '3.0'. | ||
sdk = '$sdk.0'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd throw instead. We didn't intend to support only a 3 value. This case means there was a user error and the intended minor version got lost.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately, what's happening is the user has entered a 3.0
in their yaml file. That gets converted (by the yaml parser? by the javascript runtime?) into a 3
before we get the value. So all we see here is a 3
, and have to infer that what they likely had actually written was a 3.0
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Without this workaround we would be able to support values of 3.1
, 3.2
, ..., but not of 3.0
.
Thanks for the reviews; updated for review feedback and for a fix from #107 (comment). |
FYI, build is still failing because of the 3.3.0-0 SDK requirement. It will start working on Thu when the first 3.3 dev release gets published. |
Investigation around #107.
Contribution guidelines:
dart format
.Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.