Clean up analysis for site-shared packages #181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@domesticmouse Could you take a quick look at this? It's similar to your |
domesticmouse
approved these changes
Jul 25, 2023
|
LGTM 🥳 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switches to using a shared package they (and other tools) can both import, that includes
dart_flutter_team_lintsas well as some extra enabled rules and analysis options. This also removes a few deprecated lints from being used.It then updates the code to account for new analysis options.
I plan to use this analysis package in some downstream tooling in
dart-lang/site-wwwandflutter/websiteas well.