-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial wip implementation of new code excerpter #201
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parlough
force-pushed
the
feat/new-code-excerpter
branch
from
December 12, 2023 03:15
86d09bb
to
16c7715
Compare
parlough
changed the title
Initial implementation of new code excerpter
Initial wip implementation of new code excerpter
Dec 12, 2023
domesticmouse
approved these changes
Dec 12, 2023
This is a TON of cleanup, great work @parlough! |
johnpryan
approved these changes
Apr 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This new package supports similar functionality to the old excerpter, with some functionality copied over, except it runs in one pass without
package:build_runner
with slightly less repetitive string processing. It is structured a bit differently to enable its use as a library package, instead of just as a command-line tool. Some functionality is simplified, changed, or removed, including:There is more cleanup, implementation, and automatic testing to do, but I wanted to get this initial implementation up so other's can provide feedback and help complete that =D
As mentioned, diffs are not yet supported. This will be added later for diff outputs as well as for displaying what changed when running the updater.
Contributes to dart-lang/site-www#5593