Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update inject script to account for sender #211

Merged
merged 2 commits into from
Mar 29, 2024

Conversation

parlough
Copy link
Member

@parlough parlough commented Mar 27, 2024

Update the embed inject script to account for who is sending the ready message. Also switch to using only one event listener on the window, keeping track of the injected embeds (by ID) with a map.

Contributes to dart-lang/dart-pad#2893 (corresponds to dart-lang/dart-pad#2915)

@parlough parlough requested a review from johnpryan March 27, 2024 21:41
@parlough parlough marked this pull request as draft March 28, 2024 18:02
@parlough parlough marked this pull request as ready for review March 28, 2024 19:56
@johnpryan johnpryan merged commit 90c64a9 into main Mar 29, 2024
9 checks passed
@johnpryan johnpryan deleted the fix/one-event-listener-inject branch March 29, 2024 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants