[3.2] Update "Fixing type promotion failures" for private final field…

… promo (#5246)

This is the work to add all the new field promotion failure anchors to
the site. These are linked from context messages.

---------

Co-authored-by: Parker Lougheed <parlough@gmail.com>

firebase.json

@@ -158,16 +158,17 @@
       { "source": "/go/false-secrets", "destination": "/tools/pub/pubspec#false_secrets", "type": 301 },
       { "source": "/go/ffi", "destination": "/guides/libraries/c-interop", "type": 301 },
       { "source": "/go/flutter-upper-bound-deprecation", "destination": "https://github.com/flutter/flutter/issues/68143", "type": 301 },
-      { "source": "/go/non-promo-conflicting-getter", "destination": "/tools/non-promotion-reasons", "type": 301 },
-      { "source": "/go/non-promo-conflicting-non-promotable-field", "destination": "/tools/non-promotion-reasons", "type": 301 },
-      { "source": "/go/non-promo-conflicting-noSuchMethod-forwarder", "destination": "/tools/non-promotion-reasons", "type": 301 },
-      { "source": "/go/non-promo-external-field", "destination": "/tools/non-promotion-reasons", "type": 301 },
-      { "source": "/go/non-promo-field-promotion-unavailable", "destination": "/tools/non-promotion-reasons", "type": 301 },
-      { "source": "/go/non-promo-non-field", "destination": "/tools/non-promotion-reasons", "type": 301 },
-      { "source": "/go/non-promo-non-final-field", "destination": "/tools/non-promotion-reasons", "type": 301 },
-      { "source": "/go/non-promo-property", "destination": "/tools/non-promotion-reasons#property-or-this", "type": 301 },
-      { "source": "/go/non-promo-public-field", "destination": "/tools/non-promotion-reasons", "type": 301 },
-      { "source": "/go/non-promo-this", "destination": "/tools/non-promotion-reasons#property-or-this", "type": 301 },
+
+      { "source": "/go/non-promo-conflicting-getter", "destination": "/tools/non-promotion-reasons#getter-name", "type": 301 },
+      { "source": "/go/non-promo-conflicting-non-promotable-field", "destination": "/tools/non-promotion-reasons#field-name", "type": 301 },
+      { "source": "/go/non-promo-conflicting-noSuchMethod-forwarder", "destination": "/tools/non-promotion-reasons#nosuchmethod", "type": 301 },
+      { "source": "/go/non-promo-external-field", "destination": "/tools/non-promotion-reasons#external", "type": 301 },
+      { "source": "/go/non-promo-field-promotion-unavailable", "destination": "/tools/non-promotion-reasons#language-version", "type": 301 },
+      { "source": "/go/non-promo-non-field", "destination": "/tools/non-promotion-reasons#not-field", "type": 301 },
+      { "source": "/go/non-promo-non-final-field", "destination": "/tools/non-promotion-reasons#final", "type": 301 },
+      { "source": "/go/non-promo-property", "destination": "/tools/non-promotion-reasons#property", "type": 301 },
+      { "source": "/go/non-promo-public-field", "destination": "/tools/non-promotion-reasons#private", "type": 301 },
+      { "source": "/go/non-promo-this", "destination": "/tools/non-promotion-reasons#this", "type": 301 },
       { "source": "/go/non-promo-write", "destination": "/tools/non-promotion-reasons#write", "type": 301 },
 
       { "source": "/go/null-safety-migration", "destination": "/null-safety/migration-guide", "type": 301 },

src/_data/side-nav.yml

@@ -316,12 +316,14 @@
     children:
       - title: Customizing static analysis
         permalink: /tools/analysis
-      - title: Fixing common type problems
-        permalink: /guides/language/sound-problems
       - title: Diagnostic messages
         permalink: /tools/diagnostic-messages
       - title: Linter rules
         permalink: /tools/linter-rules
+      - title: Fixing common type problems
+        permalink: /guides/language/sound-problems
+      - title: Fixing type promotion failures
+        permalink: /tools/non-promotion-reasons
   - title: Testing & optimization
     children:
       - title: Testing