Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider moving brew install instructions to the dart-sdk community package #5499

Closed
1 task
seaniepie opened this issue Feb 1, 2024 · 9 comments · Fixed by #5497
Closed
1 task

Consider moving brew install instructions to the dart-sdk community package #5499

seaniepie opened this issue Feb 1, 2024 · 9 comments · Fixed by #5497
Assignees
Labels
a.install Relates to installing Dart or the archive. cl.fixed Issue is closed as fixed e1-hours Can complete in < 8 hours of normal, not dedicated, work from.page-issue Reported in a reader-filed concern p2-medium Necessary but not urgent concern. Resolve when possible. st.triage.ltw Indicates Lead Tech Writer has triaged

Comments

@seaniepie
Copy link

Page URL

https://dart.dev/get-dart/

Page source

https://github.com/dart-lang/site-www/tree/main/src/get-dart/index.md

Describe the problem

the brew command should be
brew install dart-sdk
NOT
brew install dart
and likewise for upgrade

Expected fix

No response

Additional context

No response

I would like to fix this problem.

  • I will try and fix this problem on dart.dev.
@seaniepie seaniepie added the from.page-issue Reported in a reader-filed concern label Feb 1, 2024
@huycozy huycozy added the st.triage.triage-team Triage team reviewing and categorizing the issue label Feb 1, 2024
@huycozy
Copy link
Member

huycozy commented Feb 1, 2024

Here are outputs when executing brew install for dart and dart-sdk:

Desktop brew install dart
==> Fetching dart-lang/dart/dart
==> Downloading https://storage.googleapis.com/dart-archive/channels/stable/release/2.18.7/sdk/dartsdk-macos-x64-release.zip
############################################################################################################################################## 100.0%
==> Installing dart from dart-lang/dart
==> Caveats
Please note the path to the Dart SDK:
  /usr/local/opt/dart/libexec
==> Summary
🍺  /usr/local/Cellar/dart/2.18.7: 921 files, 497MB, built in 15 seconds
==> Running `brew cleanup dart`...
Disable this behaviour by setting HOMEBREW_NO_INSTALL_CLEANUP.
Hide these hints with HOMEBREW_NO_ENV_HINTS (see `man brew`).
Desktop brew install dart-sdk
==> Downloading https://ghcr.io/v2/homebrew/core/dart-sdk/manifests/3.2.4
############################################################################################################################################## 100.0%
==> Fetching dart-sdk
==> Downloading https://ghcr.io/v2/homebrew/core/dart-sdk/blobs/sha256:f117c92fd0bacc285c98d527b5ecf17f48b1b5519f4013b4291ef10af1b2afa0
############################################################################################################################################## 100.0%
==> Pouring dart-sdk--3.2.4.sonoma.bottle.tar.gz
🍺  /usr/local/Cellar/dart-sdk/3.2.4: 1,023 files, 561.1MB
==> Running `brew cleanup dart-sdk`...
Disable this behaviour by setting HOMEBREW_NO_INSTALL_CLEANUP.
Hide these hints with HOMEBREW_NO_ENV_HINTS (see `man brew`).

I'm not sure which one is correct. Finding dart on Homebrew Formulae, I only see dart-sdk there. Labeling the issue for more insights.

@huycozy huycozy added p2-medium Necessary but not urgent concern. Resolve when possible. e1-hours Can complete in < 8 hours of normal, not dedicated, work a.install Relates to installing Dart or the archive. and removed st.triage.triage-team Triage team reviewing and categorizing the issue labels Feb 1, 2024
@huycozy huycozy changed the title [PAGE ISSUE]: 'Get the Dart SDK' brew command is not correct on Get the Dart SDK page Feb 1, 2024
@atsansone atsansone added the st.triage.ltw Indicates Lead Tech Writer has triaged label Feb 1, 2024
@atsansone atsansone self-assigned this Feb 1, 2024
atsansone pushed a commit to atsansone/site-www that referenced this issue Feb 1, 2024
@mit-mit
Copy link
Member

mit-mit commented Feb 2, 2024

cc @athomas can you comment?

@athomas
Copy link
Member

athomas commented Feb 2, 2024

Well, these are different packages. One is the one we provide and the other is some community project. They have different features:

dart-sdk https://github.com/Homebrew/homebrew-core/blob/c747d12b565608b5867412def730f0429255059f/Formula/d/dart-sdk.rb

  • community supported, not maintained by the Dart team.
  • builds "from source" (not really, because it depot_tools will use pre-builts).
  • only supports main and stable (but you can probably pick other hashes as well).
  • will start failing on older releases (depot_tools will stop working for old versions, bottles may push that horizon a bit but seem OS specific).

dart https://github.com/dart-lang/homebrew-dart

  • maintained by the Dart team (so unless there's a change, this is the official Dart homebrew package).
  • same bits that we test because it downloads from dart-archive.
  • supports all released versions on all channels.
  • will work forever (because dart-archive zips aren't deleted).

If we stop documenting dart, we should also stop having that infra.

Personally, I'd use the dart package, but homebrew purists might prefer the dart-sdk package.

@mit-mit mit-mit changed the title brew command is not correct on Get the Dart SDK page Consider moving brew install instructions to the dart-sdk community package Feb 2, 2024
@mit-mit
Copy link
Member

mit-mit commented Feb 2, 2024

Thanks for the context Alex. But why did brew install dart end up installing 2.18?

@athomas
Copy link
Member

athomas commented Feb 2, 2024

I suspect the user's tap is busted somehow. Could be a new symptom of homebrew handling the master->main transition poorly. 2.18.7 is from roughly that time.

@seaniepie could you try running brew update-reset $(brew --repo dart-lang/dart) and share the output here?

@seaniepie
Copy link
Author

Will do. Thanks for helping. I came across the problem while installing FlutterFlow dependencies on an Intel Mac and brew said there was no such package called dart. So I did a quick google and it said to get dart-sdk instead. But maybe the update-reset will cure things here.

@atsansone
Copy link
Contributor

@seaniepie : Thanks for your assistance here. I'm updating this page in this PR (#5497). I clarified that dart is the official brew. We won't be adding the community package at this time. This might change as we investigate methods of installation. Thanks again!

cc: @anderdobo

@atsansone atsansone closed this as not planned Won't fix, can't repro, duplicate, stale Feb 2, 2024
@atsansone
Copy link
Contributor

@seaniepie : Thanks for your assistance here. I'm updating this page in this PR (#5497). I clarified that dart is the official brew. We won't be adding the community package at this time. This might change as we investigate methods of installation. Thanks again!

cc: @anderdobo

@seaniepie
Copy link
Author

This is what I get as a response:

Error: /usr/local/Homebrew/Library/Taps/dart-lang/homebrew-dart is not a Git repository!
Usage: brew update-reset [path-to-tap-repository ...]

Fetch and reset Homebrew and all tap repositories (or any specified
repository) using git(1) to their latest origin/HEAD.

Note: this will destroy all your uncommitted or committed changes.

atsansone pushed a commit to atsansone/site-www that referenced this issue Feb 6, 2024
atsansone pushed a commit to atsansone/site-www that referenced this issue Feb 7, 2024
atsansone pushed a commit to atsansone/site-www that referenced this issue Feb 7, 2024
atsansone pushed a commit to atsansone/site-www that referenced this issue Feb 12, 2024
atsansone added a commit that referenced this issue Feb 13, 2024
@huycozy huycozy added the cl.fixed Issue is closed as fixed label Feb 15, 2024
atsansone added a commit to atsansone/site-www that referenced this issue Feb 20, 2024
atsansone added a commit to atsansone/site-www that referenced this issue Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a.install Relates to installing Dart or the archive. cl.fixed Issue is closed as fixed e1-hours Can complete in < 8 hours of normal, not dedicated, work from.page-issue Reported in a reader-filed concern p2-medium Necessary but not urgent concern. Resolve when possible. st.triage.ltw Indicates Lead Tech Writer has triaged
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants