Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IGNORE] Migration proof of concept #5284

Closed
wants to merge 59 commits into from
Closed

Conversation

parlough
Copy link
Member

@parlough parlough commented Oct 25, 2023

This isn't done and there are many TODOs, documented both here and elsewhere, but it showcases the site at least building with 11ty.

Some initial details:

  • Simpler aside/admonition syntax, also allows for custom titles.
  • Staging, link checking, testing, etc on GitHub went from 7+ minutes -> ≈1-2 minutes!
  • Code highlighting and custom styles ([! !], {:.good}, etc) are not yet functional.
  • There are a bunch of minor issues marked with TODOs throughout the site.
  • Files beginning with _ are still rendered, this likely needs to be disabled.

Staged: https://dart-dev--pr5284-feature-migrate-to-11ty-fpccvu5v.web.app/

@parlough parlough added the st.WIP Issue in progress label Oct 25, 2023
@khanhnwin
Copy link
Contributor

This looks great @parlough!!

@MaryaBelanger
Copy link
Contributor

MaryaBelanger commented Nov 2, 2023

The site looks great! Site alerts and code blocks seem more distinct and styled better too (even without {:.good} / {:.bad} yet!)

Edit: I just saw one of your "Non-goals" : Change site output in any significant way.
So, uhh... nevermind, it looks exactly the same...

@parlough
Copy link
Member Author

parlough commented Nov 2, 2023

Okay code blocks and site alerts will be two exceptions and will change, but those changes are more side effects than goals :)

They're two of the last remaining steps though, so expect them to change further.

@dart-lang dart-lang deleted a comment from github-actions bot Jan 19, 2024
@dart-github-bot
Copy link
Collaborator

dart-github-bot commented Jan 19, 2024

Visit the preview URL for this PR (updated for commit 2c3aff1):

https://dart-dev--pr5284-feature-migrate-to-11ty-fpccvu5v.web.app

@parlough
Copy link
Member Author

Superseded by #5483

@parlough parlough closed this Jan 30, 2024
@parlough parlough deleted the feature/migrate-to-11ty branch February 16, 2024 01:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
st.WIP Issue in progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants