Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Concurrency overview page update #5402

Merged
merged 13 commits into from
Dec 14, 2023
Merged

Concurrency overview page update #5402

merged 13 commits into from
Dec 14, 2023

Conversation

ericwindmill
Copy link
Contributor

This is the first PR of two that will update isolate documentation. It was decided that we should split the original PR into two.

This PR updates documentation at language/concurrency with more information.

Fixes #3720


  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
  • This PR doesn’t contain automatically generated corrections or text (Grammarly, LLMs, and similar).
  • This PR follows the Google Developer Documentation Style Guidelines — for example, it doesn’t use i.e. or e.g., and it avoids I and we (first person).
  • This PR uses semantic line breaks of 80 characters or fewer.

Copy link

github-actions bot commented Dec 11, 2023

Visit the preview URL for this PR (updated for commit 776bd3b):

https://dart-dev--pr5402-concurrency-page-upd-5i7q0hxt.web.app

(expires Thu, 21 Dec 2023 17:29:25 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: d851bc446d3c4d7394c5406c6f07255afc7075f3

Copy link
Contributor

@MaryaBelanger MaryaBelanger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM % some comments, I think there's a misprint or two that needs to be addressed, but other than that the rest are just suggestions

src/language/concurrency.md Outdated Show resolved Hide resolved
src/language/concurrency.md Outdated Show resolved Hide resolved
src/language/concurrency.md Outdated Show resolved Hide resolved
src/language/concurrency.md Show resolved Hide resolved
src/language/concurrency.md Outdated Show resolved Hide resolved
src/language/concurrency.md Outdated Show resolved Hide resolved
src/language/concurrency.md Show resolved Hide resolved
src/language/concurrency.md Outdated Show resolved Hide resolved
src/language/concurrency.md Outdated Show resolved Hide resolved
ericwindmill and others added 3 commits December 14, 2023 10:52
Co-authored-by: Marya <111139605+MaryaBelanger@users.noreply.github.com>
@atsansone
Copy link
Contributor

@parlough : I think this is affected by the build issue in #5410. Can you re-run that action once it merges?

@atsansone atsansone added the st.RFM.% Ready to Merge but has suggestions label Dec 14, 2023
@ericwindmill ericwindmill merged commit 0948944 into main Dec 14, 2023
9 checks passed
@ericwindmill ericwindmill deleted the concurrency-page-updates branch December 14, 2023 18:29
ericwindmill added a commit that referenced this pull request Jan 4, 2024
This PR is being split into two. The first one can be found
[here](#5402).

This PR updates documentation at language/concurrency with more
information, and adds a page language/isolates with examples.

Fixes #3720

**Staged:**

-
[Concurrency](https://dart-dev--pr5332-isolate-documentatio-gmqcme0e.web.app/language/concurrency)
_(Updated)_
-
[Isolates](https://dart-dev--pr5332-isolate-documentatio-gmqcme0e.web.app/language/isolates)
_(New)_

---------

Co-authored-by: Parker Lougheed <parlough@gmail.com>
Co-authored-by: Marya <111139605+MaryaBelanger@users.noreply.github.com>
atsansone pushed a commit to atsansone/site-www that referenced this pull request Jan 26, 2024
This is the first PR of two that will update isolate documentation. It
was decided that we should split [the original
PR](dart-lang#5332) into two.

This PR updates documentation at language/concurrency with more
information.

Fixes dart-lang#3720

---

- [x] I’ve reviewed the contributor guide and applied the relevant
portions to this PR.
- [x] This PR doesn’t contain automatically generated corrections or
text (Grammarly, LLMs, and similar).
- [x] This PR follows the [Google Developer Documentation Style
Guidelines](https://developers.google.com/style) — for example, it
doesn’t use _i.e._ or _e.g._, and it avoids _I_ and _we_ (first person).
- [x] This PR uses [semantic line
breaks](https://github.com/dart-lang/site-shared/blob/main/doc/writing-for-dart-and-flutter-websites.md#semantic-line-breaks)
of 80 characters or fewer.

---------

Co-authored-by: Marya <111139605+MaryaBelanger@users.noreply.github.com>
Co-authored-by: Parker Lougheed <parlough@gmail.com>
atsansone pushed a commit to atsansone/site-www that referenced this pull request Jan 26, 2024
This PR is being split into two. The first one can be found
[here](dart-lang#5402).

This PR updates documentation at language/concurrency with more
information, and adds a page language/isolates with examples.

Fixes dart-lang#3720

**Staged:**

-
[Concurrency](https://dart-dev--pr5332-isolate-documentatio-gmqcme0e.web.app/language/concurrency)
_(Updated)_
-
[Isolates](https://dart-dev--pr5332-isolate-documentatio-gmqcme0e.web.app/language/isolates)
_(New)_

---------

Co-authored-by: Parker Lougheed <parlough@gmail.com>
Co-authored-by: Marya <111139605+MaryaBelanger@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
st.RFM.% Ready to Merge but has suggestions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update content in 'Concurrency in Dart' page
4 participants