Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated image usage #5433

Merged
merged 5 commits into from
Jan 13, 2024
Merged

Updated image usage #5433

merged 5 commits into from
Jan 13, 2024

Conversation

atsansone
Copy link
Contributor

Fixes #1789

@atsansone atsansone added the review.copy Awaiting Copy Review label Dec 27, 2023
@dart-github-bot
Copy link
Collaborator

dart-github-bot commented Jan 11, 2024

Visit the preview URL for this PR (updated for commit 12c6627):

https://dart-dev--pr5433-fix-1789-dtps8acv.web.app

@parlough parlough self-requested a review January 11, 2024 17:24
Copy link
Member

@parlough parlough left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this cleanup @atsansone!

I think a few of the diagram files may still be used, but if they need to be updated, they likely need to be remade for current site standards anyway.

Just one small issue and suggestion:

src/index.html Show resolved Hide resolved
@parlough parlough added review.await-update Awaiting Updates after Edits and removed review.copy Awaiting Copy Review labels Jan 12, 2024
MaryaBelanger and others added 3 commits January 12, 2024 17:14
Go link placeholder for migration `package:web` migration docs
@atsansone atsansone added st.RFM Ready to merge or land and removed review.await-update Awaiting Updates after Edits labels Jan 13, 2024
@atsansone atsansone merged commit 6201566 into dart-lang:main Jan 13, 2024
8 checks passed
atsansone added a commit to atsansone/site-www that referenced this pull request Jan 26, 2024
Fixes dart-lang#1789

---------

Co-authored-by: Marya <111139605+MaryaBelanger@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
st.RFM Ready to merge or land
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make sure image files are used
4 participants