Add a Cloud Build config to deploy website to Firebase. #5447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n. Currently deploys to a staging project for testing.
|
Visit the preview URL for this PR (updated for commit 3f98199): https://dart-dev--pr5447-cloud-build-deploy-xuxan9xb.web.app |
| args: | ||
| - '-c' | ||
| - |- | ||
| firebase deploy --project=flutter-website-staging-349021 --only=hosting |
There was a problem hiding this comment.
Is this supposed to be to a dart project instead?
There was a problem hiding this comment.
Yes! I'm going to open another PR to change that once this lands and we've confirmed it deploys properly. I don't want to remove the current deploy GitHub action until we confirm this deploy works & I don't want them to deploy on top of each other.
parlough
reviewed
Jan 4, 2024
parlough
approved these changes
Jan 4, 2024
3 tasks
khanhnwin
added a commit
that referenced
this pull request
Jan 4, 2024
Addresses remaining AI's from #5447. - [x] Swapped out deploy project to `dart-dev` - [x] I've manually disabled the [deploy.yaml GitHub action](https://github.com/dart-lang/site-www/blob/main/.github/workflows/deploy.yml) workflow from the "Actions" menu. - [x] Updated the Cloud Build trigger to go off on push to `main` branch
atsansone
pushed a commit
to atsansone/site-www
that referenced
this pull request
Jan 26, 2024
As the title says. This is the Cloud Build configuration that we'll use to build dart.dev and publish to Firebase hosting. Note: This current config currently publishes to a staging Flutter project to confirm everything works on main. Once this PR lands and we've confirmed deploy works as expected, - [ ] I'll open another PR to switch to prod project `dart-dev` - [ ] Decommission the [deploy.yaml GitHub action](https://github.com/dart-lang/site-www/blob/main/.github/workflows/deploy.yml). - [ ] Update the trigger branch to `main` cc @drewroengoogle @parlough
atsansone
pushed a commit
to atsansone/site-www
that referenced
this pull request
Jan 26, 2024
Addresses remaining AI's from dart-lang#5447. - [x] Swapped out deploy project to `dart-dev` - [x] I've manually disabled the [deploy.yaml GitHub action](https://github.com/dart-lang/site-www/blob/main/.github/workflows/deploy.yml) workflow from the "Actions" menu. - [x] Updated the Cloud Build trigger to go off on push to `main` branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the title says. This is the Cloud Build configuration that we'll use to build dart.dev and publish to Firebase hosting.
Note: This current config currently publishes to a staging Flutter project to confirm everything works on main.
Once this PR lands and we've confirmed deploy works as expected,
dart-devmain---> SEE: Change deploy project to dart-dev #5449
cc @drewroengoogle @parlough