Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix some typos in isolate documentation. #5469

Merged
merged 2 commits into from
Jan 17, 2024
Merged

Fix some typos in isolate documentation. #5469

merged 2 commits into from
Jan 17, 2024

Conversation

ksokolovskyi
Copy link
Contributor

This PR fixes typos introduced in #5332

  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
  • This PR doesn’t contain automatically generated corrections or text (Grammarly, LLMs, and similar).
  • This PR follows the Google Developer Documentation Style Guidelines — for example, it doesn’t use i.e. or e.g., and it avoids I and we (first person).
  • This PR uses semantic line breaks of 80 characters or fewer.
Contribution guidelines:
  • See our contributor guide for general expectations for PRs.
  • Larger or significant changes should be discussed in an issue before creating a PR.
  • Code changes should generally follow the Dart style guide and use dart format.
  • Updates to code excerpts indicated by <?code-excerpt need to be updated in their source .dart file as well.

@ksokolovskyi
Copy link
Contributor Author

Hi @MaryaBelanger, @ericwindmill, @parlough!
Could you please take a look at this PR?

@parlough
Copy link
Member

parlough commented Jan 17, 2024 •
edited
Loading

/gcbrun

@dart-github-bot
Copy link
Collaborator

Visit the preview URL for this PR (updated for commit 87e72ac):

https://dart-dev--pr5469-fix-isolate-documentation-rzbo3jt2.web.app

ericwindmill
ericwindmill approved these changes Jan 17, 2024
View reviewed changes
Copy link
Contributor

@ericwindmill ericwindmill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am ashamed that I still can't spell 'receive' right, after writing it dozens of times in these docs

MaryaBelanger
MaryaBelanger approved these changes Jan 17, 2024
View reviewed changes
Copy link
Contributor

@MaryaBelanger MaryaBelanger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! We all can't spell 😅

@MaryaBelanger MaryaBelanger merged commit ad95b5d into dart-lang:main Jan 17, 2024
8 checks passed
@ksokolovskyi
Copy link
Contributor Author

@MaryaBelanger @parlough @ericwindmill thanks for the review!

atsansone pushed a commit to atsansone/site-www that referenced this pull request Jan 26, 2024
@ksokolovskyi @parlough
Fix some typos in isolate documentation. (dart-lang#5469)
4553cff 
This PR fixes typos introduced in
dart-lang#5332

---

Co-authored-by: Parker Lougheed <parlough@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaryaBelanger MaryaBelanger MaryaBelanger approved these changes

@ericwindmill ericwindmill ericwindmill approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ksokolovskyi @parlough @dart-github-bot @ericwindmill @MaryaBelanger