Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Close cleanup #4

Merged
merged 13 commits into from
Mar 11, 2019
Merged

Close cleanup #4

merged 13 commits into from
Mar 11, 2019

Conversation

grouma
Copy link
Member

@grouma grouma commented Mar 9, 2019 •
edited
Loading

  • Remove close and onClose from SseConnection
    • This functionality is replaced by the underlying sink / stream
  • Fix an issue where the Sink within the SseConnection wasn't closed
  • Store underlying connections in a map to improve performance
  • Rev package version
  • Make local testing easier

@grouma grouma requested a review from natebosch March 9, 2019 03:03
natebosch
natebosch approved these changes Mar 11, 2019
View reviewed changes
lib/server/sse_handler.dart Outdated Show resolved Hide resolved
lib/server/sse_handler.dart Outdated Show resolved Hide resolved
@grouma grouma merged commit c7d4ecf into master Mar 11, 2019
@grouma grouma deleted the close-cleanup branch March 11, 2019 21:32
@grouma grouma mentioned this pull request Mar 14, 2019
Closed
@aresares aresares mentioned this pull request Apr 25, 2020
Closed
mosuem pushed a commit to dart-lang/tools that referenced this pull request Dec 10, 2024
@grouma
Merge pull request dart-lang/sse#4 from dart-lang/close-cleanup
6f92177 
Close cleanup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@natebosch natebosch natebosch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@grouma @natebosch