Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some trivial doc comment lints #110

Merged
merged 1 commit into from
Jul 29, 2024
Merged

Fix some trivial doc comment lints #110

merged 1 commit into from
Jul 29, 2024

Conversation

kevmoo
Copy link
Member

@kevmoo kevmoo commented Jul 28, 2024

No description provided.

@kevmoo kevmoo requested a review from devoncarew July 28, 2024 01:58
@@ -2,6 +2,9 @@
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.

/// @docImport 'isolate_channel.dart';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is now available for use? Do we need a min. version of the sdk?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we're only testing analyzer against dev – which is where it works 🤷

@kevmoo kevmoo merged commit c0c5a97 into master Jul 29, 2024
6 checks passed
@kevmoo kevmoo deleted the fix_lints branch July 29, 2024 18:27
copybara-service bot pushed a commit to dart-lang/sdk that referenced this pull request Jul 29, 2024
Revisions updated by `dart tools/rev_sdk_deps.dart`.

stream_channel (https://github.com/dart-lang/stream_channel/compare/28a6533..c0c5a97):
  c0c5a97  2024-07-29  Kevin Moore  Fix some trivial doc comment lints (dart-lang/stream_channel#110)

yaml_edit (https://github.com/dart-lang/yaml_edit/compare/d605cce..5c54d45):
  5c54d45  2024-07-29  Kevin Moore  Bump and fix lints, require Dart 3.1 (dart-lang/yaml_edit#95)

Change-Id: Ie011b78462762cbfd39fdf52c75c72f22cbec96e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/377880
Commit-Queue: Devon Carew <devoncarew@google.com>
Auto-Submit: Devon Carew <devoncarew@google.com>
Commit-Queue: Kevin Moore <kevmoo@google.com>
Reviewed-by: Kevin Moore <kevmoo@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants