Add optional offset
argument to StringScanner.peekCodePoint()
#69
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
StringScanner.peekChar()
accepts an optional argument of offset, but the newStringScanner.peekCodePoint()
method doesn't. This PR aims to makeStringScanner.peekCodePoint()
's behavior align more with that ofStringScanner.peekChar()
.This is required if the yaml library is to migrate to
string_scanner ^1.2.0
to take advantage from the new codepoint related APIs.Contribution guidelines:
dart format
.Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.