Skip to content

Commit

Permalink
run CI on all PR branches (#282)
Browse files Browse the repository at this point in the history
This is a follow-up to #280 (comment). In summary, we only run CI checks on PRs against the main branch. However, in cases where an older major version of a package needs to be patched, it doesn't make sense to PR against main. CI won't run for these PRs, but it probably should.

This updates our GitHub CI configs to run checks against PRs against any branch.

---

<details>
  <summary>Contribution guidelines:</summary><br>

- See our [contributor guide](https://github.com/dart-lang/.github/blob/main/CONTRIBUTING.md) for general expectations for PRs.
- Larger or significant changes should be discussed in an issue before creating a PR.
- Contributions to our repos should follow the [Dart style guide](https://dart.dev/guides/language/effective-dart) and use `dart format`.
- Most changes should add an entry to the changelog and may need to [rev the pubspec package version](https://github.com/dart-lang/sdk/blob/main/docs/External-Package-Maintenance.md#making-a-change).
- Changes to packages require [corresponding tests](https://github.com/dart-lang/.github/blob/main/CONTRIBUTING.md#Testing).

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.
</details>
  • Loading branch information
andrewkolos authored Nov 21, 2024
1 parent c4793ce commit 466bb19
Show file tree
Hide file tree
Showing 4 changed files with 3 additions and 7 deletions.
1 change: 0 additions & 1 deletion .github/workflows/cli_config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ permissions: read-all

on:
pull_request:
branches: [main]
paths:
- ".github/workflows/cli_config.yml"
- "pkgs/cli_config/**"
Expand Down
1 change: 0 additions & 1 deletion .github/workflows/extension_discovery.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ permissions: read-all

on:
pull_request:
branches: [ main ]
paths:
- '.github/workflows/unified_analytics.yml'
- 'pkgs/extension_discovery/**'
Expand Down
7 changes: 3 additions & 4 deletions .github/workflows/graphs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,13 +3,12 @@ name: package:graphs
permissions: read-all

on:
# Run CI on pushes to the main branch, and on PRs against main.
push:
branches: [ main ]
# Run CI on all PRs (against any branch) and on pushes to the main branch.
pull_request:
paths:
- '.github/workflows/graphs.yml'
- 'pkgs/graphs/**'
pull_request:
push:
branches: [ main ]
paths:
- '.github/workflows/graphs.yml'
Expand Down
1 change: 0 additions & 1 deletion .github/workflows/unified_analytics.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ permissions: read-all

on:
pull_request:
branches: [ main ]
paths:
- '.github/workflows/unified_analytics.yml'
- 'pkgs/unified_analytics/**'
Expand Down

0 comments on commit 466bb19

Please sign in to comment.