-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
In the Event.exception
constructor, modify a clone of the args
argument instead of args
itself
#1201
Conversation
…gument instead of `args` itself (#1200)
This is a follow-up to #280 (comment). In summary, we only run CI checks on PRs against the main branch. However, in cases where an older major version of a package needs to be patched, it doesn't make sense to PR against main. CI won't run for these PRs, but it probably should. This updates our GitHub CI configs to run checks against PRs against any branch. --- <details> <summary>Contribution guidelines:</summary><br> - See our [contributor guide](https://github.com/dart-lang/.github/blob/main/CONTRIBUTING.md) for general expectations for PRs. - Larger or significant changes should be discussed in an issue before creating a PR. - Contributions to our repos should follow the [Dart style guide](https://dart.dev/guides/language/effective-dart) and use `dart format`. - Most changes should add an entry to the changelog and may need to [rev the pubspec package version](https://github.com/dart-lang/sdk/blob/main/docs/External-Package-Maintenance.md#making-a-change). - Changes to packages require [corresponding tests](https://github.com/dart-lang/.github/blob/main/CONTRIBUTING.md#Testing). Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback. </details>
Do you know if updating tools/.github/workflows/publish.yaml Lines 1 to 9 in e83caee
to run against any branch would work for publishing patches to older versions of packages? Assuming that would work, do we want it to (are there branch protections that we have on main that we would then want on all branches)? I'm happy to track this in a separate issue if we don't want to solve it today. |
Note for @kenzieschmoll: you can ignore the .github/workflows config file changes. This was cherry-picked from main just to get this branch tested on CI. |
Hi!
I think we want to:
Our publishing automation isn't really set up to handle publishing older patches; that's a rare enough occurrence that I think it's reasonable to handle it by manually publishing from a branch from disk. |
SGTM. The first step is already satisfied here, so I will publish this myself once this gets an approval. |
Hotfix for #1195 for package:unified_analytics v6. This is somewhat necessary because the current flutter beta depends on v6.
Note that merging this PR as-is won't result in a publish. This PR exists for the sake of code review.
Contribution guidelines:
dart format
.Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.