Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add generic usage event used for iOS/macOS workflows + generic exception event #206

Merged
merged 4 commits into from
Nov 20, 2023

Conversation

eliasyishak
Copy link
Contributor

Related to tracker issue:

This PR adds 2 events here, one for the generic UsageEvent in flutter, and another for the sendException method in flutter.

For the UsageEvent, you can refer to this sheet which shows all the call sites for that event. I found that all of these events were apple related so I consolidated them down into just one event. The event created for is called Event.appleUsageEvent

For the sendException method, we are only sending the exception's runtimeType as a string from flutter, so i created the Event.exception constructor which takes just one parameter for the exception string. Because this not specific to only flutter, we can have other dash tools also use this event to track exceptions in their workflows.


  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

Copy link

Package publishing

Package Version Status Publish tag (post-merge)
package:unified_analytics 5.5.0 ready to publish unified_analytics-v5.5.0
package:graphs 2.3.2-wip WIP (no publish necessary)
package:extension_discovery 2.0.1-wip WIP (no publish necessary)
package:cli_config 0.1.2 already published at pub.dev

Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation.

@eliasyishak eliasyishak merged commit 9beff70 into dart-lang:main Nov 20, 2023
6 checks passed
@eliasyishak eliasyishak deleted the add-usage-event branch November 20, 2023 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants