Patch tests for unified_analytics 5.8.8+2 fixes #281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The current plan is to wait and see whether @christopherfujino will be back in action tomorrow, since I don't think we really need (?) to get this published by the end of the week. Once this merges—per https://github.com/dart-lang/tools/pull/280#issuecomment-2189866767—the next step would be to have devoncrew (or someone else with publishing permissions) publish this to pub. |
|
Can you delete the first |
This is to try to make CI run for this branch.
github-actions
bot
added
the
type-infra
|
You want the |
|
@devoncarew the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #280. Basically, that PR cherry-picked some fixes from main (unified_analytics v6) to a new branch meant to eventually be published as unified_analytics v5.8.8+2. However, since there were some API changes in v6, the tests didn't work (I already remembered to verify the tests right after I merged 😛).
This PR patches these tests. It makes
LogHandler::logFilewritable via a@visibleForTestingOnlysetter, which I think is okay for patching an old major version.Contribution guidelines:
dart format.Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.