Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop using deprecated ContextLocator and ContextBuilder. #285

Merged
merged 3 commits into from
Jul 18, 2024

Conversation

scheglov
Copy link
Contributor

  • Thanks for your contribution! Please replace this text with a description of what this PR is changing or adding and why, list any relevant issues, and review the contribution guidelines below.

  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

@devoncarew
Copy link
Member

Hmm, the version resolution here seems complicated:

https://github.com/dart-lang/tools/actions/runs/9963959255/job/27531185159?pr=285

@devoncarew
Copy link
Member

(we should see if we can get the CI here green before landing)

@github-actions github-actions bot added the type-infra A repository infrastructure change or enhancement label Jul 16, 2024
@github-actions github-actions bot removed the type-infra A repository infrastructure change or enhancement label Jul 16, 2024
@scheglov
Copy link
Contributor Author

I think currently the analyzer requires the latest Dart SDK, because of macros.
And dispose() was potentially necessary because of macros (stop separate isolates running macros).
But practically we don't resolve anything here, just parse, so get get away with not disposing.

@scheglov scheglov merged commit f957dd2 into main Jul 18, 2024
7 checks passed
@scheglov scheglov deleted the analyzer-AnalysisContextCollection branch July 18, 2024 02:42
copybara-service bot pushed a commit to dart-lang/sdk that referenced this pull request Jul 19, 2024
Revisions updated by `dart tools/rev_sdk_deps.dart`.

dartdoc (https://github.com/dart-lang/dartdoc/compare/1d00523..5230f8f):
  5230f8fd  2024-07-16  Srujan Gaddam  Add support for package:web v1.0.0 (dart-lang/dartdoc#3821)

http (https://github.com/dart-lang/http/compare/757438e..a0781c5):
  a0781c5  2024-07-18  Anikate De  pkgs/ok_http: JNIgen fixes and added WebSocket support (dart-lang/http#1257)

sse (https://github.com/dart-lang/sse/compare/52d042f..af2c5c5):
  af2c5c5  2024-07-17  Kevin Moore  Bump to latest lints (dart-lang/sse#114)
  a6ae8dc  2024-07-16  Srujan Gaddam  Add support for package:web v1.0.0 (dart-lang/sse#113)

tools (https://github.com/dart-lang/tools/compare/6a07a16..55dbd6e):
  55dbd6e  2024-07-18  Devon Carew  rev to 2.3.2 in prep for publishing (dart-lang/tools#287)
  f957dd2  2024-07-17  Konstantin Scheglov  Stop using deprecated ContextLocator and ContextBuilder. (dart-lang/tools#285)

Change-Id: I6f51418c424a3b1400ab245f557a53e92da44848
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/376700
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants