Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add/enable Windows tests #124

Merged
merged 8 commits into from
Jan 19, 2022
Merged

Add/enable Windows tests #124

merged 8 commits into from
Jan 19, 2022

Commits on Jan 17, 2022

  1. Add/enable Windows tests

    @DanTup
    DanTup committed Jan 17, 2022
    Configuration menu
    Copy the full SHA
    0b87be5 View commit details
    Browse the repository at this point in the history

Commits on Jan 18, 2022

  1. Ensure watcher subs are cancelled

    @DanTup
    DanTup committed Jan 18, 2022
    Configuration menu
    Copy the full SHA
    ed55adb View commit details
    Browse the repository at this point in the history

Commits on Jan 19, 2022

  1. Try adding a delay during teardown on Windows to see if it helps with… 

    … deletion errors
    @DanTup
    DanTup committed Jan 19, 2022
    Configuration menu
    Copy the full SHA
    3419ac5 View commit details
    Browse the repository at this point in the history

  2. Try forcing cancellation of subscription

    @DanTup
    DanTup committed Jan 19, 2022
    Configuration menu
    Copy the full SHA
    b1bbfe3 View commit details
    Browse the repository at this point in the history

  3. Test only cancelling once

    @DanTup
    DanTup committed Jan 19, 2022
    Configuration menu
    Copy the full SHA
    c331932 View commit details
    Browse the repository at this point in the history

  4. Allow tests to close watcher, but ensure they always close via teardown

    @DanTup
    DanTup committed Jan 19, 2022
    Configuration menu
    Copy the full SHA
    42ceb65 View commit details
    Browse the repository at this point in the history

  5. Ensure _hasClosedStream is reset when a new watcher is set up

    @DanTup
    DanTup committed Jan 19, 2022
    Configuration menu
    Copy the full SHA
    b303a45 View commit details
    Browse the repository at this point in the history

  6. Skip failing test on Windows 

    See dart-lang#125.
    @DanTup
    DanTup committed Jan 19, 2022
    Configuration menu
    Copy the full SHA
    4c40b99 View commit details
    Browse the repository at this point in the history