updates to be forward compatible with changes to package:shelf_web_so…

…cket (#2539) * updates to be forward compatible with changes to package:shelf_web_socket * update built artifacts
dart-lang · Dec 10, 2024 · ab620d1 · ab620d1
1 parent 8fddd3d
commit ab620d1
Show file tree

Hide file tree

Showing 6 changed files with 10 additions and 6 deletions.
diff --git a/dwds/CHANGELOG.md b/dwds/CHANGELOG.md
@@ -1,3 +1,7 @@
+## 24.2.1-wip
+
+- Update to be forward compatible with changes to `package:shelf_web_socket`.
+
 ## 24.2.0
 
 - Consolidate `FrontendServerDdcStrategyProvider` and `FrontendServerRequireStrategyProvider` under a shared parent class. - [#2517](https://github.com/dart-lang/webdev/issues/2517)

diff --git a/dwds/lib/src/handlers/socket_connections.dart b/dwds/lib/src/handlers/socket_connections.dart
@@ -104,7 +104,7 @@ class WebSocketSocketHandler extends SocketHandler {
 
   WebSocketSocketHandler() {
     _handler = webSocketHandler(
-      (WebSocketChannel channel) =>
+      (WebSocketChannel channel, _) =>
           _connectionsStream.add(WebSocketConnection(channel)),
     );
   }

diff --git a/dwds/lib/src/services/debug_service.dart b/dwds/lib/src/services/debug_service.dart
@@ -34,13 +34,13 @@ int _clientsConnected = 0;
 
 Logger _logger = Logger('DebugService');
 
-void Function(WebSocketChannel) _createNewConnectionHandler(
+void Function(WebSocketChannel, String?) _createNewConnectionHandler(
   ChromeProxyService chromeProxyService,
   ServiceExtensionRegistry serviceExtensionRegistry, {
   void Function(Map<String, Object>)? onRequest,
   void Function(Map<String, Object?>)? onResponse,
 }) {
-  return (webSocket) {
+  return (webSocket, subprotocol) {
     final responseController = StreamController<Map<String, Object?>>();
     webSocket.sink.addStream(
       responseController.stream.map((response) {

diff --git a/dwds/lib/src/version.dart b/dwds/lib/src/version.dart
diff --git a/dwds/pubspec.yaml b/dwds/pubspec.yaml
@@ -1,6 +1,6 @@
 name: dwds
 # Every time this changes you need to run `dart run build_runner build`.
-version: 24.2.0
+version: 24.2.1-wip
 description: >-
   A service that proxies between the Chrome debug protocol and the Dart VM
   service protocol.

diff --git a/dwds/test/build/ensure_version_test.dart b/dwds/test/build/ensure_version_test.dart
@@ -18,7 +18,7 @@ void main() {
     expect(
       Version.parse(packageVersion),
       pubspec.version,
-      reason: 'Please run `pub run build_runner build '
+      reason: 'Please run `dart run build_runner build '
           '--build-filter=lib/src/version.dart` to update the version.',
     );
   });