Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix friction and restitution of individual shapes in a body #1369

Merged
merged 8 commits into from
Jul 14, 2019

Conversation

jslee02
Copy link
Member

@jslee02 jslee02 commented Jul 12, 2019

DynamicAspect was introduced to allow to set different dynamics properties (including friction and restitution properties) per shape in a BodyNode for setting the dynamic properties of individual shapes in a BodyNode. However, the constraint solver still uses the dynamics properties stored in BodyNode.

This PR deprecates the friction and restitution property related APIs in BodyNode and change the constraint solver to use the dynamics properties in DynamicAspect.

Resolves #200.


Before creating a pull request

  • Document new methods and classes
  • Format new code files using clang-format

Before merging a pull request

  • Set version target by selecting a milestone on the right side
  • Summarize this change in CHANGELOG.md
  • Add unit test(s) for this change

@jslee02 jslee02 added this to the DART 6.10.0 milestone Jul 12, 2019
@jslee02 jslee02 requested review from mxgrey and scpeters July 12, 2019 06:05
@jslee02 jslee02 changed the title Fix setting friction and restitution of individual shapes in a body Fix friction and restitution of individual shapes in a body Jul 12, 2019
@jslee02 jslee02 marked this pull request as ready for review July 12, 2019 06:10
@codecov
Copy link

codecov bot commented Jul 12, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@2466c01). Click here to learn what that means.
The diff coverage is 51.42%.

@@            Coverage Diff            @@
##             master    #1369   +/-   ##
=========================================
  Coverage          ?   56.97%           
=========================================
  Files             ?      366           
  Lines             ?    27460           
  Branches          ?        0           
=========================================
  Hits              ?    15646           
  Misses            ?    11814           
  Partials          ?        0
Impacted Files Coverage Δ
dart/dynamics/detail/BodyNodeAspect.hpp 80% <ø> (ø)
dart/constraint/ContactConstraint.hpp 100% <ø> (ø)
dart/dynamics/BodyNode.hpp 100% <ø> (ø)
dart/constraint/SoftContactConstraint.cpp 0% <0%> (ø)
dart/constraint/ContactConstraint.cpp 74.92% <100%> (ø)
dart/dynamics/BodyNode.cpp 77.25% <60%> (ø)

@scpeters
Copy link
Collaborator

this looks good to me. I'll try rebasing my branch onto this tomorrow morning

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multiple frictional properties per BodyNode
2 participants