This repository has been archived by the owner on Oct 9, 2022. It is now read-only.
Move the entry of shadow from Golang to Rust #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat(primitives): implement serde for big array * feat(eth): getting headers from json rpc in rust
* feat(mmr): remove thread implementation in mmr * refactor(internal): remove go packages and port ffi * feat(ffi): add golang ffi examples * feat(lock): clean go locks
* refactor(ffi): clean rust ffi * feat(header): complete darwinia eth header formatter * refactor(crate): rename crate name from mmr to shadow * feat(ffi): use rust struct as ffi params and resps * feat(api): complete receipt api * feat(api): add proposal api * feat(api): add async traits
* feat(mmr): remove the cache operation in mmr runner * refactor(ethash_proof): move the long name struct to ethashproof * feat(http): json string resp of ethereum types * fix(eth): the format of u256
* feat(cmd): supports shadow command in rust * feat(cmd): complete trim command and async main
|
@wuminzhe Aki, could you help review this pull request? |
Wait a minute, more tests here. |
|
@hackfisher I will review it |
wuminzhe
approved these changes
Aug 28, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Desc
Here are lots of code in shadow service are as same as
darwinia-common, for examples, eth primitives or MMR structure, rustify this repo and reduce duplicated code betweendarwinia-commonandshadow.Steps