First day with LibraryViewManager #10

jmigual · 2016-06-01T18:57:43Z

By the way now that I've seen your last message in the Mixxx devel, forget about the getButtonBar(), getLeftPane() and getRightPane() it must be set*() and the LegacySkinParser must setup and style them.

daschuer · 2016-06-01T19:04:00Z

src/library/libraryviewmanager.cpp

+    m_pLeftPane = new QStackedWidget;
+    m_features.resize(RIGHT_PANE_COUNT);
+
+    for (int i = 0; i < RIGHT_PANE_COUNT; ++i) {


Yes, this should be done by the Skin, similar how it is working today.

daschuer · 2016-06-01T19:06:18Z

IMHO you are on th right track, except the skin interaction.

jmigual · 2016-06-07T18:03:03Z

Hi Daniel,
I've made some changes if you want to review them

daschuer · 2016-06-07T20:13:35Z

src/library/library.cpp

-        delete feature;
+
+    for (LibraryFeature* f : m_features) {
+        delete f;


OK this looks scary, but works, because of the clear below.
How about using qDeleteAll or use smart pointers.

Ok, I'll use qDeleteAll here a smart pointer is not necessary, he have full knowledge of the pointer behaviour

WTrackTable was not showing anything when loading a track model, now it shows the track model by default

daschuer · 2016-07-03T10:19:08Z

src/library/libraryfeature.h

+
+    // Must be a unique name for each feature, it must be a unique name for each
+    // different feature
+    virtual QString getFeatureName() = 0;


It looks like this and its overrides are finally unused :-)

Yes! And I forgot to remove it 😓

On Sun, Jul 3, 2016, 12:19 Daniel Schürmann notifications@github.com
wrote:

In src/library/libraryfeature.h
#10 (comment):

virtual ~LibraryFeature(); virtual QVariant title() = 0; virtual QIcon getIcon() = 0;

// Must be a unique name for each feature, it must be a unique name for each

// different feature

virtual QString getFeatureName() = 0;

It looks like this and its overrides are finally unused :-)

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/daschuer/mixxx/pull/10/files/fd67608147f2b65021b6b0e7ce49ddf7a3f9ae47#r69388910,
or mute the thread
https://github.com/notifications/unsubscribe/AGMV00HCev3jAg5TxQrZUrFZuY7Qn-hNks5qR4ycgaJpZM4Ir3iU
.

daschuer · 2016-07-03T21:00:20Z

There is an issue with your own master branch.
28db1fd
Should not exist.

It looks like it is you intention that your master branch mirrors the mixxxdj/mixxx master branch, but it is not.

The issue starts with e5cb15e
This is not a real issue, since the additional commits seams not to contain code, but we should avoid future null merge commits.

This can be done by resetting your master branch:

git checkout master
git reset upstream/master --hard

You should also remove the latest null merge commit by redo the master merge:

git checkout feature/libraryManager
git reset b0fd7c7
git add src/test/durationutiltest.cpp src/util/duration.cpp
git stash
git merge upstream/master -s ours
git stash pop
git commit -a --amend
git push -f

…ager

daschuer · 2016-07-12T09:30:56Z

src/library/baseplaylistfeature.h

    PlaylistDAO &m_playlistDao;
    TrackDAO &m_trackDao;
-    PlaylistTableModel* m_pPlaylistTableModel;
+    QPointer<PlaylistTableModel> m_pPlaylistTableModel;
+    QHash<int, QPointer<PlaylistTableModel> > m_playlistTableModel;


It is hard to distinguish m_pPlaylistTableModel from m_playlistTableModel.
How about m_playlistTableModelHash?

Can m_playlistTableModelHash become private?

Since both are protected members the lifetime, should be clear.
Or are they used outside the creating class after the feature is gone?

jmigual · 2016-07-12T11:33:57Z

Yes m_playlistTableModelHash can become private. It's access is done only in the getPlaylistTableModel function, I'll change it

Fix Apple time base

Autopan improvements

update Novation Launchpad controller scripts

function pointers for signal-slot connections in effects system

Fix reading/writing of library.last_played_at

…h sync When loading a track that is not yet present in the library (and thus doesn't have any BPM because it hasn't been analyzed yet) while another deck is playing and both decks have sync enabled, a debug assertion is triggered: DEBUG ASSERT: "isValid()" in function double mixxx::Bpm::value() const at src/track/bpm.h:53 Aborted (core dumped) The backtrace looks as follows: #0 0x00007f175c87234c in __pthread_kill_implementation () at /usr/lib/libc.so.6 #1 0x00007f175c8254b8 in raise () at /usr/lib/libc.so.6 #2 0x00007f175c80f534 in abort () at /usr/lib/libc.so.6 #3 0x00007f175cf05ee4 in qt_assert(char const*, char const*, int) () at /usr/lib/libQt5Core.so.5 #4 0x000055deb2e67e1c in mixxx::(anonymous namespace)::handleMessage(QtMsgType, QMessageLogContext const&, QString const&) (type=<optimized out>, context=<optimized out>, input=<optimized out>) at src/util/logging.cpp:355 #5 0x00007f175cf47128 in () at /usr/lib/libQt5Core.so.5 #6 0x00007f175cf3fd8a in () at /usr/lib/libQt5Core.so.5 #7 0x00007f175cf06526 in QMessageLogger::critical(char const*, ...) const () at /usr/lib/libQt5Core.so.5 #8 0x000055deb2e5c720 in mixxx_debug_assert(char const*, char const*, int, char const*) (assertion=assertion@entry=0x55deb39bd0db "isValid()", file=file@entry=0x55deb39bbf30 "src/track/bpm.h", line=line@entry=53, function=function@entry=0x55deb39bbf08 "double mixxx::Bpm::value() const") at gsrc/util/assert.h:9 #9 0x000055deb2ee7e7e in mixxx_debug_assert_return_true(char const*, char const*, int, char const*) (function=0x55deb39bbf08 "double mixxx::Bpm::value() const", line=53, file=0x55deb39bbf30 "src/track/bpm.h", assertion=0x55deb39bd0db "isValid()") at gsrc/util/assert.h:18 #10 mixxx::Bpm::value() const (this=<synthetic pointer>) at src/track/bpm.h:53 #11 mixxx::operator*(mixxx::Bpm, double) (multiple=1, bpm=...) at src/track/bpm.h:160 #12 SyncControl::setLocalBpm(mixxx::Bpm) (this=<optimized out>, localBpm=...) at src/engine/sync/synccontrol.cpp:567 #13 0x000055deb34c7ba3 in EngineBuffer::postProcess(int) (this=0x55deb56eb060, iBufferSize=2048) at src/engine/enginebuffer.cpp:1318 #14 0x000055deb3139023 in EngineMaster::processChannels(int) (this=0x55deb5449440, iBufferSize=<optimized out>) at src/engine/enginemaster.cpp:383 #15 0x000055deb31394f7 in EngineMaster::process(int) (this=0x55deb5449440, iBufferSize=iBufferSize@entry=2048) at src/engine/enginemaster.cpp:410 #16 0x000055deb2f91d0b in SoundManager::onDeviceOutputCallback(long) (this=<optimized out>, iFramesPerBuffer=iFramesPerBuffer@entry=1024) at src/soundio/soundmanager.cpp:596 #17 0x000055deb32dd794 in SoundDevicePortAudio::callbackProcessClkRef(long, float*, float const*, PaStreamCallbackTimeInfo const*, unsigned long) (this=0x55deb553e6b0, framesPerBuffer=1024, out=<optimized out>, in=<optimized out>, timeInfo=<optimized out>, statusFlags=<optimized out>) at src/soundio/sounddeviceportaudio.cpp:965 This happens because `newLocalBpm` is invalid when `localBpm` is invalid. Trying to do sync decks while no tempo information is available does not make sense, so we only synchronize decks if the local BPM is available.

jmigual added 2 commits June 1, 2016 14:30

Add comments and onSearch function

8b395e5

Add LibraryViewManager to Mixxxx code

ad6947e

daschuer reviewed Jun 1, 2016
View reviewed changes

jmigual added 21 commits June 2, 2016 09:56

Changed LibraryViewManager to LibraryPaneManager

9b92539

Changed bindWidget to bindRightPane

46c0ff8

Created new skeleton for Pane manager

d58e70c

Changed destructor of library

79ecf0b

Removed libraryViewManager from main

50a849c

Add bind right and left pane functions

f3e64d6

Begin implementing right pane function and add keyboardeventfilter

db6eaaa

Merged branch master into master

e5cb15e

Change names from left right pane to sidebar expanded and librarywidget

c3259d2

Add destructor and more name refactoring

1f51cfd

Moved features constructor to function

1f3a6d5

Missed to commit rename

1391998

Move many functions from library to library pane manager

4ed43ae

Change features names

6525b48

Missed name change

2763551

Add again features vector

37c433e

Add focused() signal in wlibrary

bf599dc

Comment code to allow compiling

e708c84

Create button bar

5108305

Handle focus

96abc85

Rename add button function

4650539

jmigual added 2 commits June 7, 2016 20:05

Added stub

6baa8d0

Added button bar bind function

e8b96f3

daschuer reviewed Jun 7, 2016
View reviewed changes

jmigual added 6 commits July 2, 2016 16:39

Fixed not building

3f3fcc3

Fixed missing and hidden tables not loading

4ca315a

Rename slots to not being slots anymore and fix some bugs

208f359

WTrackTable was not showing anything when loading a track model, now it shows the track model by default

Fix AutoDJ sidebar

b3f3ff8

Add LibraryFeature pointer in WBaseLibrary instead of QString

c01cb0d

Fix search in analysis feature

b0fd7c7

daschuer reviewed Jul 3, 2016
View reviewed changes

jmigual added 7 commits July 6, 2016 09:32

Merge remote-tracking branch 'mixxxdj/master' into feature/libraryMan…

0495bbe

…ager

Fix changing playlist not working

3f00ce8

Force travis build

21c463d

Add multiple pane playlists view

d376d78

Added multipane view to crates

245f5fb

Remove unnecessary featureName

0463a11

Fixed wrong focus connection

5183a2e

jmigual mentioned this pull request Jul 7, 2016

New Library Tree #11

Closed

jmigual added 3 commits July 12, 2016 09:51

Add usefull functions in LibraryFeature to avoid coding

4b8cbf3

Fix sorting problem when setting a new trackModel

3a78153

Fixed bug with HistoryFeature causing SIGSEGV

083e5fb

daschuer reviewed Jul 12, 2016
View reviewed changes

Fix crash due to right clicking to the empty space of AutoDJ

ba5442c

jmigual closed this Jan 15, 2017

jmigual deleted the feature/libraryManager branch January 24, 2017 21:39

daschuer pushed a commit that referenced this pull request Mar 16, 2017

Merge pull request #10 from daschuer/1.12-shoutcast-fixes

cef330c

Fix Apple time base

daschuer pushed a commit that referenced this pull request Oct 8, 2017

Merge pull request #10 from daschuer/autopan_improvements

2378361

Autopan improvements

daschuer pushed a commit that referenced this pull request Jun 15, 2020

Merge pull request #10 from dszakallas/upgrade-lp

f2610e3

update Novation Launchpad controller scripts

daschuer pushed a commit that referenced this pull request Jan 3, 2021

Merge pull request #10 from Be-ing/effects_refactoring

b9605cc

function pointers for signal-slot connections in effects system

daschuer pushed a commit that referenced this pull request Jan 3, 2021

Merge pull request #10 from uklotzde/last-played-squashed

57ac9c8

Fix reading/writing of library.last_played_at

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

First day with LibraryViewManager #10

First day with LibraryViewManager #10

jmigual commented Jun 1, 2016

daschuer Jun 1, 2016

daschuer commented Jun 1, 2016

jmigual commented Jun 7, 2016

daschuer Jun 7, 2016

jmigual Jun 8, 2016

daschuer Jul 3, 2016

jmigual Jul 3, 2016

daschuer commented Jul 3, 2016

daschuer Jul 12, 2016

jmigual commented Jul 12, 2016

First day with LibraryViewManager #10

First day with LibraryViewManager #10

Conversation

jmigual commented Jun 1, 2016

daschuer Jun 1, 2016

Choose a reason for hiding this comment

daschuer commented Jun 1, 2016

jmigual commented Jun 7, 2016

daschuer Jun 7, 2016

Choose a reason for hiding this comment

jmigual Jun 8, 2016

Choose a reason for hiding this comment

daschuer Jul 3, 2016

Choose a reason for hiding this comment

jmigual Jul 3, 2016

Choose a reason for hiding this comment

daschuer commented Jul 3, 2016

daschuer Jul 12, 2016

Choose a reason for hiding this comment

jmigual commented Jul 12, 2016