Enable graceful failure #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Clubhouse Story #45296: LikeShop images not loading in dash-web tab. |
benjamin-t-frost
requested review from
kepheusikarius,
coleman-benja,
kaaneroglu and
kirbyhackett
benjamin-t-frost
changed the title
kepheusikarius
approved these changes
Jun 11, 2021
coleman-benja
approved these changes
Jun 14, 2021
Lohins
approved these changes
Jun 14, 2021
benjamin-t-frost
deleted the
benjamin-t-frost/ch45296/likeshop-images-not-loading-in-dash-web-tab
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Story details: https://app.clubhouse.io/dashhudson/story/45296
should set error when ldClient emits an erroris the only test that actually changed.I think that, given we cannot assume that the failure value should always be false, it should be up to the developer to determine how to react in each situation.