Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(coinbase): login & coin parse error #1259

Merged
merged 3 commits into from
Feb 28, 2024
Merged

fix(coinbase): login & coin parse error #1259

merged 3 commits into from
Feb 28, 2024

Conversation

Syn-McJ
Copy link
Member

@Syn-McJ Syn-McJ commented Feb 22, 2024

  • Coinbase login in a webview doesn't work.
  • Some accounts throw an error because a small balance cannot be parsed.

Issue being fixed or feature implemented

  • Replaced WebView authentication with Custom Tab authentication.
  • Round Coinbase balance if cannot parse it into Coin
  • Migrated WalletUriHandlerActivity to Kotlin

Related PR's and Dependencies

Screenshots / Videos

How Has This Been Tested?

  • QA (Mobile Team)

Checklist:

  • I have performed a self-review of my own code and added comments where necessary
  • I have added or updated relevant unit/integration/functional/e2e tests

@Syn-McJ Syn-McJ self-assigned this Feb 22, 2024
@Syn-McJ Syn-McJ marked this pull request as draft February 22, 2024 14:24
@Syn-McJ Syn-McJ marked this pull request as ready for review February 23, 2024 08:04
@HashEngineering HashEngineering merged commit 6c706ef into master Feb 28, 2024
3 checks passed
@HashEngineering HashEngineering deleted the fix-coinbase-login branch September 9, 2024 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HashEngineering HashEngineering HashEngineering approved these changes

Assignees

@Syn-McJ Syn-McJ

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Syn-McJ @HashEngineering