Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prevent NPE after corrupt wallet requires backup restoration #1267

Merged
merged 1 commit into from
Mar 9, 2024

Conversation

HashEngineering
Copy link
Collaborator

@HashEngineering HashEngineering commented Mar 8, 2024

Issue being fixed or feature implemented

This fixes a crash that one user had 900+ times.

If the wallet file becomes corrupted, the backup wallet file is restored, but during that process wallet is null and will result in an NPE when the blockchain is reset.

Related PR's and Dependencies

Screenshots / Videos

How Has This Been Tested?

  • QA (Mobile Team)

Checklist:

  • I have performed a self-review of my own code and added comments where necessary
  • I have added or updated relevant unit/integration/functional/e2e tests

@HashEngineering HashEngineering self-assigned this Mar 8, 2024
@HashEngineering HashEngineering merged commit 16ede88 into master Mar 9, 2024
2 checks passed
Copy link

@Setarland Setarland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@HashEngineering HashEngineering deleted the bugfix-restore-backup-crash branch April 30, 2024 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants