-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NMA-341 Search Blockchain User (backend) #410
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tly from CreateIdentityService
Moved notification related code to dedicated class CreateIdentityNotification.
HashEngineering
changed the base branch from
evonet-develop
to
evonet-register-username-two
May 15, 2020 23:37
HashEngineering
changed the base branch from
evonet-register-username-two
to
evonet-develop
May 18, 2020 15:13
tomasz-ludek
approved these changes
May 22, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works like a charm :)
… into evonet-search-usernames
The other PR's need to be rebased and merged before this is merged. This will be done after #414 |
… into evonet-search-usernames
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is untested code
It depends on PR's from the other dependencies:
dapi-client:
dashpay/dapi-client-android#4 (fixes bug in orderBy queries)
android-dashpay:
dashpay/android-dashpay#2 (add search for username support)
dashpay/android-dashpay#4 (add contact request query support)