Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: removed step 4 from ui of username registration. #421

Merged
merged 2 commits into from
May 29, 2020
Merged

fix: removed step 4 from ui of username registration. #421

merged 2 commits into from
May 29, 2020

Conversation

desamtralized
Copy link
Contributor

Issue being fixed or feature implemented

  • Removed step 4 of username registration process to align with designs.

What was done?

  • Removed string for step 4 and it's access/usage from ProcessingIdentityViewHolder

How Has This Been Tested?

Breaking Changes

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

Copy link
Collaborator

@tomasz-ludek tomasz-ludek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good. I can't test it at the moment though.

@HashEngineering HashEngineering merged commit c4d8801 into dashpay:evonet-develop May 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants