Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NMA-513]: Username Registration Freeze (UI) #428

Merged
merged 1 commit into from
Jun 4, 2020

Conversation

tomasz-ludek
Copy link
Collaborator

@tomasz-ludek tomasz-ludek commented Jun 2, 2020

Issue being fixed or feature implemented

The UI freeze on the Create Username Screen, after pressing the Register Button. The animation freezes in the next screen, possibly while the Create Identity Service is started.

What was done?

Fixed a bug causing the deriveKey(...) and decryptSeed(...) methods in the CreateIdentityService to be executed on main thread.

How Has This Been Tested?

My own tests and QA validation

Breaking Changes

N/A

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@HashEngineering HashEngineering merged commit 5a493bc into evonet-develop Jun 4, 2020
@HashEngineering HashEngineering deleted the derive-key-on-main-thread-issue branch June 26, 2020 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants