Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contact Request UI - Part 1 #438

Merged
merged 4 commits into from
Jun 12, 2020
Merged

Contact Request UI - Part 1 #438

merged 4 commits into from
Jun 12, 2020

Conversation

desamtralized
Copy link
Contributor

@desamtralized desamtralized commented Jun 10, 2020

Issue being fixed or feature implemented

Showing user screen when tapping on a user from the search results.

What was done?

  • Created layout for User representation when clicking on a result from user search, with its respective sections for sending/accepting contact requests. (DashPayUserActivity)
  • Fixed small visual bug in SearchUserActivity where the results were being clipped at the end of the screen. (activity_search_dashpay_profile…)
  • Added fromDocument method in DashPayProfile class to allow its creation from a Platform Document.
  • Created UserAvatarPlaceholderDrawable class to show a default avatar image with the first letter of the username. This class is being used at home screen, search results and user screen. (HeaderBalanceFragment, UsernameSearchResultsAdapter, DashPayUserActivity)

@HashEngineering HashEngineering mentioned this pull request Jun 10, 2020
5 tasks
@HashEngineering
Copy link
Collaborator

HashEngineering commented Jun 10, 2020

This or something similar is missing from AndroidManifest.xml

        <activity android:name="de.schildbach.wallet.ui.DashPayUserActivity"
            android:screenOrientation="portrait"
            android:theme="@style/My.Theme.ChildActivity" />

Copy link
Collaborator

@HashEngineering HashEngineering left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is one critical and required change on the AndroidManifest.xml and one optional change regarding DashPayProfile.fromDocument.

- Added DashPayUserActivity in AndroidManifest.xml
- Using DashPayProfile.fromDocument in PlatformRepo profile recovery method
- Profile creation will not be enforced.
@desamtralized desamtralized marked this pull request as ready for review June 12, 2020 17:20
@HashEngineering HashEngineering self-requested a review June 12, 2020 21:26
@HashEngineering HashEngineering merged commit 3ac082e into dashpay:evonet-develop Jun 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants