-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Contact Request UI - Part 1 #438
Merged
HashEngineering
merged 4 commits into
dashpay:evonet-develop
from
desamtralized:evonet-contact-request-ui-part-1
Jun 12, 2020
Merged
Contact Request UI - Part 1 #438
HashEngineering
merged 4 commits into
dashpay:evonet-develop
from
desamtralized:evonet-contact-request-ui-part-1
Jun 12, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
5 tasks
This or something similar is missing from AndroidManifest.xml
|
HashEngineering
requested changes
Jun 10, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is one critical and required change on the AndroidManifest.xml and one optional change regarding DashPayProfile.fromDocument.
- Added DashPayUserActivity in AndroidManifest.xml - Using DashPayProfile.fromDocument in PlatformRepo profile recovery method
- Profile creation will not be enforced.
HashEngineering
approved these changes
Jun 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
Showing user screen when tapping on a user from the search results.
What was done?
DashPayUserActivity
)SearchUserActivity
where the results were being clipped at the end of the screen. (activity_search_dashpay_profile…
)fromDocument
method inDashPayProfile
class to allow its creation from a Platform Document.UserAvatarPlaceholderDrawable
class to show a default avatar image with the first letter of the username. This class is being used at home screen, search results and user screen. (HeaderBalanceFragment
,UsernameSearchResultsAdapter
,DashPayUserActivity
)