Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NMA-330: DashPay: Accept Contact Request #450

Merged
merged 11 commits into from
Jul 9, 2020
Merged

NMA-330: DashPay: Accept Contact Request #450

merged 11 commits into from
Jul 9, 2020

Conversation

HashEngineering
Copy link
Collaborator

@HashEngineering HashEngineering commented Jun 29, 2020 •
edited
Loading

Issue being fixed or feature implemented

Add functionality to Accept buttons to accept a contact request

There are many screens that have an Accept Button:

  1. Notifications Screen - when the request is accepted, the contact request should change into a contact.
  2. Contacts Screen - when the request is accepted, the contact request should be removed from the Contact Requests section and appear in the My Contacts section (screen refresh)
  3. Contact Requests Screen - when the request is accepted, the contact request should disappear
  4. DashPay User Screen - when the request is accepted, the Accept and Ignore Buttons should disappear. Returning to the previous screen should show the current state of the request (no accept or ignore buttons)

known issues:

  1. There are periodic failures from platform (UNAVAILABLE)
  2. The Home Screen may not update every 15 seconds
  3. The Contacts Screen, Notification Screens don't update from the network when started, only the local database

@HashEngineering HashEngineering self-assigned this Jul 1, 2020
@HashEngineering HashEngineering changed the base branch from dashpay-notifications to evonet-develop July 3, 2020 15:15
@HashEngineering
Copy link
Collaborator Author

This PR is incomplete

tomasz-ludek
tomasz-ludek requested changes Jul 9, 2020
View reviewed changes
Copy link
Collaborator

@tomasz-ludek tomasz-ludek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works good. Small refactoring requested.

wallet/src/de/schildbach/wallet/ui/SearchUserActivity.kt Outdated Show resolved Hide resolved
wallet/src/de/schildbach/wallet/ui/dashpay/ContactsActivity.kt Outdated Show resolved Hide resolved
wallet/src/de/schildbach/wallet/ui/dashpay/NotificationsActivity.kt Outdated Show resolved Hide resolved
tomasz-ludek
tomasz-ludek requested changes Jul 9, 2020
View reviewed changes
Copy link
Collaborator

@tomasz-ludek tomasz-ludek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works good. Small refactoring requested.

tomasz-ludek
tomasz-ludek approved these changes Jul 9, 2020
View reviewed changes
Copy link
Collaborator

@tomasz-ludek tomasz-ludek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done!

@HashEngineering HashEngineering merged commit 3314b49 into evonet-develop Jul 9, 2020
@tomasz-ludek tomasz-ludek deleted the dashpay-accept-request branch July 11, 2020 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomasz-ludek tomasz-ludek tomasz-ludek approved these changes

@desamtralized desamtralized Awaiting requested review from desamtralized

Assignees

@HashEngineering HashEngineering

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HashEngineering @tomasz-ludek