DashPay: Send payment | Contact UI #464

HashEngineering · 2020-07-28T00:04:46Z

Issue being fixed or feature implemented

NMA-372

Add ability to send payments to a contact.

Known Issues:

For the DashPayUserActivity, the notifications currently use a duplicate TransactionViewHolder class (in Kotlin). This can be refactored in a different story along with other view holders to separate files and possibly also replace the Java version
When starting the flow from the Select a Contact Screen, the flow ends at that screen after closing the DashPayUserActivity at the end of the process, instead of the Payments Screen. I am not sure how to return to the previous screen from there.
When paying a contact, the same address may be used. This is not ideal, a new address should be used. This would be fixed in the dashpay library. This has been addressed in dashj.

Related PR's and Dependencies

dashpay/android-dashpay#18
dashpay/dashj#82

Screenshots / Videos

How Has This Been Tested?

QA (Mobile Team)

Checklist:

I have performed a self-review of my own code and added comments where necessary
I have added or updated relevant unit/integration/functional/e2e tests

…app)

…s and names

* New classes NotificationsLiveData, NotificationCountLiveData * Listeners react to updating the contact database and then update data * The notifications screen is live

* Remove timer code from BlockchainServiceImpl

…ate on resume

… into dpp-0.13

…o/dash-wallet into dpp-0.13

…into dpp-0.13 # Conflicts: # wallet/src/de/schildbach/wallet/ui/HeaderBalanceFragment.java # wallet/src/de/schildbach/wallet/ui/dashpay/CreateIdentityService.kt # wallet/src/de/schildbach/wallet/ui/dashpay/DashPayViewModel.kt # wallet/src/de/schildbach/wallet/ui/dashpay/NotificationsActivity.kt # wallet/src/de/schildbach/wallet/ui/dashpay/PlatformRepo.kt

Fix other bugs with EnterAmountFragment and ConfirmTransactionDialog

Submit new bloom filters when contact is added

…ier)

…o dashpay-send-payment # Conflicts: # wallet/src/de/schildbach/wallet/ui/dashpay/DashPayViewModel.kt # wallet/src/de/schildbach/wallet/ui/dashpay/PlatformRepo.kt

wallet/src/de/schildbach/wallet/ui/dashpay/DashPayViewModel.kt

wallet/src/de/schildbach/wallet/ui/DashPayUserActivity.kt

… is not completely registered

…-wallet into dashpay-send-payment

Otherwise there was a crash becuase of a missing Looper.prepare() or the timer didn't work.

tomasz-ludek

Good stuff!

…into dashpay-send-payment # Conflicts: # wallet/src/de/schildbach/wallet/ui/dashpay/ContactsFragment.kt

Reverted deletion of timerHandler which was replaced by backgroundHandler

…dler with direct coroutine approach

tomasz-ludek · 2020-08-04T12:58:21Z

wallet/src/de/schildbach/wallet/livedata/EncryptWalletLiveData.kt

-                if(initialize) {
-                    walletApplication.saveWalletAndFinalizeInitialization()
-                }


This was moved out of the background thread therefore we should retest all the wallet initialization scenarios.
2e3d14e#diff-05204d8915f357bdf7c4bfcbed61d7c3R79

tomasz-ludek · 2020-08-04T13:03:04Z

wallet/src/de/schildbach/wallet/ui/dashpay/PlatformRepo.kt

+            blockchainIdentityDataDaoAsync.load()?.let {
+                blockchainIdentity = initBlockchainIdentity(it, walletApplication.wallet)
+                while (isActive) {
+                    log.info("Timer: Update contacts")
+                    platformRepoInstance.updateContactRequests()
+                    delay(UPDATE_TIMER_DELAY)
+                }
+            }


This will load the blockchainIdentity and start periodic contacts sync without the need of using Handler.
GlobalScope is active as long as the app is launched.

Periodic contacts sync will not start if there is no blockchainIdentity yet.

tomasz-ludek · 2020-08-04T13:03:59Z

wallet/src/de/schildbach/wallet/ui/dashpay/CreateIdentityService.kt

@@ -317,6 +317,8 @@ class CreateIdentityService : LifecycleService() {
            platformRepo.updateCreationState(blockchainIdentityData, CreationState.DONE)
        }

+        PlatformRepo.getInstance().init()


This will also start the periodic contacts sync

…romProtobuf() method so that it is triggered for a regular app launches. During the wallet restoration it will be triggered after restoring the identity.

…dWalletFromProtobuf() method so that it is triggered for a regular app launches. During the wallet restoration it will be triggered after restoring the identity." This reverts commit 9fa9947

…process is complete.

HashEngineering · 2020-08-04T15:35:28Z

This will be merged after the next round of QA testing.

HashEngineering added 30 commits July 6, 2020 16:41

Use dashpay, platform-core, dpp, dapi-client 0.13-SNAPSHOT

d0b1f71

Update to DPP 0.13

9bace73

Change primary key contents of Contact Request table

bd6f471

PlatformRepo: Recover Profile if the DashPay contract exists

9bd0826

PlatformRepo: Use records.dashIdentity instead of ownerId

8256b84

BlockchainService: Set the DapiClient's masternode list

d124f0e

Fix BlockchainIdentity construction (use same platform object as the …

7e24158

…app)

PlatformRepo: If there are on contactRequests, skip searching profile…

e73b2b3

…s and names

PlatformRepo: change isPlatformAvailable

23bef1b

Refactor some liveData from DashPayViewModel to new classes

1e3530c

* New classes NotificationsLiveData, NotificationCountLiveData * Listeners react to updating the contact database and then update data * The notifications screen is live

Fix sort order for notifications

b7b756b

Use the fromContactRequest date

78d7597

PlatformRepo: Make Singleton, replace contact update timer

7145eb6

* Remove timer code from BlockchainServiceImpl

Update home screen data when resumed

59f7c7a

ContactsActivity: Update when the database is changed, trigger DB upd…

a388068

…ate on resume

PlatformRepo: Fix bug that prevented updating contacts

c87ef6a

Merge branch 'evonet-develop' of https://github.com/dashevo/dash-wallet…

3e397fc

… into dpp-0.13

Merge branch 'dashpay-notifications-fix' of https://github.com/dashev…

576b010

…o/dash-wallet into dpp-0.13

Use dpp 0.14-SNAPSHOT related libraries

ace4e58

Add Sending To on Enter Amount and Confirm Screens

41ffaae

PlatformRepo: Add contact keychains to wallet when updating contacts

ec0fb30

Add NotificationItem to handle many types of notifications

ead06e4

Add Preliminary History to Profile Page if contact was accepted

81ec13b

Add Preliminary History to Profile Page if contact was accepted (Part 2)

a4a1200

Add username support to Transaction Details screens

5a10e4e

Fix other bugs with EnterAmountFragment and ConfirmTransactionDialog

DashPayUserActivity: only show history if its a full contact

49701a7

BlockchainService: Add reset bloom filters action

4d74c50

Submit new bloom filters when contact is added

DashPayUserActivity: Update screen after Send/Accept (was broken earl…

f553e09

…ier)

Merge branch 'dpp-0.13' of https://github.com/dashevo/dash-wallet int…

a01e617

…o dashpay-send-payment # Conflicts: # wallet/src/de/schildbach/wallet/ui/dashpay/DashPayViewModel.kt # wallet/src/de/schildbach/wallet/ui/dashpay/PlatformRepo.kt

HashEngineering commented Jul 29, 2020

View reviewed changes

wallet/src/de/schildbach/wallet/ui/dashpay/DashPayViewModel.kt Outdated Show resolved Hide resolved

HashEngineering commented Jul 29, 2020

View reviewed changes

wallet/src/de/schildbach/wallet/ui/DashPayUserActivity.kt Outdated Show resolved Hide resolved

HashEngineering and others added 13 commits July 30, 2020 10:53

Don't update contacts if there is no dashpay contract or the username…

7d98682

… is not completely registered

Replace runBlocking in two places

1934d99

Use loadDistinct when getting profile information

defb02c

Move RoomDatabaseExtensions to data

b0b07c9

Basic implementation of blockchainIdentity caching

7a9c9ca

Merge branch 'dashpay-send-payment' of http://github.com/dashevo/dash…

6777ded

…-wallet into dashpay-send-payment

Removed obsolete code

c9a0238

Fixed crash when initializing PlatformRepo

41fa6bb

Fixed crash when initializing PlatformRepo

c64440f

Merge branch 'dashpay-send-payment' of http://github.com/dashevo/dash…

c925ab0

…-wallet into dashpay-send-payment

Move the start timer back to WalletApplication.initPlatform

be80467

Otherwise there was a crash becuase of a missing Looper.prepare() or the timer didn't work.

Remove unused code (blockchainIdentity)

0db2cea

Remove other runBlocking {}

4d1c575

tomasz-ludek approved these changes Aug 3, 2020

View reviewed changes

HashEngineering and others added 5 commits August 3, 2020 12:18

Merge branch 'evonet-develop' of http://github.com/dashevo/dash-wallet …

33411f5

…into dashpay-send-payment # Conflicts: # wallet/src/de/schildbach/wallet/ui/dashpay/ContactsFragment.kt

DashPayUserActivity: Remove unused createIntent with runBlocking

34579ad

PlatformRepo: Use backgroundHandler to avoid crashes with Handler

9266de2

Moved PlatformRepo initialization into main thread.

2e3d14e

Reverted deletion of timerHandler which was replaced by backgroundHandler

Changed the way of performing periodic contacts sync by replacing Han…

172460c

…dler with direct coroutine approach

tomasz-ludek reviewed Aug 4, 2020

View reviewed changes

tomasz-ludek and others added 3 commits August 4, 2020 16:46

Moved PlatformRepo initialization in WalletApplication to loadWalletF…

9fa9947

…romProtobuf() method so that it is triggered for a regular app launches. During the wallet restoration it will be triggered after restoring the identity.

Revert "Moved PlatformRepo initialization in WalletApplication to loa…

ea39e16

…dWalletFromProtobuf() method so that it is triggered for a regular app launches. During the wallet restoration it will be triggered after restoring the identity." This reverts commit 9fa9947

CreateIdentityService: initialize the PlatformRepo after the restore …

a484ced

…process is complete.

HashEngineering merged commit 437e12c into evonet-develop Aug 4, 2020

tomasz-ludek deleted the dashpay-send-payment branch August 14, 2020 08:55

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

DashPay: Send payment | Contact UI #464

DashPay: Send payment | Contact UI #464

HashEngineering commented Jul 28, 2020 •

edited

Loading

tomasz-ludek left a comment

tomasz-ludek Aug 4, 2020 •

edited

Loading

tomasz-ludek Aug 4, 2020 •

edited

Loading

tomasz-ludek Aug 4, 2020

HashEngineering commented Aug 4, 2020

DashPay: Send payment | Contact UI #464

DashPay: Send payment | Contact UI #464

Conversation

HashEngineering commented Jul 28, 2020 • edited Loading

Issue being fixed or feature implemented

Related PR's and Dependencies

Screenshots / Videos

How Has This Been Tested?

Checklist:

tomasz-ludek left a comment

Choose a reason for hiding this comment

tomasz-ludek Aug 4, 2020 • edited Loading

Choose a reason for hiding this comment

tomasz-ludek Aug 4, 2020 • edited Loading

Choose a reason for hiding this comment

tomasz-ludek Aug 4, 2020

Choose a reason for hiding this comment

HashEngineering commented Aug 4, 2020

HashEngineering commented Jul 28, 2020 •

edited

Loading

tomasz-ludek Aug 4, 2020 •

edited

Loading

tomasz-ludek Aug 4, 2020 •

edited

Loading