Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DashPay: Change app name to DashPay Evonet #486

Merged
merged 4 commits into from
Aug 25, 2020
Merged

DashPay: Change app name to DashPay Evonet #486

merged 4 commits into from
Aug 25, 2020

Conversation

HashEngineering
Copy link
Collaborator

@HashEngineering HashEngineering commented Aug 24, 2020 •
edited
Loading

Issue being fixed or feature implemented

  • Change app name to DashPay Evonet for all networks
  • Set Evonet build icon color to yellow to distinguish with other devnet builds
  • Set version to match version code

Related PR's and Dependencies

Screenshots / Videos

Screenshot_1598305450

How Has This Been Tested?

  • QA (Mobile Team)

Checklist:

  • I have performed a self-review of my own code and added comments where necessary
  • I have added or updated relevant unit/integration/functional/e2e tests

@HashEngineering HashEngineering changed the base branch from master to evonet-develop August 24, 2020 21:52
@HashEngineering HashEngineering self-assigned this Aug 24, 2020
tomasz-ludek
tomasz-ludek approved these changes Aug 25, 2020
View reviewed changes
Copy link
Collaborator

@tomasz-ludek tomasz-ludek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
Shiiiiiip it! ;)

wallet/AndroidManifest.xml
Comment on lines +6 to +7
android:versionCode="80002"
android:versionName="8.0.2-dashpay">
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@HashEngineering HashEngineering merged commit 7ecd4e1 into evonet-develop Aug 25, 2020
@HashEngineering HashEngineering deleted the dashpay-app-name branch September 11, 2020 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomasz-ludek tomasz-ludek tomasz-ludek approved these changes

Assignees

@HashEngineering HashEngineering

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HashEngineering @tomasz-ludek