Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NMA-640 | Scan QR Code | Backward Compatibility #536

Merged
merged 1 commit into from
Oct 29, 2020
Merged

NMA-640 | Scan QR Code | Backward Compatibility #536

merged 1 commit into from
Oct 29, 2020

Conversation

desamtralized
Copy link
Contributor

Not loading user from a scanned QR if the wallet has no registered user.

Issue being fixed or feature implemented

Related PR's and Dependencies

Screenshots / Videos

How Has This Been Tested?

  • QA (Mobile Team)

Checklist:

  • I have performed a self-review of my own code and added comments where necessary
  • I have added or updated relevant unit/integration/functional/e2e tests

HashEngineering
HashEngineering reviewed Oct 27, 2020
View reviewed changes
Copy link
Collaborator

@HashEngineering HashEngineering left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code is clean and it works on a Krip K5.

On the Krip K5, this appears to have fixed a crash.

@HashEngineering HashEngineering merged commit 252406a into evonet-develop Oct 29, 2020
@HashEngineering HashEngineering deleted the dashpay-qr-backward-compability branch February 3, 2021 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomasz-ludek tomasz-ludek tomasz-ludek approved these changes

@HashEngineering HashEngineering HashEngineering approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@desamtralized @HashEngineering @tomasz-ludek