Skip to content

Commit

Permalink
test/setup: Use LoadChainstate
Browse files Browse the repository at this point in the history
  • Loading branch information
@kwvg
kwvg committed Dec 16, 2024
1 parent 459f339 commit 09ab629
Show file tree
Hide file tree
Showing 3 changed files with 108 additions and 42 deletions.
106 changes: 72 additions & 34 deletions src/test/util/setup_common.cpp
View file
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,8 @@
#include <net.h>
#include <net_processing.h>
#include <noui.h>
#include <node/blockstorage.h> // for fReindex, fPruneMode
#include <node/chainstate.h> // for LoadChainstate
#include <node/miner.h>
#include <policy/fees.h>
#include <pow.h>
Expand All @@ -38,6 +40,7 @@
#include <rpc/server.h>
#include <scheduler.h>
#include <script/sigcache.h>
#include <shutdown.h> // for ShutdownRequested
#include <spork.h>
#include <stats/client.h>
#include <streams.h>
Expand Down Expand Up @@ -103,37 +106,38 @@ std::ostream& operator<<(std::ostream& os, const uint256& num)
return os;
}

void DashTestSetup(NodeContext& node, const CChainParams& chainparams)
void DashChainstateSetup(ChainstateManager& chainman,
NodeContext& node,
bool fReset,
bool fReindexChainState,
const Consensus::Params& consensus_params)
{
CChainState& chainstate = Assert(node.chainman)->ActiveChainstate();
DashChainstateSetup(chainman, *Assert(node.govman.get()), *Assert(node.mn_metaman.get()), *Assert(node.mn_sync.get()),
*Assert(node.sporkman.get()), node.mn_activeman, node.chain_helper, node.cpoolman, node.dmnman,
node.evodb, node.mnhf_manager, llmq::quorumSnapshotManager, node.llmq_ctx,
Assert(node.mempool.get()), fReset, fReindexChainState, consensus_params);
}

node.dmnman = std::make_unique<CDeterministicMNManager>(chainstate, *node.evodb);
node.mempool->ConnectManagers(node.dmnman.get());
void DashChainstateSetupClose(NodeContext& node)
{
DashChainstateSetupClose(node.chain_helper, node.cpoolman, node.dmnman, node.mnhf_manager,
llmq::quorumSnapshotManager, node.llmq_ctx, Assert(node.mempool.get()));
}

void DashPostChainstateSetup(NodeContext& node)
{
node.cj_ctx = std::make_unique<CJContext>(*node.chainman, *node.connman, *node.dmnman, *node.mn_metaman, *node.mempool,
/*mn_activeman=*/nullptr, *node.mn_sync, node.peerman, /*relay_txes=*/true);
#ifdef ENABLE_WALLET
node.coinjoin_loader = interfaces::MakeCoinJoinLoader(*node.cj_ctx->walletman);
#endif // ENABLE_WALLET
node.llmq_ctx = std::make_unique<LLMQContext>(*node.chainman, *node.dmnman, *node.evodb, *node.mn_metaman, *node.mnhf_manager, *node.sporkman, *node.mempool,
/*mn_activeman=*/nullptr, *node.mn_sync, /*unit_tests=*/true, /*wipe=*/false);
Assert(node.mnhf_manager)->ConnectManagers(node.chainman.get(), node.llmq_ctx->qman.get());
node.chain_helper = std::make_unique<CChainstateHelper>(*node.cpoolman, *node.dmnman, *node.mnhf_manager, *node.govman, *(node.llmq_ctx->quorum_block_processor), *node.chainman,
chainparams.GetConsensus(), *node.mn_sync, *node.sporkman, *(node.llmq_ctx->clhandler), *(node.llmq_ctx->qman));
}

void DashTestSetupClose(NodeContext& node)
void DashPostChainstateSetupClose(NodeContext& node)
{
node.chain_helper.reset();
node.llmq_ctx->Interrupt();
node.llmq_ctx->Stop();
Assert(node.mnhf_manager)->DisconnectManagers();
node.llmq_ctx.reset();
#ifdef ENABLE_WALLET
node.coinjoin_loader.reset();
#endif // ENABLE_WALLET
node.mempool->DisconnectManagers();
node.dmnman.reset();
node.cj_ctx.reset();
}

Expand Down Expand Up @@ -240,8 +244,10 @@ ChainTestingSetup::ChainTestingSetup(const std::string& chainName, const std::ve
m_node.fee_estimator = std::make_unique<CBlockPolicyEstimator>();
m_node.mempool = std::make_unique<CTxMemPool>(m_node.fee_estimator.get(), 1);

m_cache_sizes = CalculateCacheSizes(m_args);

m_node.chainman = std::make_unique<ChainstateManager>();
m_node.chainman->m_blockman.m_block_tree_db = std::make_unique<CBlockTreeDB>(1 << 20, true);
m_node.chainman->m_blockman.m_block_tree_db = std::make_unique<CBlockTreeDB>(m_cache_sizes.block_tree_db, true);

m_node.mn_metaman = std::make_unique<CMasternodeMetaMan>();
m_node.netfulfilledman = std::make_unique<CNetFulfilledRequestManager>();
Expand Down Expand Up @@ -280,19 +286,38 @@ TestingSetup::TestingSetup(const std::string& chainName, const std::vector<const
// instead of unit tests, but for now we need these here.
RegisterAllCoreRPCCommands(tableRPC);

{
LOCK(::cs_main);

m_node.chainman->InitializeChainstate(m_node.mempool.get(), *m_node.evodb, m_node.chain_helper, llmq::chainLocksHandler, llmq::quorumInstantSendManager);
m_node.chainman->ActiveChainstate().InitCoinsDB(
/* cache_size_bytes */ 1 << 23, /* in_memory */ true, /* should_wipe */ false);
assert(!m_node.chainman->ActiveChainstate().CanFlushToDisk());
m_node.chainman->ActiveChainstate().InitCoinsCache(1 << 23);
assert(m_node.chainman->ActiveChainstate().CanFlushToDisk());
if (!m_node.chainman->ActiveChainstate().LoadGenesisBlock()) {
throw std::runtime_error("LoadGenesisBlock failed.");
}
}
auto rv = LoadChainstate(fReindex.load(),
*Assert(m_node.chainman.get()),
*Assert(m_node.govman.get()),
*Assert(m_node.mn_metaman.get()),
*Assert(m_node.mn_sync.get()),
*Assert(m_node.sporkman.get()),
m_node.mn_activeman,
m_node.chain_helper,
m_node.cpoolman,
m_node.dmnman,
m_node.evodb,
m_node.mnhf_manager,
llmq::chainLocksHandler,
llmq::quorumInstantSendManager,
llmq::quorumSnapshotManager,
m_node.llmq_ctx,
Assert(m_node.mempool.get()),
fPruneMode,
m_args.GetBoolArg("-addressindex", DEFAULT_ADDRESSINDEX),
!m_args.GetBoolArg("-disablegovernance", !DEFAULT_GOVERNANCE_ENABLE),
m_args.GetBoolArg("-spentindex", DEFAULT_SPENTINDEX),
m_args.GetBoolArg("-timestampindex", DEFAULT_TIMESTAMPINDEX),
m_args.GetBoolArg("-txindex", DEFAULT_TXINDEX),
chainparams.GetConsensus(),
chainparams.NetworkIDString(),
m_args.GetBoolArg("-reindex-chainstate", false),
m_cache_sizes.block_tree_db,
m_cache_sizes.coins_db,
m_cache_sizes.coins,
/*block_tree_db_in_memory=*/true,
/*coins_db_in_memory=*/true);
assert(!rv.has_value());

m_node.banman = std::make_unique<BanMan>(m_args.GetDataDirBase() / "banlist", nullptr, DEFAULT_MISBEHAVING_BANTIME);
m_node.peerman = PeerManager::make(chainparams, *m_node.connman, *m_node.addrman, m_node.banman.get(),
Expand All @@ -305,7 +330,7 @@ TestingSetup::TestingSetup(const std::string& chainName, const std::vector<const
m_node.connman->Init(options);
}

DashTestSetup(m_node, chainparams);
DashPostChainstateSetup(m_node);

BlockValidationState state;
if (!m_node.chainman->ActiveChainstate().ActivateBestChain(state)) {
Expand All @@ -315,8 +340,21 @@ TestingSetup::TestingSetup(const std::string& chainName, const std::vector<const

TestingSetup::~TestingSetup()
{
DashTestSetupClose(m_node);
m_node.connman->Stop();
DashPostChainstateSetupClose(m_node);

// Interrupt() and PrepareShutdown() routines
if (m_node.llmq_ctx) {
m_node.llmq_ctx->Interrupt();
m_node.llmq_ctx->Stop();
}
if (m_node.connman) {
m_node.connman->Stop();
}

// DashChainstateSetup() is called by LoadChainstate() internally but
// winding them down is our responsibility
DashChainstateSetupClose(m_node);

m_node.peerman.reset();
m_node.banman.reset();
}
Expand Down
20 changes: 17 additions & 3 deletions src/test/util/setup_common.h
View file
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
#include <fs.h>
#include <key.h>
#include <util/system.h>
#include <node/caches.h>
#include <node/context.h>
#include <pubkey.h>
#include <random.h>
Expand All @@ -24,6 +25,9 @@
#include <vector>

class CChainParams;
namespace Consensus {
struct Params;
};

/** This is connected to the logger. Can be used to redirect logs to any other log */
extern const std::function<void(const std::string&)> G_TEST_LOG_FUN;
Expand Down Expand Up @@ -79,9 +83,17 @@ static inline bool InsecureRandBool() { return g_insecure_rand_ctx.randbool(); }

static constexpr CAmount CENT{1000000};

/* Initialize Dash-specific components after chainstate initialization */
void DashTestSetup(NodeContext& node, const CChainParams& chainparams);
void DashTestSetupClose(NodeContext& node);
/** Initialize Dash-specific components during chainstate initialization (NodeContext-friendly aliases) */
void DashChainstateSetup(ChainstateManager& chainman,
NodeContext& node,
bool fReset,
bool fReindexChainState,
const Consensus::Params& consensus_params);
void DashChainstateSetupClose(NodeContext& node);

/** Initialize Dash-specific components after chainstate initialization */
void DashPostChainstateSetup(NodeContext& node);
void DashPostChainstateSetupClose(NodeContext& node);

/** Basic testing setup.
* This just configures logging, data dir and chain parameters.
Expand All @@ -101,6 +113,8 @@ struct BasicTestingSetup {
* initialization behaviour.
*/
struct ChainTestingSetup : public BasicTestingSetup {
CacheSizes m_cache_sizes{};

explicit ChainTestingSetup(const std::string& chainName = CBaseChainParams::MAIN, const std::vector<const char*>& extra_args = {});
~ChainTestingSetup();
};
Expand Down
24 changes: 19 additions & 5 deletions src/test/validation_chainstatemanager_tests.cpp
View file
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,9 @@
#include <index/txindex.h>
#include <llmq/blockprocessor.h>
#include <llmq/chainlocks.h>
#include <llmq/context.h>
#include <llmq/instantsend.h>
#include <node/chainstate.h>
#include <node/utxo_snapshot.h>
#include <random.h>
#include <rpc/blockchain.h>
Expand All @@ -33,7 +35,7 @@ BOOST_FIXTURE_TEST_SUITE(validation_chainstatemanager_tests, ChainTestingSetup)
//! First create a legacy (IBD) chainstate, then create a snapshot chainstate.
BOOST_AUTO_TEST_CASE(chainstatemanager)
{
const CChainParams& chainparams = Params();
const Consensus::Params& consensus_params = Params().GetConsensus();
ChainstateManager& manager = *m_node.chainman;
CTxMemPool& mempool = *m_node.mempool;
CEvoDB& evodb = *m_node.evodb;
Expand All @@ -49,7 +51,8 @@ BOOST_AUTO_TEST_CASE(chainstatemanager)
/* cache_size_bytes */ 1 << 23, /* in_memory */ true, /* should_wipe */ false);
WITH_LOCK(::cs_main, c1.InitCoinsCache(1 << 23));

DashTestSetup(m_node, chainparams);
DashChainstateSetup(manager, m_node, /*fReset=*/false, /*fReindexChainState=*/false, consensus_params);
DashPostChainstateSetup(m_node);

BOOST_CHECK(!manager.IsSnapshotActive());
BOOST_CHECK(WITH_LOCK(::cs_main, return !manager.IsSnapshotValidated()));
Expand All @@ -67,7 +70,12 @@ BOOST_AUTO_TEST_CASE(chainstatemanager)

BOOST_CHECK(!manager.SnapshotBlockhash().has_value());

DashTestSetupClose(m_node);
DashPostChainstateSetupClose(m_node);
if (m_node.llmq_ctx) {
m_node.llmq_ctx->Interrupt();
m_node.llmq_ctx->Stop();
}
DashChainstateSetupClose(m_node);

// Create a snapshot-based chainstate.
//
Expand All @@ -78,7 +86,8 @@ BOOST_AUTO_TEST_CASE(chainstatemanager)
);
chainstates.push_back(&c2);

DashTestSetup(m_node, chainparams);
DashChainstateSetup(manager, m_node, /*fReset=*/false, /*fReindexChainState=*/false, consensus_params);
DashPostChainstateSetup(m_node);

BOOST_CHECK_EQUAL(manager.SnapshotBlockhash().value(), snapshot_blockhash);

Expand Down Expand Up @@ -113,7 +122,12 @@ BOOST_AUTO_TEST_CASE(chainstatemanager)
// Let scheduler events finish running to avoid accessing memory that is going to be unloaded
SyncWithValidationInterfaceQueue();

DashTestSetupClose(m_node);
DashPostChainstateSetupClose(m_node);
if (m_node.llmq_ctx) {
m_node.llmq_ctx->Interrupt();
m_node.llmq_ctx->Stop();
}
DashChainstateSetupClose(m_node);
}

//! Test rebalancing the caches associated with each chainstate.
Expand Down

0 comments on commit 09ab629

Please sign in to comment.