Skip to content

Commit

Permalink
Merge bitcoin#21942: docs: improve make with parallel jobs description.
Browse files Browse the repository at this point in the history
07bc22e docs: improve make with parallel jobs description. (Klement Tan)

Pull request description:

  Changed `use -jX here for parallelism` to `use "-j N" for N parallel jobs`

  **Rationale**: In my opinion `use -jX here for parallelism` is quite ambiguous as it could be perceived as a single option without any argument. Ie running:
  ```sh
  make -jX
  ```

  Embarrassingly this caused me to be stuck for quite a long time until I opened the help menu for `make` but if I am the only one who faced this issue I would be happy to close this PR.

ACKs for top commit:
  jarolrod:
    ACK 07bc22e

Tree-SHA512: 2d119b6a461668906c63184b865d2cc9fb2f75abeba34e2e44bc1ef3bcb4adec4a49896ddaf3cc6a20c0095ad20d0de0908401b351eaca9443161d24d6b20d0b
  • Loading branch information
MarcoFalke authored and knst committed Aug 5, 2024
1 parent c2735a8 commit 0e2e315
Show file tree
Hide file tree
Showing 5 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion doc/build-freebsd.md
Original file line number Diff line number Diff line change
Expand Up @@ -131,6 +131,6 @@ This explicitly enables the GUI and disables legacy wallet support. If `qt5` is
**Important**: Use `gmake` (the non-GNU `make` will exit with an error).

```bash
gmake # use -jX here for parallelism
gmake # use "-j N" for N parallel jobs
gmake check # Run tests if Python 3 is available
```
2 changes: 1 addition & 1 deletion doc/build-netbsd.md
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,6 @@ Without wallet:

Build and run the tests:
```bash
gmake # use -jX here for parallelism
gmake # use "-j N" here for N parallel jobs
gmake check
```
2 changes: 1 addition & 1 deletion doc/build-openbsd.md
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ To configure with GUI:

Build and run the tests:
```bash
gmake # use -jX here for parallelism
gmake # use "-j N" here for N parallel jobs
gmake check
```

Expand Down
2 changes: 1 addition & 1 deletion doc/build-osx.md
Original file line number Diff line number Diff line change
Expand Up @@ -276,7 +276,7 @@ After configuration, you are ready to compile.
Run the following in your terminal to compile Dash Core:

``` bash
make -jx # use -jX here for parallelism
make # use "-j N" here for N parallel jobs
make check # Run tests if Python 3 is available
```

Expand Down
2 changes: 1 addition & 1 deletion doc/build-unix.md
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ To Build
```sh
./autogen.sh
./configure
make
make # use "-j N" for N parallel jobs
make install # optional
```

Expand Down

0 comments on commit 0e2e315

Please sign in to comment.