Governance bug fix (#998)

* Added more specific error message about attempts to submit superblocks by non-masternodes * Fixed governance object validation bug * Fixed logic bug in governance object submission
dashpay · Sep 9, 2016 · d81e729 · d81e729
1 parent 740d1e0
commit d81e729
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 4 deletions.
diff --git a/src/governance.cpp b/src/governance.cpp
@@ -956,7 +956,7 @@ bool CGovernanceObject::IsValidLocally(const CBlockIndex* pindex, std::string& s
     if(fCheckCollateral) {
         if(nObjectType == GOVERNANCE_OBJECT_TRIGGER) {
             CMasternode mn;
-            if(mnodeman.Get(pubkeyMasternode, mn)) {
+            if(!mnodeman.Get(pubkeyMasternode, mn)) {
                 strError = "Masternode not found";
                 return false;
             }

diff --git a/src/rpcgovernance.cpp b/src/rpcgovernance.cpp
@@ -186,9 +186,14 @@ UniValue gobject(const UniValue& params, bool fHelp)
              << endl; );
 
         // Attempt to sign triggers if we are a MN
-        if((govobj.GetObjectType() == GOVERNANCE_OBJECT_TRIGGER) && mnFound) {
-            govobj.SetMasternodeInfo(mn.vin, activeMasternode.pubKeyMasternode);
-            govobj.Sign(activeMasternode.keyMasternode);
+        if(govobj.GetObjectType() == GOVERNANCE_OBJECT_TRIGGER) {
+            if(mnFound) {
+                govobj.SetMasternodeInfo(mn.vin, activeMasternode.pubKeyMasternode);
+                govobj.Sign(activeMasternode.keyMasternode);
+            }
+            else {
+                throw JSONRPCError(RPC_INTERNAL_ERROR, "Only valid masternodes can submit this type of object");
+            }
         }
 
         std::string strError = "";