Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ipv6 masternode support #22

Closed
vertoe opened this issue Jul 8, 2014 · 2 comments
Closed

ipv6 masternode support #22

vertoe opened this issue Jul 8, 2014 · 2 comments

Comments

@vertoe
Copy link

vertoe commented Jul 8, 2014

Would it be possible to allow ipv6 masternodes?

As discussed here https://darkcointalk.org/threads/for-those-running-several-nodes-whats-your-approach-for-static-ip-addresses.1347/#post-11353
@schinzelh
Copy link

Theoretically the code should be IPv6 capable if Evan did not make assumptions on IPv4. Will give it a try on a IPv6 connected machine.

@thelazier
Copy link

Many Masternode on IPv6 are online and get payment currently, This issue should be no longer an issue.

CryptoCentric referenced this issue in absolute-community/absolute Feb 15, 2019
@CryptoCentric
Merge pull request #22 from absolute-community/v12.2.5PR13.3
27a9cd0 
V12.2.5 PR13.3
barrystyle referenced this issue in PACGlobalOfficial/PAC Jul 17, 2019
@cryptokrypton @alejandromgk
Adding a nice PAC logo as text and doing a fix after decompressing th…
ac74f28 
…e binaries (#22)

* pacmn.sh

* pacmn.sh

* pacmn.sh

* Update README.md

* pacmn.sh

* pacmn.sh

* Update README.md

* Removing extra step after tar xvf
cadexproject pushed a commit to cadexproject/cadex that referenced this issue Dec 4, 2019
@barrystyle
Merge pull request dashpay#22 from theRealDijida/patch-6
1fa89cc 
MasterNode setup script based
FornaxA referenced this issue in ioncoincore/ion Jul 6, 2020
Merged in ICC-41-update-hardcoded-seeds-with-new-onion (pull request #22
feb3143 
)

update hardcoded seeds
PastaPastaPasta referenced this issue in PastaPastaPasta/dash Aug 9, 2020
Merge bitcoin-core/gui#30: Disable the main window toolbar when the m…
d52bfc4 
…odal overlay is shown

d0cc1f6 qt: Disable toolbar when overlay is shown (Hennadii Stepanov)
e74cd20 qt, refactor: Cleanup ModalOverlay slots (Hennadii Stepanov)

Pull request description:

  Keeping the main window toolbar activated while the modal overlay is shown could create the appearance of the non-responsive GUI.

  Fixes #22.

  ---

  On master (ca05588):

  ![Screenshot from 2020-07-11 13-07-00](https://user-images.githubusercontent.com/32963518/87221791-7504e100-c377-11ea-9689-ddd4b21b98f9.png)

  With this PR:

  ![Screenshot from 2020-07-11 13-07-39](https://user-images.githubusercontent.com/32963518/87221803-8817b100-c377-11ea-92c8-3602dc4d2451.png)

ACKs for top commit:
  harding:
    Tested ACK d0cc1f6.  Tested on Linux/X11 as much as I could given it's a pretty small change; seems like a nice improvement.  I'm not experienced in Qt, but I don't see anything obviously problematic about the code.
  jonatack:
    ACK d0cc1f6 tested on Debian 5.7.6-1 (2020-06-24) x86_64 GNU/Linux
  LarryRuane:
    ACK d0cc1f6 tested on Ubuntu 18.04.4 LTS

Tree-SHA512: e371b34231c01e77118deb100e0f280ba1cdef54e317f7f7d6ac322598bda811bd1bfe3035e90d87f8267f4f5d2095d34a8136911159db63694fd1b1b11335a1
celbalrai pushed a commit to bytzcurrency/BYTZ that referenced this issue Jul 15, 2021
@createawesome @celbalrai
update traditional colors (dashpay#22)
73978f0 
primary and secondary update
bytzck pushed a commit to bytzck/BYTZ that referenced this issue Jul 20, 2021
@createawesome @celbalrai
update traditional colors (dashpay#22)
d89d16c 
primary and secondary update
UdjinM6 pushed a commit that referenced this issue Oct 21, 2021
@PastaPastaPasta
Merge bitcoin#21773: fuzz: Ensure prevout is consensus-valid
6d06ff0 
fa1fdeb fuzz: Ensure prevout is consensus-valid (MarcoFalke)

Pull request description:

  It shouldn't be possible to create consensus-invalid prevouts, so there is no need to fuzz them.

  To reproduce:

  ```
  $ echo 'AAAAAAEAAAAAAQF0Rw0SGsrit4+YZSEfpcQT/o+bJbjgVjATUHqrCfRE+QsBAAAXFgAUlsvXHgGV
  ZxF3QXxitwe1tIOYdLj2NePHATl9CgAAAAAAGXapFOFHg1yqRFl7soeowwpIEOoe9G1NiKwCRzBE
  AiAx6F2Q008gvJnok6JiyOn7lPqCJJmDiI2omRNXT1Q7XAIgCQP6WJizAqhnvImpQqYMJkqePGvx
  Jy/pGRMy1iNL0ecDIQJr4tWomVTBfjpyMFMOD9aDAR5gkByOIYiaQOv8P/sRztP3pS8RDAAAEUUE
  NQBwYAAAAAC5F6kUTLIzj/lKP2Hmpwyzukns2eweRkOH' | base64 --decode  > /tmp/a

  $ FUZZ=script_flags ./src/test/fuzz/fuzz /tmp/a
  INFO: Running with entropic power schedule (0xFF, 100).
  INFO: Seed: 59714236
  INFO: Loaded 1 modules   (212532 inline 8-bit counters): 212532 [0x55987fb3f668, 0x55987fb7349c),
  INFO: Loaded 1 PC tables (212532 PCs): 212532 [0x55987fb734a0,0x55987feb17e0),
  ./src/test/fuzz/fuzz: Running 1 inputs 1 time(s) each.
  Running: /tmp/a
  fuzz: script/interpreter.cpp:1495: bool HandleMissingData(MissingDataBehavior): Assertion `!"Missing data"' failed.
  ==520092== ERROR: libFuzzer: deadly signal
      #0 0x55987f111180 in __sanitizer_print_stack_trace (/root/fuzz_dir/scratch/fuzz_gen/code/src/test/fuzz/fuzz+0x5ea180)
      #1 0x55987f0ba828 in fuzzer::PrintStackTrace() fuzzer.o
      #2 0x55987f09de43 in fuzzer::Fuzzer::CrashCallback() fuzzer.o
      #3 0x7fd003d563bf  (/lib/x86_64-linux-gnu/libpthread.so.0+0x153bf)
      #4 0x7fd00399a18a in raise (/lib/x86_64-linux-gnu/libc.so.6+0x4618a)
      #5 0x7fd003979858 in abort (/lib/x86_64-linux-gnu/libc.so.6+0x25858)
      #6 0x7fd003979728  (/lib/x86_64-linux-gnu/libc.so.6+0x25728)
      #7 0x7fd00398af35 in __assert_fail (/lib/x86_64-linux-gnu/libc.so.6+0x36f35)
      #8 0x55987f8ce194 in HandleMissingData(MissingDataBehavior) /root/fuzz_dir/scratch/fuzz_gen/code/src/script/interpreter.cpp:1495:9
      #9 0x55987f8ce194 in GenericTransactionSignatureChecker<CTransaction>::CheckECDSASignature(std::vector<unsigned char, std::allocator<unsigned char> > const&, std::vector<unsigned char, std::allocator<unsigned char> > const&, CScript const&, SigVersion) const /root/fuzz_dir/scratch/fuzz_gen/code/src/script/interpreter.cpp:1685:68
      #10 0x55987f8cbbc8 in EvalChecksigPreTapscript(std::vector<unsigned char, std::allocator<unsigned char> > const&, std::vector<unsigned char, std::allocator<unsigned char> > const&, prevector<28u, unsigned char, unsigned int, int>::const_iterator, prevector<28u, unsigned char, unsigned int, int>::const_iterator, unsigned int, BaseSignatureChecker const&, SigVersion, ScriptError_t*, bool&) /root/fuzz_dir/scratch/fuzz_gen/code/src/script/interpreter.cpp:363:24
      #11 0x55987f8cbbc8 in EvalChecksig(std::vector<unsigned char, std::allocator<unsigned char> > const&, std::vector<unsigned char, std::allocator<unsigned char> > const&, prevector<28u, unsigned char, unsigned int, int>::const_iterator, prevector<28u, unsigned char, unsigned int, int>::const_iterator, ScriptExecutionData&, unsigned int, BaseSignatureChecker const&, SigVersion, ScriptError_t*, bool&) /root/fuzz_dir/scratch/fuzz_gen/code/src/script/interpreter.cpp:421:16
      #12 0x55987f8c5a01 in EvalScript(std::vector<std::vector<unsigned char, std::allocator<unsigned char> >, std::allocator<std::vector<unsigned char, std::allocator<unsigned char> > > >&, CScript const&, unsigned int, BaseSignatureChecker const&, SigVersion, ScriptExecutionData&, ScriptError_t*) /root/fuzz_dir/scratch/fuzz_gen/code/src/script/interpreter.cpp:1094:26
      #13 0x55987f8d6d6e in ExecuteWitnessScript(Span<std::vector<unsigned char, std::allocator<unsigned char> > const> const&, CScript const&, unsigned int, SigVersion, BaseSignatureChecker const&, ScriptExecutionData&, ScriptError_t*) /root/fuzz_dir/scratch/fuzz_gen/code/src/script/interpreter.cpp:1843:10
      #14 0x55987f8d48fc in VerifyWitnessProgram(CScriptWitness const&, int, std::vector<unsigned char, std::allocator<unsigned char> > const&, unsigned int, BaseSignatureChecker const&, ScriptError_t*, bool) /root/fuzz_dir/scratch/fuzz_gen/code/src/script/interpreter.cpp:1904:20
      #15 0x55987f8d3d8b in VerifyScript(CScript const&, CScript const&, CScriptWitness const*, unsigned int, BaseSignatureChecker const&, ScriptError_t*) /root/fuzz_dir/scratch/fuzz_gen/code/src/script/interpreter.cpp:2045:22
      #16 0x55987f201d47 in script_flags_fuzz_target(Span<unsigned char const>) /root/fuzz_dir/scratch/fuzz_gen/code/src/test/fuzz/script_flags.cpp:54:30
      #17 0x55987f11447f in std::_Function_handler<void (Span<unsigned char const>), void (*)(Span<unsigned char const>)>::_M_invoke(std::_Any_data const&, Span<unsigned char const>&&) /usr/bin/../lib/gcc/x86_64-linux-gnu/9/../../../../include/c++/9/bits/std_function.h:300:2
      #18 0x55987f8aed17 in std::function<void (Span<unsigned char const>)>::operator()(Span<unsigned char const>) const /usr/bin/../lib/gcc/x86_64-linux-gnu/9/../../../../include/c++/9/bits/std_function.h:688:14
      #19 0x55987f8aed17 in LLVMFuzzerTestOneInput /root/fuzz_dir/scratch/fuzz_gen/code/src/test/fuzz/fuzz.cpp:63:5
      #20 0x55987f09f5e3 in fuzzer::Fuzzer::ExecuteCallback(unsigned char const*, unsigned long) fuzzer.o
      #21 0x55987f0894e2 in fuzzer::RunOneTest(fuzzer::Fuzzer*, char const*, unsigned long) fuzzer.o
      #22 0x55987f08f2da in fuzzer::FuzzerDriver(int*, char***, int (*)(unsigned char const*, unsigned long)) fuzzer.o
      #23 0x55987f0bb002 in main (/root/fuzz_dir/scratch/fuzz_gen/code/src/test/fuzz/fuzz+0x594002)
      #24 0x7fd00397b0b2 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x270b2)
      #25 0x55987f06420d in _start (/root/fuzz_dir/scratch/fuzz_gen/code/src/test/fuzz/fuzz+0x53d20d)

  NOTE: libFuzzer has rudimentary signal handlers.
        Combine libFuzzer with AddressSanitizer or similar for better crash reports.
  SUMMARY: libFuzzer: deadly signal

ACKs for top commit:
  practicalswift:
    Tested ACK fa1fdeb

Tree-SHA512: 6130ed9ab6d8eeab901f64a1c069300e67d0b6009c42763262fe6edeab8192e088c1a3c1f61aee900b9ebbc48fbf6e837b41704bad592ec526398355766e208a
pravblockc pushed a commit to pravblockc/dash that referenced this issue Nov 18, 2021
@pravblockc
Merge bitcoin#21773: fuzz: Ensure prevout is consensus-valid
a76973b 
fa1fdeb fuzz: Ensure prevout is consensus-valid (MarcoFalke)

Pull request description:

  It shouldn't be possible to create consensus-invalid prevouts, so there is no need to fuzz them.

  To reproduce:

  ```
  $ echo 'AAAAAAEAAAAAAQF0Rw0SGsrit4+YZSEfpcQT/o+bJbjgVjATUHqrCfRE+QsBAAAXFgAUlsvXHgGV
  ZxF3QXxitwe1tIOYdLj2NePHATl9CgAAAAAAGXapFOFHg1yqRFl7soeowwpIEOoe9G1NiKwCRzBE
  AiAx6F2Q008gvJnok6JiyOn7lPqCJJmDiI2omRNXT1Q7XAIgCQP6WJizAqhnvImpQqYMJkqePGvx
  Jy/pGRMy1iNL0ecDIQJr4tWomVTBfjpyMFMOD9aDAR5gkByOIYiaQOv8P/sRztP3pS8RDAAAEUUE
  NQBwYAAAAAC5F6kUTLIzj/lKP2Hmpwyzukns2eweRkOH' | base64 --decode  > /tmp/a

  $ FUZZ=script_flags ./src/test/fuzz/fuzz /tmp/a
  INFO: Running with entropic power schedule (0xFF, 100).
  INFO: Seed: 59714236
  INFO: Loaded 1 modules   (212532 inline 8-bit counters): 212532 [0x55987fb3f668, 0x55987fb7349c),
  INFO: Loaded 1 PC tables (212532 PCs): 212532 [0x55987fb734a0,0x55987feb17e0),
  ./src/test/fuzz/fuzz: Running 1 inputs 1 time(s) each.
  Running: /tmp/a
  fuzz: script/interpreter.cpp:1495: bool HandleMissingData(MissingDataBehavior): Assertion `!"Missing data"' failed.
  ==520092== ERROR: libFuzzer: deadly signal
      #0 0x55987f111180 in __sanitizer_print_stack_trace (/root/fuzz_dir/scratch/fuzz_gen/code/src/test/fuzz/fuzz+0x5ea180)
      dashpay#1 0x55987f0ba828 in fuzzer::PrintStackTrace() fuzzer.o
      dashpay#2 0x55987f09de43 in fuzzer::Fuzzer::CrashCallback() fuzzer.o
      dashpay#3 0x7fd003d563bf  (/lib/x86_64-linux-gnu/libpthread.so.0+0x153bf)
      dashpay#4 0x7fd00399a18a in raise (/lib/x86_64-linux-gnu/libc.so.6+0x4618a)
      dashpay#5 0x7fd003979858 in abort (/lib/x86_64-linux-gnu/libc.so.6+0x25858)
      dashpay#6 0x7fd003979728  (/lib/x86_64-linux-gnu/libc.so.6+0x25728)
      dashpay#7 0x7fd00398af35 in __assert_fail (/lib/x86_64-linux-gnu/libc.so.6+0x36f35)
      dashpay#8 0x55987f8ce194 in HandleMissingData(MissingDataBehavior) /root/fuzz_dir/scratch/fuzz_gen/code/src/script/interpreter.cpp:1495:9
      dashpay#9 0x55987f8ce194 in GenericTransactionSignatureChecker<CTransaction>::CheckECDSASignature(std::vector<unsigned char, std::allocator<unsigned char> > const&, std::vector<unsigned char, std::allocator<unsigned char> > const&, CScript const&, SigVersion) const /root/fuzz_dir/scratch/fuzz_gen/code/src/script/interpreter.cpp:1685:68
      dashpay#10 0x55987f8cbbc8 in EvalChecksigPreTapscript(std::vector<unsigned char, std::allocator<unsigned char> > const&, std::vector<unsigned char, std::allocator<unsigned char> > const&, prevector<28u, unsigned char, unsigned int, int>::const_iterator, prevector<28u, unsigned char, unsigned int, int>::const_iterator, unsigned int, BaseSignatureChecker const&, SigVersion, ScriptError_t*, bool&) /root/fuzz_dir/scratch/fuzz_gen/code/src/script/interpreter.cpp:363:24
      dashpay#11 0x55987f8cbbc8 in EvalChecksig(std::vector<unsigned char, std::allocator<unsigned char> > const&, std::vector<unsigned char, std::allocator<unsigned char> > const&, prevector<28u, unsigned char, unsigned int, int>::const_iterator, prevector<28u, unsigned char, unsigned int, int>::const_iterator, ScriptExecutionData&, unsigned int, BaseSignatureChecker const&, SigVersion, ScriptError_t*, bool&) /root/fuzz_dir/scratch/fuzz_gen/code/src/script/interpreter.cpp:421:16
      dashpay#12 0x55987f8c5a01 in EvalScript(std::vector<std::vector<unsigned char, std::allocator<unsigned char> >, std::allocator<std::vector<unsigned char, std::allocator<unsigned char> > > >&, CScript const&, unsigned int, BaseSignatureChecker const&, SigVersion, ScriptExecutionData&, ScriptError_t*) /root/fuzz_dir/scratch/fuzz_gen/code/src/script/interpreter.cpp:1094:26
      dashpay#13 0x55987f8d6d6e in ExecuteWitnessScript(Span<std::vector<unsigned char, std::allocator<unsigned char> > const> const&, CScript const&, unsigned int, SigVersion, BaseSignatureChecker const&, ScriptExecutionData&, ScriptError_t*) /root/fuzz_dir/scratch/fuzz_gen/code/src/script/interpreter.cpp:1843:10
      dashpay#14 0x55987f8d48fc in VerifyWitnessProgram(CScriptWitness const&, int, std::vector<unsigned char, std::allocator<unsigned char> > const&, unsigned int, BaseSignatureChecker const&, ScriptError_t*, bool) /root/fuzz_dir/scratch/fuzz_gen/code/src/script/interpreter.cpp:1904:20
      dashpay#15 0x55987f8d3d8b in VerifyScript(CScript const&, CScript const&, CScriptWitness const*, unsigned int, BaseSignatureChecker const&, ScriptError_t*) /root/fuzz_dir/scratch/fuzz_gen/code/src/script/interpreter.cpp:2045:22
      dashpay#16 0x55987f201d47 in script_flags_fuzz_target(Span<unsigned char const>) /root/fuzz_dir/scratch/fuzz_gen/code/src/test/fuzz/script_flags.cpp:54:30
      dashpay#17 0x55987f11447f in std::_Function_handler<void (Span<unsigned char const>), void (*)(Span<unsigned char const>)>::_M_invoke(std::_Any_data const&, Span<unsigned char const>&&) /usr/bin/../lib/gcc/x86_64-linux-gnu/9/../../../../include/c++/9/bits/std_function.h:300:2
      dashpay#18 0x55987f8aed17 in std::function<void (Span<unsigned char const>)>::operator()(Span<unsigned char const>) const /usr/bin/../lib/gcc/x86_64-linux-gnu/9/../../../../include/c++/9/bits/std_function.h:688:14
      dashpay#19 0x55987f8aed17 in LLVMFuzzerTestOneInput /root/fuzz_dir/scratch/fuzz_gen/code/src/test/fuzz/fuzz.cpp:63:5
      dashpay#20 0x55987f09f5e3 in fuzzer::Fuzzer::ExecuteCallback(unsigned char const*, unsigned long) fuzzer.o
      dashpay#21 0x55987f0894e2 in fuzzer::RunOneTest(fuzzer::Fuzzer*, char const*, unsigned long) fuzzer.o
      dashpay#22 0x55987f08f2da in fuzzer::FuzzerDriver(int*, char***, int (*)(unsigned char const*, unsigned long)) fuzzer.o
      dashpay#23 0x55987f0bb002 in main (/root/fuzz_dir/scratch/fuzz_gen/code/src/test/fuzz/fuzz+0x594002)
      dashpay#24 0x7fd00397b0b2 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x270b2)
      dashpay#25 0x55987f06420d in _start (/root/fuzz_dir/scratch/fuzz_gen/code/src/test/fuzz/fuzz+0x53d20d)

  NOTE: libFuzzer has rudimentary signal handlers.
        Combine libFuzzer with AddressSanitizer or similar for better crash reports.
  SUMMARY: libFuzzer: deadly signal

ACKs for top commit:
  practicalswift:
    Tested ACK fa1fdeb

Tree-SHA512: 6130ed9ab6d8eeab901f64a1c069300e67d0b6009c42763262fe6edeab8192e088c1a3c1f61aee900b9ebbc48fbf6e837b41704bad592ec526398355766e208a
ckti pushed a commit to ckti-dash-current/dash that referenced this issue Apr 8, 2022
@createawesome @ckti
update traditional colors (dashpay#22)
b8f1aaa 
primary and secondary update
ckti pushed a commit to ckti-dash-current/dash that referenced this issue Apr 8, 2022
@createawesome @ckti
update traditional colors (dashpay#22)
9ee1bce 
primary and secondary update
ckti pushed a commit to ckti-dash-current/dash that referenced this issue Apr 8, 2022
@createawesome @ckti
update traditional colors (dashpay#22)
37f624c 
primary and secondary update
ckti pushed a commit to ckti-dash-current/dash that referenced this issue Apr 10, 2022
@createawesome @ckti
update traditional colors (dashpay#22)
df5a055 
primary and secondary update
ckti pushed a commit to ckti-dash-current/dash that referenced this issue Apr 10, 2022
@createawesome @ckti
update traditional colors (dashpay#22)
9c48562 
primary and secondary update
ckti pushed a commit to ckti-dash-current/dash that referenced this issue Apr 10, 2022
@createawesome @ckti
update traditional colors (dashpay#22)
15c0eb7 
primary and secondary update
ckti pushed a commit to ckti-dash-current/dash that referenced this issue Apr 10, 2022
@createawesome @ckti
update traditional colors (dashpay#22)
70693bc 
primary and secondary update
ckti pushed a commit to ckti-dash-current/dash that referenced this issue Apr 10, 2022
@createawesome @ckti
update traditional colors (dashpay#22)
e3a503a 
primary and secondary update
ckti pushed a commit to ckti-dash-current/dash that referenced this issue Apr 10, 2022
@createawesome @ckti
update traditional colors (dashpay#22)
20ba6dc 
primary and secondary update
ckti pushed a commit to ckti-dash-current/dash that referenced this issue Apr 10, 2022
@createawesome @ckti
update traditional colors (dashpay#22)
7c18928 
primary and secondary update
ckti pushed a commit to ckti-dash-current/dash that referenced this issue Apr 10, 2022
@createawesome @ckti
update traditional colors (dashpay#22)
5d2d339 
primary and secondary update
ckti pushed a commit to ckti-dash-current/dash that referenced this issue Apr 10, 2022
@createawesome @ckti
update traditional colors (dashpay#22)
d509004 
primary and secondary update
ckti pushed a commit to ckti-dash-current/dash that referenced this issue Apr 10, 2022
@createawesome @ckti
update traditional colors (dashpay#22)
02994e2 
primary and secondary update
ckti pushed a commit to ckti-dash-current/dash that referenced this issue Apr 10, 2022
@createawesome @ckti
update traditional colors (dashpay#22)
b852057 
primary and secondary update
ckti pushed a commit to ckti-dash-current/dash that referenced this issue Apr 10, 2022
@createawesome @ckti
update traditional colors (dashpay#22)
6fd25bf 
primary and secondary update
ckti pushed a commit to ckti-dash-current/dash that referenced this issue Apr 10, 2022
@createawesome @ckti
update traditional colors (dashpay#22)
67c6275 
primary and secondary update
ckti pushed a commit to ckti-dash-current/dash that referenced this issue Apr 10, 2022
@createawesome @ckti
update traditional colors (dashpay#22)
4efbbba 
primary and secondary update
wagerr-builder pushed a commit to wagerr-builder/wagerr that referenced this issue Jun 17, 2022
@createawesome @wagerr-builder
update traditional colors (dashpay#22)
df7e083 
primary and secondary update
wagerr-builder referenced this issue in wagerr-from-watto/wagerr-older Oct 21, 2022
@createawesome @wagerr-builder
update traditional colors (watto-engineer#22)
89e0a70 
primary and secondary update
wagerr-builder pushed a commit to wagerr-builder/wagerr that referenced this issue Oct 21, 2022
@createawesome @wagerr-builder
update traditional colors (dashpay#22)
cee0eaf 
primary and secondary update
wagerr-builder pushed a commit to wagerr-builder/wagerr that referenced this issue Oct 21, 2022
@createawesome @wagerr-builder
update traditional colors (dashpay#22)
e0a6661 
primary and secondary update
wagerr-builder pushed a commit to wagerr-builder/wagerr that referenced this issue Nov 3, 2022
@celbalrai @wagerr-builder
gitignore - vscode
c1a454d 
Initial core Wagerr parameters and algorithms

- Load genesis block
- Set consensus parameters
- Block reward values
- PoW difficulty algorithm

Load POS blocks

- Add POS flags to CBlockIndex
- Set coinbase maturity to 10 for blocks with height < 10
- Skip time checks before Midas activation
- Add validation and signature functions
- Adapt block format

POS changes that introduce the need for additional checks

- Skip nValue check for transactions on regular coinstakes
 - Make sure coinstakes are properly checked

Update POS

Update Zerocoin

Adapt patches to Dash 0.17 code base

Update PoS rules to Wagerr

Disable accumulator check

Enable communication with legacy nodes

Legacy nodes only send blocks, not headers:
- Directly respond to block inv's with getdata requests
- Respond to out-of-order blocks with requests for connecting blocks

Also:
- Disable checking for deterministic (on-chain) MNs before they are enabled.

Adapt sync process to Wagerr specific parameters

create a shared library to make creating wallets easier. (dashpay#1130)

* create a shared library whose API presents the complicated or time consuming functions needed for creating and sending transactions

Tests for shared library

Refactor Script interpreter as a "virtual machine" encapsulated by a class.

Refactor script interpreter into a virtual machine, add access via cashlib and python, and more precise script error reporting.

Add FindScriptPubKey() to search the UTXO set

Blockchain/RPC: Add scantxoutset method to scan UTXO set

scantxoutset: add support for scripts

scantxoutset: support legacy P2PK script type

scantxoutset: mention that scanning by address will miss P2PK txouts

Add scantxoutset test

scantxoutset: remove witness related code

Tokens - Andrew Stone's implementation

Set ATP parameters

Adapt tokengroup implementation to Wagerr style transaction references

Destination encoders/decoders for tokens

Based on:
BitcoinUnlimited/BitcoinUnlimited#873

Adapt address encoder/decoder to Wagerr

Token implementation - ATP specific part

Update chain parameters: add nCoinbaseMaturity

Various fixes and updates

Update zerocoin - adapt to Wagerr

Generate POS blocks

- Generate POS blocks using RPC call 'generate'
- Allow generation of mixed POS/POW blocks
- Deterministic mn list skips the coinbase AND coinstake
- Set Staking parameters 'staking', 'wagerrstake', 'reservebalance'
- Schedule staking thread that attempts a stake every 1 second
  - Currently this thread is empty
- Opening a wallet for mixing now also opens the wallet for staking
- Add stakable coins as an option for selecting AvailableCoins

TODO:
- Time regular stake block generation ('staking=1' functionality)
- Take coinstake split parameter from config options (currently fixed and set to 2000 WAGERR)
- Split difficulty algo for POS and POW in hybrid POS/POW

Separate wallet from non-wallet in token functionality

    This restores the configure option --disable-wallet

    - Split rpctokens and rpctokenwallet
    - Split token script functionality
    - Move XDM fee management functions to wallet section
    - Reduce unnecessary include files

Re-add getextendedbalance RPC call

Based on commit 209f82f

- Add functions to calculate locked and unlocked balances
- Add RPC call getextendedbalance

Add scantokens RPC command

Scantokens works similarly to scantxoutset.
It returns the set of UTXO's that hold the specified tokens.

Update staking

- Disable staking on regtest
- Temporarily disable budget payments
- Subtract MN payment from staking outputs
- Add stake amount to output of CreateTxOuts()
- Initialize variables in stakemanager
- Add MintableCoins()
- Fill staking thread
- Log staking related output with 'staking' debug tag

- Correct AvailableCoins parameters

Parameter interaction for -disablewallet and -staking

Make stake split threshold variable

Through RPC call setstakesplitthreshold

Add getstakingstatus RPC command

Update token transaction creation input handling

- Eliminate amountAvailable from ConstructTx
- Rename totalBchNeeded to totalWagerrNeeded

Set PoW reward in hybrid phase

Separate block rewards for POW and POS blocks

Separate token structure classes from token consensus functionality

Improve token transaction fee calculation

Update fee policy in line with current fee policy

Update masternode collateral amount

Fix rebase issues: use shared_ptr for wallets

Correct coinstake generation and relay after DIP0003 activation

- Move POS parameter initialization to accommodate for compact blocks
- Add block signature to compact blocks
- Add coinstake to prefilled transactions in compact blocks
- Add coinstake to block payee validation checks
- Fix error handling after failed block signature validation
- Fix error handling after failed stake generation attempt
- No staking when the wallet is locked

Tweak staking thread timing

Rename XELEC to WELEC

Remove UniValue from tokengroup configuration status

Allowing tokens to be moved to the consensus code

Add zerocoin value to a coin's returned input value amount

Improve staking overhead and finish getstakingstatus

- Move Stake() to stakeManager
- No staking before masternode sync finished
- Port and adapt PivX' coinstake search time based staking status reporting
- Introduce sleep periods in the staking loop when staking is not available or effective
- RPC call getstakingstatus returns true when all staking conditions are met

Add coinstake flag to Coin and Coins

Add stake mint and masternode reward tx types to Qt transaction overview

Update/add maturity checks for coinstake and group configuration transactions

Finish adding setstakesplitthreshold

Port AutoCombineRewards

Finalize (pooled) mining support

- Include token rewards for miners in getblocktemplate
- Generate blocks with version 11 until start of the hybrid phase
- Enable X11 hashing for POW blocks during hybrid phase
- [FIX] Set minimum difficulty for first hybrid POW block
- Partial hybrid mining support
- Add CReward and CBlockReward classes to manage complex fee and reward structures
- Add block type version bit field that denotes POS or POW during Hybrid phase
- Streamline block generation
- [FIX] Only update block time for non-POS blocks when mining
- [FIX] Remove staking check from SelectCoins()
- [FIX] Check coinstake input values when validating new blocks

Replace softfork deployments with block height based fork settings

Do not skip token group fee validation when skipping script checks

Add createrawtokentransaction RPC call

Add listunspenttokens RPC call

Update token help output

- Update gettokenbalance to show that an address parameter is accepted
- Update sendtoken to show that multiple recipients and amounts can be specified

Add spork for bumping MIN_PEER_VERSION

Update default max size for relay of standard transactions

Block height based POS/POW markers

Ensure correct use of Params()

Skip checking for duplicate inputs when adding zerocoin txs to the wallet

As all zerocoin transactions have inputs with tx hash 0x0, all zerocoin transactions
were marked as 'conflicted' due to having the same inputs as other transactions.

Avoid stalling and slow legacy nodes during IBD

Remove unused softfork output

Update listtokentransactions

- Enable listtokentransactions to return output on all tokens instead of on specific tokens only
- Distinguish between token amounts and token authorities

listtokentransactions needed a token group ID string as input. This
commit makes that optional.
Now, when passing "*" or when omitting the token group ID string,
transactions from all token groups are returned.

Harmonize use of token labels in RPC calls

In line with https://github.com/ioncoincore/ion/pull/187 increase consistency:
- Refer to Wagerr with amount and to tokens with tokenAmount
- use tokenType to specify if an output is a value or an authority
- Use tokenAuthorities, not token_authorities
- use groupID instead of groupIdentifier

In line with Dash:
- use value and tokenValue for values with decimals
- use valueSat and tokenValueSat for their sat values (instead of using amount and tokenAmount for sat values)

More consistency:
- Add authorities to scantokens
- Use token { ticker, value, ..} instead of token { tokenTicker, tokenValue, ..}
- Use tokenAuthorities in favor of groupAuthorities

Check if pprev exists when calculating block versions

Fix incorrect unique pointer handling in stake initialization

Update genesis time in functional tests

Correct coinstake maturity handling

Add IsGenerated() and apply maturity checks from IsCoinBase() to IsCoinStake()/IsGenerated()

Enable verification of token database

When verification fails, the user either needs to start
with -reindex-tokens manually, or let the wallet reindex itself.
Around the upgrade to 5.0, a full reindex is a sane default.

- Rename -reindextokens to -reindex-tokens
- Move ReindexTokenDB after setting chainActive
- Add VerifyTokenDB
- Add block hash of token creation to db
- Do not buffer tokens when reindexing

Use correct hash field for token configuration

Limiting token database verification when blocks have been pruned

The token database is verified by finding the creation transaction
in the stored block, and then recreating the token creation transaction.
In pruned mode, the block might not be available anymore, so we
limit verification to testing if the block is in the block index if its
data hase been pruned.

Enable scantokens to scan for subgroups

Update stake handling when creating MN list

Exclude MN collateral from staking inputs

Disallow authorities in coinbase and coinstake transactions

Remove commented out code

Update autocombinerewards

- Randomize autocombine interval
- Combine coins from only 1 address per iteration
- Only combine when at least 10 inputs can be used

Improve timing of autocombinerewards manager

Proper XDM tx accounting

Limit memory usage of mapZerocoinSupply

The current code retains functionality to validate past zerocoin transactions.
The ported code uses too much memory to store trivial zerocoin related data.

Supply items in the map are now only stored:
- When zerocoin spends were possible
- When the supply denomination <> 0

Correctly set parameter parsing for listtokentransactions and listtokenssinceblock

Add minimum confirmations option to token balance functions

Take zerocoin (deprecated) and unspendable coins into account in coin supply

Update getstakingstatus reporting

Bypass scheduler process queue

Update Wagerr params - minimum chain work

Update Wagerr params - set version numbers

Update chain parameters

Update chain parameters (for regtest)

Configure regtest minging and staking

Update PoS and sync validation, including parameters and reward structure

Remove hardened spork 6

Update sync settings

Avoid pre-fork stalling during sync

Disable accumulator loading

Staking: set fixed accumulator checkpoint on new blocks

CoinJoin: disable

Wallet staking maturity - update coin availability

Introduce block time protocol V2 (15 second windows)

- Port and adapt PIVX commits on time protocol V2 (PR dashpay#1002)
- Port PIVX commits on nTime offset warnings (PR dashpay#1138)
- Adjust chain parameters
- Add several copyright notices

Proper coinstake handling in wallet

- Make coinstake inputs available after disconnect
- Correctly display immature coinstake balance

Update test framework

- Set correct spork key, genesis time, data folders and MN collateral
- Update MN registration: replace dip0003 softwork with spork

Time protocol v2: skip minimum block time on regtest

Update chain parameters (V16 heights)

Update chain params

Update chain parameters for regtest

Update chain parameters for testnet

Update Wagerr reward structure

- Update post-fork block reward schedule
- Store reward flags in CbTx to help verify and identify rewards across outputs
- Fix PoW reward distribution after DIP0003 activation
- Add Operator rewards to CBlockReward

Disable check for correct peer time on regtest

Update mininode for functional tests - set Wagerr params

Manage token group description storage on disconnecting blocks

Remove XDM

Remove from:
- Token creation
- Fee validation
- Supply tracking

Update preconfigured management tokens

Add flag to make a group's melt capability sticky

Tokens from a group with the sticky_melt flag set do not need a token melt authority for melting.

- Only management tokens can currently have the sticky_melt bit set
- Tokeninfo now reports flags
- Removed optionality on management token configuration parameters
- Melt transactions that melt its full balance for a specified group include a 1 sat OP_RETURN output because a tx needs to have at least one output

Move staking manager and reward manager initialization to wallet init section

Add CTokenGroupID constructor that takes a group and a subgroup string as params

Require a single MN credit token as proregtx fee

tokenGroupManager - Update pointer getters and loop

Use more generalized functions for ProRegTx

Move token group creation description from OP_RETURN to its own SpecialTx

Add 'functional' include for std::function

Prepare for separating CTokenGroupDescription in separate token types

Use separate SpecialTX for management tokens

- Create base description from which specific token group types are derived
- Include BLS public key in management tokens
- Exclude BLS public key from group hash
- Exclude nDecimalPos from base group description to prepare for NFTs

Update token configuration help text

- Move decimal position parameter
- Add BLS key for management tokens

Remove unneeded nHeight from ManagementTokensCreated()

Tokenized ProUpRevTx

Add in missing includes to get gitian-build to complete

Add include for boost::interruption_point

Rename to Wagerr

Wagerrlib disabled by default

Update regtest staking parameters

Enable getblocktemplate during POS in regtest only

Update gitian build to most recent version

* Update gitian build to most recent version

* Remove installation of cmake

Rebrand - additional renaming

Update to build qt under gcc 10 and above, get cmake from github

LLMQ updates

Replace softfork settings for dip20 activation with v17 activation hard fork param

- Set testnet fork block

Add files via upload (dashpay#17)

icon update

updated images (dashpay#18)

splash and toolbar logos

Update dark.css (dashpay#20)

27507a to c2064a

0e85dc to ff005b

primary and secondary color changes (dashpay#21)

swith to wagerr primary and secondary ff005b and c2064a

update traditional colors (dashpay#22)

primary and secondary update

Token description: allow numbers and spaces

- At least 2 characters
- No space at beginning or end

Add token document hashing, signing and verification

Change default font to Montserrat

Update token document RPC commands

- Add help texts
- Change boolean parameter parsing

Update token document class

Update configuremanagementtoken help text

Update splash screen rendering

Update ports

Button icon color updates

update main dark BG

updated background for dark theme

Update functional tests (dashpay#29)

update of functional test scripts

* Update functional tests

* More updated scripts

Update rewards manager

- Fix database functions for stake split threshold and auto combine dust functions
- Rename autocombinerewards to autocombinedust
- Remove change output from autocombinedust
- Cleanup scheduling and initialization

test/util checks for make check now working (dashpay#31)

Refactor token description types

Instead of using inheritance and pointer type casting, use boost::variant
and templates to handle different token types.

Tokenized ProUpRevTx

Never select inputs for staking that won't be accepted as outputs

Refactor parsing parameters for token configuration

Minor cleanup: Update token config dry run output

Add NFT functionality

- Make filters more flexible to allow for fine grained filter control
- Add NFT to checks
- Include NFT as token variant
- Initial NFT configuration parsing

Update params - set wait-for-islocked-timout to 4 minutes

Set chain parameters for CSV and BIP147

Update dkg test framework param

Update tests and enabled tests

Update NFT system

- Only 1 mint output
- Mint output must match the mint_amount specified with configurenft
- Renamed token document functions to:
  - encodetokenmetadata
  - decodetokenmetadata
  - signtokenmetadata
  - validatetokenmetadata
- Switched from camelCase to snake_case
- Updated token help texts
- Allow dash inside token names (not at start or end)
- Add binary blob to NFT
- Simplify token metadata parsing and validating

Update tests to run with new token parameters (dashpay#32)

Bump NFT token data size to 96k

Refactor tokeninfo and add displaying NFT data file

feat: add tor entrypoint script for use in dashmate (dashpay#4182)

* feat: add entrypoint for tor features in dashmate

* fix: use spaces consistently for indendation

* fix: output blank line after info

* fix: ensure script is executable

* fix: keep linter happy

Update make check tests

Prevent selection of immature token authorities

And update log message when using immature token authorities

Update unit tests - account for new script error codes

Introducing:
- SCRIPT_ERR_NUMBER_BAD_ENCODING
- NUMBER_OVERFLOW

Update unit tests - account for introduction of fCoinBase flag to Coin class

Change client version to Wagerr 5.0.0.0

Update mainnet data - set chain size and year of first block

Revert base58_tests, add in script_tests.cpp (dashpay#35)

Update tests with OP_GROUP, NUMBER_OVERFLOW and NUMBER_BAD_ENCODING

Update maturity check for token authorities

Make tests with tokens functional again

Change from V16 to V17 add include to rewards.cpp

Update copyright messages

Update chain parameters and fork height

Reject zerocoin transactions before tx checks

Initial setup for CircleCI (dashpay#36)

Remove coinjoin related RPC commands

Update man pages

Update mainnet keys

Update pixmaps

Fix for qt tests (dashpay#37)

Create initial snapcraft configurations (dashpay#38)

* Create initial snapcraft configurations

* Change version to 5.0.0

Add in blue logo (dashpay#39)

Update style sheets and logos

- Update light.css
- Update dark.css
- toolbar icon logo updates (dashpay#40)
- logo update
- updated splash with BG (dashpay#41)
- update light toobar to match (dashpay#42)
- Edit request bar (dashpay#43)

Update style

- Only Dark theme
- Selected and hovered inputs get a border
- Update splash rendering

Update fork parameters

Update man pages

Updating name

Change data folder from .wagerr to .wagerrcoin

Set release flag

Update links

Update README.md

Ignore sporks from previous versions

Update clock offset warning

New snapcraft

New circleci configuration

Update test_runner to run tokens in main check and deterministic masternodes in extended check

Set snapcraft to build from master

Update unlock for staking interface

- Add menu item 'Settings/Unlock Wallet for Staking'
- getstakingstatus now respects 'unlocked for staking' status
- Help text on walletpassphrase refers to staking, not mixing
- A timeout of 0 seconds disables the timeout (instead of timing out immediately)

Fixup

Add in working mac config, add make check to bionic

Bump minimum version before enforcement

Update snapcraft config to build v5.0.0

Add in wagerr specific values

- spork.h add in spork 20
- hash.h add in quark hash
- version.h rewind to version 70929

New(er) graphics

Update depends, GUIX for builds, drop i686 support

- Depends updates needed to build using guix matching up with current bitcoin version 0.22.0 with the exception of boost which needs to remain at version 1.70
- Use GUIX to build deterministically as gitian-builder is now deprecated
- Update build documentation for deterministic builds
- Drop support for i686 Windows
- Change Makefile.am for Mac building as native_cdrkit is no longer used
- Use new XCode Mac SDK -> 12.1-12A7403
- Update macdeploy README for instructions on downloading new SDK
- Change QT building to work with new version of QT 12.11.0

Circleci Updated to use cimg rather than circleci images

Change wagerr addresses for spork and token management

Add qminimal checks back in configure

Update make check tests

-Governance proposals json add correct mainnet address update key tests
-Update rpc_tests
-Update make check python tests
-Switch to quark for hashing
-Remove checkblock

Set all collateral to 25000

Update test framework

CSS Styles

-Update CSS Styles
-Update images

Update tests to work with wagerr

Unpatched bdb

Changes to get devnet working

Update Icons for snap builds, add bison for builds, update bdb patch

Update circleci

-run test_wagerr, test_wagerr-qt, and wagerr_bench at the end of x86_64 bionic
-rpcnestedtests.cpp change node results to fit quark chain

Guix and Gitian build both working

-Add cmake to darwin packages
-Add in relative path to darwin.mk
-Remove no-sdk config option
-Reset tool eval
-Reset tonew eval
-Add ifeq to clang
-Remove path from native build
-Remove separate tool definitions
-Force ar and ranlib in gitian osx yml file
-Remove ranlib and ar from configure.ac
-Remove full path from cctools
-Remove ranlib and ar from bls-dash and cctools
-Add static ranlib and ar to bls-dash
-Add path to depends build include existing path
-Add path to depends build without export
-Reinstall AR and RANLIB
-Changeup of clang and clang++ for native builds
-Change native tools to remove prefix

Update depends qt to version 5.9.8

-Add don't hardcode pwd patch
-Remove hardcoded wagerr g++ from build.sh

Update gui to show icons as well as text

-Change send window
-Change default to text under icon
-Add overview icon
-Add : in front of icon path
-Get overview from images
-Scale overview icon
-Reduce font size
-Remove underscores
-Remove coinjoin from options menu

Update chain parameters and settings for Wagerr mainnet - non-betting sync

Add Wagerr 4.0 betting code

Source: 4.0 commit 6bc216c12d4622a1b9e0ca3649a27dd22a9e1e5c

Add Wagerr specific parameters and adapt to Dash' conventions

Add chain variables for betting, adapt code to Dash' conventions

Add betting hooks to validation sections

Port validation in betting v2/v3 phase

Add and adapt betting RPC commands

Add listtransactionrecords

Various fixes
wagerr-builder pushed a commit to wagerr-builder/wagerr that referenced this issue Dec 14, 2022
@createawesome @wagerr-builder
update traditional colors (dashpay#22)
6b56488 
primary and secondary update
kwvg pushed a commit to kwvg/dash that referenced this issue Dec 21, 2022
@UdjinM6
Bump relic toolkit to 3a23142be0a5510a3aa93cd6c76fc59d3fc732a5 (dashp…
a767dba 
…ay#22)
watto-engineer referenced this issue in watto-engineer/dash Dec 30, 2022
@createawesome @watto-engineer
update traditional colors (#22)
a15e989 
primary and secondary update
watto-engineer referenced this issue in watto-engineer/dash Dec 30, 2022
@createawesome @watto-engineer
update traditional colors (#22)
f5227dd 
primary and secondary update
wagerr-builder pushed a commit to wagerr-builder/wagerr that referenced this issue Dec 30, 2022
@createawesome @wagerr-builder
update traditional colors (dashpay#22)
db145c2 
primary and secondary update
vijaydasmp pushed a commit to vijaydasmp/dash that referenced this issue Jul 14, 2023
@vijaydasmp
Merge bitcoin#21948: test: Fix off-by-one in mockscheduler test RPC
2d99819 
fa2e614 test: Fix off-by-one in mockscheduler test RPC (MarcoFalke)

Pull request description:

  Fixes:

  ```
  fuzz: scheduler.cpp:83: void CScheduler::MockForward(std::chrono::seconds): Assertion `delta_seconds.count() > 0 && delta_seconds < std::chrono::hours{1}' failed.
  ==1059066== ERROR: libFuzzer: deadly signal
      #0 0x558f75449c10 in __sanitizer_print_stack_trace (/root/fuzz_dir/scratch/fuzz_gen/code/src/test/fuzz/fuzz+0x5fec10)
      dashpay#1 0x558f753f32b8 in fuzzer::PrintStackTrace() fuzzer.o
      dashpay#2 0x558f753d68d3 in fuzzer::Fuzzer::CrashCallback() fuzzer.o
      dashpay#3 0x7f4a3cbbb3bf  (/lib/x86_64-linux-gnu/libpthread.so.0+0x153bf)
      dashpay#4 0x7f4a3c7ff18a in raise (/lib/x86_64-linux-gnu/libc.so.6+0x4618a)
      dashpay#5 0x7f4a3c7de858 in abort (/lib/x86_64-linux-gnu/libc.so.6+0x25858)
      dashpay#6 0x7f4a3c7de728  (/lib/x86_64-linux-gnu/libc.so.6+0x25728)
      dashpay#7 0x7f4a3c7eff35 in __assert_fail (/lib/x86_64-linux-gnu/libc.so.6+0x36f35)
      dashpay#8 0x558f7588a913 in CScheduler::MockForward(std::chrono::duration<long, std::ratio<1l, 1l> >) scheduler.cpp:83:5
      dashpay#9 0x558f75b0e5b1 in mockscheduler()::$_7::operator()(RPCHelpMan const&, JSONRPCRequest const&) const rpc/misc.cpp:435:30
      dashpay#10 0x558f75b0e5b1 in std::_Function_handler<UniValue (RPCHelpMan const&, JSONRPCRequest const&), mockscheduler()::$_7>::_M_invoke(std::_Any_data const&, RPCHelpMan const&, JSONRPCRequest const&) /usr/bin/../lib/gcc/x86_64-linux-gnu/9/../../../../include/c++/9/bits/std_function.h:285:9
      dashpay#11 0x558f7587a141 in std::function<UniValue (RPCHelpMan const&, JSONRPCRequest const&)>::operator()(RPCHelpMan const&, JSONRPCRequest const&) const /usr/bin/../lib/gcc/x86_64-linux-gnu/9/../../../../include/c++/9/bits/std_function.h:688:14
      dashpay#12 0x558f7587a141 in RPCHelpMan::HandleRequest(JSONRPCRequest const&) const rpc/util.cpp:565:26
      dashpay#13 0x558f756c0086 in CRPCCommand::CRPCCommand(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, RPCHelpMan (*)())::'lambda'(JSONRPCRequest const&, UniValue&, bool)::operator()(JSONRPCRequest const&, UniValue&, bool) const ./rpc/server.h:110:91
      dashpay#14 0x558f756c0086 in std::_Function_handler<bool (JSONRPCRequest const&, UniValue&, bool), CRPCCommand::CRPCCommand(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, RPCHelpMan (*)())::'lambda'(JSONRPCRequest const&, UniValue&, bool)>::_M_invoke(std::_Any_data const&, JSONRPCRequest const&, UniValue&, bool&&) /usr/bin/../lib/gcc/x86_64-linux-gnu/9/../../../../include/c++/9/bits/std_function.h:285:9
      dashpay#15 0x558f756b8592 in std::function<bool (JSONRPCRequest const&, UniValue&, bool)>::operator()(JSONRPCRequest const&, UniValue&, bool) const /usr/bin/../lib/gcc/x86_64-linux-gnu/9/../../../../include/c++/9/bits/std_function.h:688:14
      dashpay#16 0x558f756b8592 in ExecuteCommand(CRPCCommand const&, JSONRPCRequest const&, UniValue&, bool) rpc/server.cpp:480:20
      dashpay#17 0x558f756b8592 in ExecuteCommands(std::vector<CRPCCommand const*, std::allocator<CRPCCommand const*> > const&, JSONRPCRequest const&, UniValue&) rpc/server.cpp:444:13
      dashpay#18 0x558f756b8017 in CRPCTable::execute(JSONRPCRequest const&) const rpc/server.cpp:464:13
      dashpay#19 0x558f7552457a in (anonymous namespace)::RPCFuzzTestingSetup::CallRPC(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, std::vector<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::allocator<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > > > const&) test/fuzz/rpc.cpp:50:25
      dashpay#20 0x558f7552457a in rpc_fuzz_target(Span<unsigned char const>) test/fuzz/rpc.cpp:354:28
      dashpay#21 0x558f7544cf0f in std::_Function_handler<void (Span<unsigned char const>), void (*)(Span<unsigned char const>)>::_M_invoke(std::_Any_data const&, Span<unsigned char const>&&) /usr/bin/../lib/gcc/x86_64-linux-gnu/9/../../../../include/c++/9/bits/std_function.h:300:2
      dashpay#22 0x558f75c05197 in std::function<void (Span<unsigned char const>)>::operator()(Span<unsigned char const>) const /usr/bin/../lib/gcc/x86_64-linux-gnu/9/../../../../include/c++/9/bits/std_function.h:688:14
      dashpay#23 0x558f75c05197 in LLVMFuzzerTestOneInput test/fuzz/fuzz.cpp:74:5
      dashpay#24 0x558f753d8073 in fuzzer::Fuzzer::ExecuteCallback(unsigned char const*, unsigned long) fuzzer.o
      dashpay#25 0x558f753c1f72 in fuzzer::RunOneTest(fuzzer::Fuzzer*, char const*, unsigned long) fuzzer.o
      dashpay#26 0x558f753c7d6a in fuzzer::FuzzerDriver(int*, char***, int (*)(unsigned char const*, unsigned long)) fuzzer.o
      dashpay#27 0x558f753f3a92 in main (/root/fuzz_dir/scratch/fuzz_gen/code/src/test/fuzz/fuzz+0x5a8a92)
      dashpay#28 0x7f4a3c7e00b2 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x270b2)
      dashpay#29 0x558f7539cc9d in _start (/root/fuzz_dir/scratch/fuzz_gen/code/src/test/fuzz/fuzz+0x551c9d)

ACKs for top commit:
  practicalswift:
    cr ACK fa2e614

Tree-SHA512: cfa120265261f0ad019b46c426b915c1c007806b37aecb27016ce780a0ddea5e6fc9b09065fd40684b11183dcd3bf543558d7a655e604695021653540266baf7
vijaydasmp pushed a commit to vijaydasmp/dash that referenced this issue Jul 18, 2023
@vijaydasmp
Merge bitcoin#21948: test: Fix off-by-one in mockscheduler test RPC
b86db37 
fa2e614 test: Fix off-by-one in mockscheduler test RPC (MarcoFalke)

Pull request description:

  Fixes:

  ```
  fuzz: scheduler.cpp:83: void CScheduler::MockForward(std::chrono::seconds): Assertion `delta_seconds.count() > 0 && delta_seconds < std::chrono::hours{1}' failed.
  ==1059066== ERROR: libFuzzer: deadly signal
      #0 0x558f75449c10 in __sanitizer_print_stack_trace (/root/fuzz_dir/scratch/fuzz_gen/code/src/test/fuzz/fuzz+0x5fec10)
      dashpay#1 0x558f753f32b8 in fuzzer::PrintStackTrace() fuzzer.o
      dashpay#2 0x558f753d68d3 in fuzzer::Fuzzer::CrashCallback() fuzzer.o
      dashpay#3 0x7f4a3cbbb3bf  (/lib/x86_64-linux-gnu/libpthread.so.0+0x153bf)
      dashpay#4 0x7f4a3c7ff18a in raise (/lib/x86_64-linux-gnu/libc.so.6+0x4618a)
      dashpay#5 0x7f4a3c7de858 in abort (/lib/x86_64-linux-gnu/libc.so.6+0x25858)
      dashpay#6 0x7f4a3c7de728  (/lib/x86_64-linux-gnu/libc.so.6+0x25728)
      dashpay#7 0x7f4a3c7eff35 in __assert_fail (/lib/x86_64-linux-gnu/libc.so.6+0x36f35)
      dashpay#8 0x558f7588a913 in CScheduler::MockForward(std::chrono::duration<long, std::ratio<1l, 1l> >) scheduler.cpp:83:5
      dashpay#9 0x558f75b0e5b1 in mockscheduler()::$_7::operator()(RPCHelpMan const&, JSONRPCRequest const&) const rpc/misc.cpp:435:30
      dashpay#10 0x558f75b0e5b1 in std::_Function_handler<UniValue (RPCHelpMan const&, JSONRPCRequest const&), mockscheduler()::$_7>::_M_invoke(std::_Any_data const&, RPCHelpMan const&, JSONRPCRequest const&) /usr/bin/../lib/gcc/x86_64-linux-gnu/9/../../../../include/c++/9/bits/std_function.h:285:9
      dashpay#11 0x558f7587a141 in std::function<UniValue (RPCHelpMan const&, JSONRPCRequest const&)>::operator()(RPCHelpMan const&, JSONRPCRequest const&) const /usr/bin/../lib/gcc/x86_64-linux-gnu/9/../../../../include/c++/9/bits/std_function.h:688:14
      dashpay#12 0x558f7587a141 in RPCHelpMan::HandleRequest(JSONRPCRequest const&) const rpc/util.cpp:565:26
      dashpay#13 0x558f756c0086 in CRPCCommand::CRPCCommand(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, RPCHelpMan (*)())::'lambda'(JSONRPCRequest const&, UniValue&, bool)::operator()(JSONRPCRequest const&, UniValue&, bool) const ./rpc/server.h:110:91
      dashpay#14 0x558f756c0086 in std::_Function_handler<bool (JSONRPCRequest const&, UniValue&, bool), CRPCCommand::CRPCCommand(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, RPCHelpMan (*)())::'lambda'(JSONRPCRequest const&, UniValue&, bool)>::_M_invoke(std::_Any_data const&, JSONRPCRequest const&, UniValue&, bool&&) /usr/bin/../lib/gcc/x86_64-linux-gnu/9/../../../../include/c++/9/bits/std_function.h:285:9
      dashpay#15 0x558f756b8592 in std::function<bool (JSONRPCRequest const&, UniValue&, bool)>::operator()(JSONRPCRequest const&, UniValue&, bool) const /usr/bin/../lib/gcc/x86_64-linux-gnu/9/../../../../include/c++/9/bits/std_function.h:688:14
      dashpay#16 0x558f756b8592 in ExecuteCommand(CRPCCommand const&, JSONRPCRequest const&, UniValue&, bool) rpc/server.cpp:480:20
      dashpay#17 0x558f756b8592 in ExecuteCommands(std::vector<CRPCCommand const*, std::allocator<CRPCCommand const*> > const&, JSONRPCRequest const&, UniValue&) rpc/server.cpp:444:13
      dashpay#18 0x558f756b8017 in CRPCTable::execute(JSONRPCRequest const&) const rpc/server.cpp:464:13
      dashpay#19 0x558f7552457a in (anonymous namespace)::RPCFuzzTestingSetup::CallRPC(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, std::vector<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::allocator<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > > > const&) test/fuzz/rpc.cpp:50:25
      dashpay#20 0x558f7552457a in rpc_fuzz_target(Span<unsigned char const>) test/fuzz/rpc.cpp:354:28
      dashpay#21 0x558f7544cf0f in std::_Function_handler<void (Span<unsigned char const>), void (*)(Span<unsigned char const>)>::_M_invoke(std::_Any_data const&, Span<unsigned char const>&&) /usr/bin/../lib/gcc/x86_64-linux-gnu/9/../../../../include/c++/9/bits/std_function.h:300:2
      dashpay#22 0x558f75c05197 in std::function<void (Span<unsigned char const>)>::operator()(Span<unsigned char const>) const /usr/bin/../lib/gcc/x86_64-linux-gnu/9/../../../../include/c++/9/bits/std_function.h:688:14
      dashpay#23 0x558f75c05197 in LLVMFuzzerTestOneInput test/fuzz/fuzz.cpp:74:5
      dashpay#24 0x558f753d8073 in fuzzer::Fuzzer::ExecuteCallback(unsigned char const*, unsigned long) fuzzer.o
      dashpay#25 0x558f753c1f72 in fuzzer::RunOneTest(fuzzer::Fuzzer*, char const*, unsigned long) fuzzer.o
      dashpay#26 0x558f753c7d6a in fuzzer::FuzzerDriver(int*, char***, int (*)(unsigned char const*, unsigned long)) fuzzer.o
      dashpay#27 0x558f753f3a92 in main (/root/fuzz_dir/scratch/fuzz_gen/code/src/test/fuzz/fuzz+0x5a8a92)
      dashpay#28 0x7f4a3c7e00b2 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x270b2)
      dashpay#29 0x558f7539cc9d in _start (/root/fuzz_dir/scratch/fuzz_gen/code/src/test/fuzz/fuzz+0x551c9d)

ACKs for top commit:
  practicalswift:
    cr ACK fa2e614

Tree-SHA512: cfa120265261f0ad019b46c426b915c1c007806b37aecb27016ce780a0ddea5e6fc9b09065fd40684b11183dcd3bf543558d7a655e604695021653540266baf7
PastaPastaPasta pushed a commit to vijaydasmp/dash that referenced this issue Jul 25, 2023
@PastaPastaPasta
Merge bitcoin#21948: test: Fix off-by-one in mockscheduler test RPC
994ce01 
fa2e614 test: Fix off-by-one in mockscheduler test RPC (MarcoFalke)

Pull request description:

  Fixes:

  ```
  fuzz: scheduler.cpp:83: void CScheduler::MockForward(std::chrono::seconds): Assertion `delta_seconds.count() > 0 && delta_seconds < std::chrono::hours{1}' failed.
  ==1059066== ERROR: libFuzzer: deadly signal
      #0 0x558f75449c10 in __sanitizer_print_stack_trace (/root/fuzz_dir/scratch/fuzz_gen/code/src/test/fuzz/fuzz+0x5fec10)
      dashpay#1 0x558f753f32b8 in fuzzer::PrintStackTrace() fuzzer.o
      dashpay#2 0x558f753d68d3 in fuzzer::Fuzzer::CrashCallback() fuzzer.o
      dashpay#3 0x7f4a3cbbb3bf  (/lib/x86_64-linux-gnu/libpthread.so.0+0x153bf)
      dashpay#4 0x7f4a3c7ff18a in raise (/lib/x86_64-linux-gnu/libc.so.6+0x4618a)
      dashpay#5 0x7f4a3c7de858 in abort (/lib/x86_64-linux-gnu/libc.so.6+0x25858)
      dashpay#6 0x7f4a3c7de728  (/lib/x86_64-linux-gnu/libc.so.6+0x25728)
      dashpay#7 0x7f4a3c7eff35 in __assert_fail (/lib/x86_64-linux-gnu/libc.so.6+0x36f35)
      dashpay#8 0x558f7588a913 in CScheduler::MockForward(std::chrono::duration<long, std::ratio<1l, 1l> >) scheduler.cpp:83:5
      dashpay#9 0x558f75b0e5b1 in mockscheduler()::$_7::operator()(RPCHelpMan const&, JSONRPCRequest const&) const rpc/misc.cpp:435:30
      dashpay#10 0x558f75b0e5b1 in std::_Function_handler<UniValue (RPCHelpMan const&, JSONRPCRequest const&), mockscheduler()::$_7>::_M_invoke(std::_Any_data const&, RPCHelpMan const&, JSONRPCRequest const&) /usr/bin/../lib/gcc/x86_64-linux-gnu/9/../../../../include/c++/9/bits/std_function.h:285:9
      dashpay#11 0x558f7587a141 in std::function<UniValue (RPCHelpMan const&, JSONRPCRequest const&)>::operator()(RPCHelpMan const&, JSONRPCRequest const&) const /usr/bin/../lib/gcc/x86_64-linux-gnu/9/../../../../include/c++/9/bits/std_function.h:688:14
      dashpay#12 0x558f7587a141 in RPCHelpMan::HandleRequest(JSONRPCRequest const&) const rpc/util.cpp:565:26
      dashpay#13 0x558f756c0086 in CRPCCommand::CRPCCommand(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, RPCHelpMan (*)())::'lambda'(JSONRPCRequest const&, UniValue&, bool)::operator()(JSONRPCRequest const&, UniValue&, bool) const ./rpc/server.h:110:91
      dashpay#14 0x558f756c0086 in std::_Function_handler<bool (JSONRPCRequest const&, UniValue&, bool), CRPCCommand::CRPCCommand(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, RPCHelpMan (*)())::'lambda'(JSONRPCRequest const&, UniValue&, bool)>::_M_invoke(std::_Any_data const&, JSONRPCRequest const&, UniValue&, bool&&) /usr/bin/../lib/gcc/x86_64-linux-gnu/9/../../../../include/c++/9/bits/std_function.h:285:9
      dashpay#15 0x558f756b8592 in std::function<bool (JSONRPCRequest const&, UniValue&, bool)>::operator()(JSONRPCRequest const&, UniValue&, bool) const /usr/bin/../lib/gcc/x86_64-linux-gnu/9/../../../../include/c++/9/bits/std_function.h:688:14
      dashpay#16 0x558f756b8592 in ExecuteCommand(CRPCCommand const&, JSONRPCRequest const&, UniValue&, bool) rpc/server.cpp:480:20
      dashpay#17 0x558f756b8592 in ExecuteCommands(std::vector<CRPCCommand const*, std::allocator<CRPCCommand const*> > const&, JSONRPCRequest const&, UniValue&) rpc/server.cpp:444:13
      dashpay#18 0x558f756b8017 in CRPCTable::execute(JSONRPCRequest const&) const rpc/server.cpp:464:13
      dashpay#19 0x558f7552457a in (anonymous namespace)::RPCFuzzTestingSetup::CallRPC(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, std::vector<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::allocator<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > > > const&) test/fuzz/rpc.cpp:50:25
      dashpay#20 0x558f7552457a in rpc_fuzz_target(Span<unsigned char const>) test/fuzz/rpc.cpp:354:28
      dashpay#21 0x558f7544cf0f in std::_Function_handler<void (Span<unsigned char const>), void (*)(Span<unsigned char const>)>::_M_invoke(std::_Any_data const&, Span<unsigned char const>&&) /usr/bin/../lib/gcc/x86_64-linux-gnu/9/../../../../include/c++/9/bits/std_function.h:300:2
      dashpay#22 0x558f75c05197 in std::function<void (Span<unsigned char const>)>::operator()(Span<unsigned char const>) const /usr/bin/../lib/gcc/x86_64-linux-gnu/9/../../../../include/c++/9/bits/std_function.h:688:14
      dashpay#23 0x558f75c05197 in LLVMFuzzerTestOneInput test/fuzz/fuzz.cpp:74:5
      dashpay#24 0x558f753d8073 in fuzzer::Fuzzer::ExecuteCallback(unsigned char const*, unsigned long) fuzzer.o
      dashpay#25 0x558f753c1f72 in fuzzer::RunOneTest(fuzzer::Fuzzer*, char const*, unsigned long) fuzzer.o
      dashpay#26 0x558f753c7d6a in fuzzer::FuzzerDriver(int*, char***, int (*)(unsigned char const*, unsigned long)) fuzzer.o
      dashpay#27 0x558f753f3a92 in main (/root/fuzz_dir/scratch/fuzz_gen/code/src/test/fuzz/fuzz+0x5a8a92)
      dashpay#28 0x7f4a3c7e00b2 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x270b2)
      dashpay#29 0x558f7539cc9d in _start (/root/fuzz_dir/scratch/fuzz_gen/code/src/test/fuzz/fuzz+0x551c9d)

ACKs for top commit:
  practicalswift:
    cr ACK fa2e614

Tree-SHA512: cfa120265261f0ad019b46c426b915c1c007806b37aecb27016ce780a0ddea5e6fc9b09065fd40684b11183dcd3bf543558d7a655e604695021653540266baf7
knst pushed a commit to knst/dash that referenced this issue Jan 4, 2024
@knst
Merge bitcoin-core/gui#30: Disable the main window toolbar when the m…
5809164 
…odal overlay is shown

d0cc1f6 qt: Disable toolbar when overlay is shown (Hennadii Stepanov)
e74cd20 qt, refactor: Cleanup ModalOverlay slots (Hennadii Stepanov)

Pull request description:

  Keeping the main window toolbar activated while the modal overlay is shown could create the appearance of the non-responsive GUI.

  Fixes dashpay#22.

  ---

  On master (ca05588):

  ![Screenshot from 2020-07-11 13-07-00](https://user-images.githubusercontent.com/32963518/87221791-7504e100-c377-11ea-9689-ddd4b21b98f9.png)

  With this PR:

  ![Screenshot from 2020-07-11 13-07-39](https://user-images.githubusercontent.com/32963518/87221803-8817b100-c377-11ea-92c8-3602dc4d2451.png)

ACKs for top commit:
  harding:
    Tested ACK d0cc1f6.  Tested on Linux/X11 as much as I could given it's a pretty small change; seems like a nice improvement.  I'm not experienced in Qt, but I don't see anything obviously problematic about the code.
  jonatack:
    ACK d0cc1f6 tested on Debian 5.7.6-1 (2020-06-24) x86_64 GNU/Linux
  LarryRuane:
    ACK d0cc1f6 tested on Ubuntu 18.04.4 LTS

Tree-SHA512: e371b34231c01e77118deb100e0f280ba1cdef54e317f7f7d6ac322598bda811bd1bfe3035e90d87f8267f4f5d2095d34a8136911159db63694fd1b1b11335a1
knst pushed a commit to knst/dash that referenced this issue Jan 7, 2024
@knst
Merge bitcoin-core/gui#30: Disable the main window toolbar when the m…
9a2fef7 
…odal overlay is shown

d0cc1f6 qt: Disable toolbar when overlay is shown (Hennadii Stepanov)
e74cd20 qt, refactor: Cleanup ModalOverlay slots (Hennadii Stepanov)

Pull request description:

  Keeping the main window toolbar activated while the modal overlay is shown could create the appearance of the non-responsive GUI.

  Fixes dashpay#22.

  ---

  On master (ca05588):

  ![Screenshot from 2020-07-11 13-07-00](https://user-images.githubusercontent.com/32963518/87221791-7504e100-c377-11ea-9689-ddd4b21b98f9.png)

  With this PR:

  ![Screenshot from 2020-07-11 13-07-39](https://user-images.githubusercontent.com/32963518/87221803-8817b100-c377-11ea-92c8-3602dc4d2451.png)

ACKs for top commit:
  harding:
    Tested ACK d0cc1f6.  Tested on Linux/X11 as much as I could given it's a pretty small change; seems like a nice improvement.  I'm not experienced in Qt, but I don't see anything obviously problematic about the code.
  jonatack:
    ACK d0cc1f6 tested on Debian 5.7.6-1 (2020-06-24) x86_64 GNU/Linux
  LarryRuane:
    ACK d0cc1f6 tested on Ubuntu 18.04.4 LTS

Tree-SHA512: e371b34231c01e77118deb100e0f280ba1cdef54e317f7f7d6ac322598bda811bd1bfe3035e90d87f8267f4f5d2095d34a8136911159db63694fd1b1b11335a1
knst pushed a commit to knst/dash that referenced this issue Jan 10, 2024
@knst
Merge bitcoin-core/gui#30: Disable the main window toolbar when the m…
da21efa 
…odal overlay is shown

d0cc1f6 qt: Disable toolbar when overlay is shown (Hennadii Stepanov)
e74cd20 qt, refactor: Cleanup ModalOverlay slots (Hennadii Stepanov)

Pull request description:

  Keeping the main window toolbar activated while the modal overlay is shown could create the appearance of the non-responsive GUI.

  Fixes dashpay#22.

  ---

  On master (ca05588):

  ![Screenshot from 2020-07-11 13-07-00](https://user-images.githubusercontent.com/32963518/87221791-7504e100-c377-11ea-9689-ddd4b21b98f9.png)

  With this PR:

  ![Screenshot from 2020-07-11 13-07-39](https://user-images.githubusercontent.com/32963518/87221803-8817b100-c377-11ea-92c8-3602dc4d2451.png)

ACKs for top commit:
  harding:
    Tested ACK d0cc1f6.  Tested on Linux/X11 as much as I could given it's a pretty small change; seems like a nice improvement.  I'm not experienced in Qt, but I don't see anything obviously problematic about the code.
  jonatack:
    ACK d0cc1f6 tested on Debian 5.7.6-1 (2020-06-24) x86_64 GNU/Linux
  LarryRuane:
    ACK d0cc1f6 tested on Ubuntu 18.04.4 LTS

Tree-SHA512: e371b34231c01e77118deb100e0f280ba1cdef54e317f7f7d6ac322598bda811bd1bfe3035e90d87f8267f4f5d2095d34a8136911159db63694fd1b1b11335a1
knst pushed a commit to knst/dash that referenced this issue Jan 11, 2024
@knst
Merge bitcoin-core/gui#30: Disable the main window toolbar when the m…
d24f723 
…odal overlay is shown

d0cc1f6 qt: Disable toolbar when overlay is shown (Hennadii Stepanov)
e74cd20 qt, refactor: Cleanup ModalOverlay slots (Hennadii Stepanov)

Pull request description:

  Keeping the main window toolbar activated while the modal overlay is shown could create the appearance of the non-responsive GUI.

  Fixes dashpay#22.

  ---

  On master (ca05588):

  ![Screenshot from 2020-07-11 13-07-00](https://user-images.githubusercontent.com/32963518/87221791-7504e100-c377-11ea-9689-ddd4b21b98f9.png)

  With this PR:

  ![Screenshot from 2020-07-11 13-07-39](https://user-images.githubusercontent.com/32963518/87221803-8817b100-c377-11ea-92c8-3602dc4d2451.png)

ACKs for top commit:
  harding:
    Tested ACK d0cc1f6.  Tested on Linux/X11 as much as I could given it's a pretty small change; seems like a nice improvement.  I'm not experienced in Qt, but I don't see anything obviously problematic about the code.
  jonatack:
    ACK d0cc1f6 tested on Debian 5.7.6-1 (2020-06-24) x86_64 GNU/Linux
  LarryRuane:
    ACK d0cc1f6 tested on Ubuntu 18.04.4 LTS

Tree-SHA512: e371b34231c01e77118deb100e0f280ba1cdef54e317f7f7d6ac322598bda811bd1bfe3035e90d87f8267f4f5d2095d34a8136911159db63694fd1b1b11335a1
knst pushed a commit to knst/dash that referenced this issue Jan 12, 2024
@knst
Merge bitcoin-core/gui#30: Disable the main window toolbar when the m…
4a47728 
…odal overlay is shown

d0cc1f6 qt: Disable toolbar when overlay is shown (Hennadii Stepanov)
e74cd20 qt, refactor: Cleanup ModalOverlay slots (Hennadii Stepanov)

Pull request description:

  Keeping the main window toolbar activated while the modal overlay is shown could create the appearance of the non-responsive GUI.

  Fixes dashpay#22.

  ---

  On master (ca05588):

  ![Screenshot from 2020-07-11 13-07-00](https://user-images.githubusercontent.com/32963518/87221791-7504e100-c377-11ea-9689-ddd4b21b98f9.png)

  With this PR:

  ![Screenshot from 2020-07-11 13-07-39](https://user-images.githubusercontent.com/32963518/87221803-8817b100-c377-11ea-92c8-3602dc4d2451.png)

ACKs for top commit:
  harding:
    Tested ACK d0cc1f6.  Tested on Linux/X11 as much as I could given it's a pretty small change; seems like a nice improvement.  I'm not experienced in Qt, but I don't see anything obviously problematic about the code.
  jonatack:
    ACK d0cc1f6 tested on Debian 5.7.6-1 (2020-06-24) x86_64 GNU/Linux
  LarryRuane:
    ACK d0cc1f6 tested on Ubuntu 18.04.4 LTS

Tree-SHA512: e371b34231c01e77118deb100e0f280ba1cdef54e317f7f7d6ac322598bda811bd1bfe3035e90d87f8267f4f5d2095d34a8136911159db63694fd1b1b11335a1
knst pushed a commit to knst/dash that referenced this issue Jan 13, 2024
@knst
partial Merge bitcoin-core/gui#30: Disable the main window toolbar wh…
058bad2 
…en the modal overlay is shown

d0cc1f6 qt: Disable toolbar when overlay is shown (Hennadii Stepanov)
e74cd20 qt, refactor: Cleanup ModalOverlay slots (Hennadii Stepanov)

Pull request description:

  Keeping the main window toolbar activated while the modal overlay is shown could create the appearance of the non-responsive GUI.

  Fixes dashpay#22.

  ---

  On master (ca05588):

  ![Screenshot from 2020-07-11 13-07-00](https://user-images.githubusercontent.com/32963518/87221791-7504e100-c377-11ea-9689-ddd4b21b98f9.png)

  With this PR:

  ![Screenshot from 2020-07-11 13-07-39](https://user-images.githubusercontent.com/32963518/87221803-8817b100-c377-11ea-92c8-3602dc4d2451.png)

ACKs for top commit:
  harding:
    Tested ACK d0cc1f6.  Tested on Linux/X11 as much as I could given it's a pretty small change; seems like a nice improvement.  I'm not experienced in Qt, but I don't see anything obviously problematic about the code.
  jonatack:
    ACK d0cc1f6 tested on Debian 5.7.6-1 (2020-06-24) x86_64 GNU/Linux
  LarryRuane:
    ACK d0cc1f6 tested on Ubuntu 18.04.4 LTS

Tree-SHA512: e371b34231c01e77118deb100e0f280ba1cdef54e317f7f7d6ac322598bda811bd1bfe3035e90d87f8267f4f5d2095d34a8136911159db63694fd1b1b11335a1
knst pushed a commit to knst/dash that referenced this issue Jan 14, 2024
@knst
partial Merge bitcoin-core/gui#30: Disable the main window toolbar wh…
b4c1af9 
…en the modal overlay is shown

d0cc1f6 qt: Disable toolbar when overlay is shown (Hennadii Stepanov)
e74cd20 qt, refactor: Cleanup ModalOverlay slots (Hennadii Stepanov)

Pull request description:

  Keeping the main window toolbar activated while the modal overlay is shown could create the appearance of the non-responsive GUI.

  Fixes dashpay#22.

  ---

  On master (ca05588):

  ![Screenshot from 2020-07-11 13-07-00](https://user-images.githubusercontent.com/32963518/87221791-7504e100-c377-11ea-9689-ddd4b21b98f9.png)

  With this PR:

  ![Screenshot from 2020-07-11 13-07-39](https://user-images.githubusercontent.com/32963518/87221803-8817b100-c377-11ea-92c8-3602dc4d2451.png)

ACKs for top commit:
  harding:
    Tested ACK d0cc1f6.  Tested on Linux/X11 as much as I could given it's a pretty small change; seems like a nice improvement.  I'm not experienced in Qt, but I don't see anything obviously problematic about the code.
  jonatack:
    ACK d0cc1f6 tested on Debian 5.7.6-1 (2020-06-24) x86_64 GNU/Linux
  LarryRuane:
    ACK d0cc1f6 tested on Ubuntu 18.04.4 LTS

Tree-SHA512: e371b34231c01e77118deb100e0f280ba1cdef54e317f7f7d6ac322598bda811bd1bfe3035e90d87f8267f4f5d2095d34a8136911159db63694fd1b1b11335a1
knst pushed a commit to knst/dash that referenced this issue Jan 15, 2024
@knst
partial Merge bitcoin-core/gui#30: Disable the main window toolbar wh…
acc2ba1 
…en the modal overlay is shown

d0cc1f6 qt: Disable toolbar when overlay is shown (Hennadii Stepanov)
e74cd20 qt, refactor: Cleanup ModalOverlay slots (Hennadii Stepanov)

Pull request description:

  Keeping the main window toolbar activated while the modal overlay is shown could create the appearance of the non-responsive GUI.

  Fixes dashpay#22.

  ---

  On master (ca05588):

  ![Screenshot from 2020-07-11 13-07-00](https://user-images.githubusercontent.com/32963518/87221791-7504e100-c377-11ea-9689-ddd4b21b98f9.png)

  With this PR:

  ![Screenshot from 2020-07-11 13-07-39](https://user-images.githubusercontent.com/32963518/87221803-8817b100-c377-11ea-92c8-3602dc4d2451.png)

ACKs for top commit:
  harding:
    Tested ACK d0cc1f6.  Tested on Linux/X11 as much as I could given it's a pretty small change; seems like a nice improvement.  I'm not experienced in Qt, but I don't see anything obviously problematic about the code.
  jonatack:
    ACK d0cc1f6 tested on Debian 5.7.6-1 (2020-06-24) x86_64 GNU/Linux
  LarryRuane:
    ACK d0cc1f6 tested on Ubuntu 18.04.4 LTS

Tree-SHA512: e371b34231c01e77118deb100e0f280ba1cdef54e317f7f7d6ac322598bda811bd1bfe3035e90d87f8267f4f5d2095d34a8136911159db63694fd1b1b11335a1
knst pushed a commit to knst/dash that referenced this issue Jan 17, 2024
@knst
partial Merge bitcoin-core/gui#30: Disable the main window toolbar wh…
8777301 
…en the modal overlay is shown

BACKPORT COMMENT
Central widget is null at this point in our implementation. Also, we have no issues with the toolbar which original PR was aimed to fix.
Code is not presented in this commit is DNM, merged only changes in qt/modaloverlay (except b4c1af9#diff-bd2b12135c597b047fffc3b7a8e86e4a965c86ec7763f6ea885b6d8f6f702d10R40-R42 which is unused)

--------------------
d0cc1f6 qt: Disable toolbar when overlay is shown (Hennadii Stepanov)
e74cd20 qt, refactor: Cleanup ModalOverlay slots (Hennadii Stepanov)

Pull request description:

  Keeping the main window toolbar activated while the modal overlay is shown could create the appearance of the non-responsive GUI.

  Fixes dashpay#22.

  ---

  On master (ca05588):

  ![Screenshot from 2020-07-11 13-07-00](https://user-images.githubusercontent.com/32963518/87221791-7504e100-c377-11ea-9689-ddd4b21b98f9.png)

  With this PR:

  ![Screenshot from 2020-07-11 13-07-39](https://user-images.githubusercontent.com/32963518/87221803-8817b100-c377-11ea-92c8-3602dc4d2451.png)

ACKs for top commit:
  harding:
    Tested ACK d0cc1f6.  Tested on Linux/X11 as much as I could given it's a pretty small change; seems like a nice improvement.  I'm not experienced in Qt, but I don't see anything obviously problematic about the code.
  jonatack:
    ACK d0cc1f6 tested on Debian 5.7.6-1 (2020-06-24) x86_64 GNU/Linux
  LarryRuane:
    ACK d0cc1f6 tested on Ubuntu 18.04.4 LTS

Tree-SHA512: e371b34231c01e77118deb100e0f280ba1cdef54e317f7f7d6ac322598bda811bd1bfe3035e90d87f8267f4f5d2095d34a8136911159db63694fd1b1b11335a1
knst pushed a commit to knst/dash that referenced this issue Jan 17, 2024
@knst
partial Merge bitcoin-core/gui#30: Disable the main window toolbar wh…
e2fb04c 
…en the modal overlay is shown

d0cc1f6 qt: Disable toolbar when overlay is shown (Hennadii Stepanov)
e74cd20 qt, refactor: Cleanup ModalOverlay slots (Hennadii Stepanov)

Pull request description:

  Keeping the main window toolbar activated while the modal overlay is shown could create the appearance of the non-responsive GUI.

  Fixes dashpay#22.

  ---

  On master (ca05588):

  ![Screenshot from 2020-07-11 13-07-00](https://user-images.githubusercontent.com/32963518/87221791-7504e100-c377-11ea-9689-ddd4b21b98f9.png)

  With this PR:

  ![Screenshot from 2020-07-11 13-07-39](https://user-images.githubusercontent.com/32963518/87221803-8817b100-c377-11ea-92c8-3602dc4d2451.png)

ACKs for top commit:
  harding:
    Tested ACK d0cc1f6.  Tested on Linux/X11 as much as I could given it's a pretty small change; seems like a nice improvement.  I'm not experienced in Qt, but I don't see anything obviously problematic about the code.
  jonatack:
    ACK d0cc1f6 tested on Debian 5.7.6-1 (2020-06-24) x86_64 GNU/Linux
  LarryRuane:
    ACK d0cc1f6 tested on Ubuntu 18.04.4 LTS

Tree-SHA512: e371b34231c01e77118deb100e0f280ba1cdef54e317f7f7d6ac322598bda811bd1bfe3035e90d87f8267f4f5d2095d34a8136911159db63694fd1b1b11335a1
knst pushed a commit to knst/dash that referenced this issue Jan 17, 2024
@knst
partial Merge bitcoin-core/gui#30: Disable the main window toolbar wh…
cf37527 
…en the modal overlay is shown

BACKPORT COMMENT
Central widget is null at this point in our implementation. Also, we have no issues with the toolbar which original PR was aimed to fix.
Code is not presented in this commit is DNM, merged only changes in qt/modaloverlay (except b4c1af9#diff-bd2b12135c597b047fffc3b7a8e86e4a965c86ec7763f6ea885b6d8f6f702d10R40-R42 which is unused)

--------------------
d0cc1f6 qt: Disable toolbar when overlay is shown (Hennadii Stepanov)
e74cd20 qt, refactor: Cleanup ModalOverlay slots (Hennadii Stepanov)

Pull request description:

  Keeping the main window toolbar activated while the modal overlay is shown could create the appearance of the non-responsive GUI.

  Fixes dashpay#22.

  ---

  On master (ca05588):

  ![Screenshot from 2020-07-11 13-07-00](https://user-images.githubusercontent.com/32963518/87221791-7504e100-c377-11ea-9689-ddd4b21b98f9.png)

  With this PR:

  ![Screenshot from 2020-07-11 13-07-39](https://user-images.githubusercontent.com/32963518/87221803-8817b100-c377-11ea-92c8-3602dc4d2451.png)

ACKs for top commit:
  harding:
    Tested ACK d0cc1f6.  Tested on Linux/X11 as much as I could given it's a pretty small change; seems like a nice improvement.  I'm not experienced in Qt, but I don't see anything obviously problematic about the code.
  jonatack:
    ACK d0cc1f6 tested on Debian 5.7.6-1 (2020-06-24) x86_64 GNU/Linux
  LarryRuane:
    ACK d0cc1f6 tested on Ubuntu 18.04.4 LTS

Tree-SHA512: e371b34231c01e77118deb100e0f280ba1cdef54e317f7f7d6ac322598bda811bd1bfe3035e90d87f8267f4f5d2095d34a8136911159db63694fd1b1b11335a1
knst pushed a commit to knst/dash that referenced this issue Jan 19, 2024
@knst
partial Merge bitcoin-core/gui#30: Disable the main window toolbar wh…
4c7c3d6 
…en the modal overlay is shown

BACKPORT COMMENT
Central widget is null at this point in our implementation. Also, we have no issues with the toolbar which original PR was aimed to fix.
Code is not presented in this commit is DNM, merged only changes in qt/modaloverlay (except b4c1af9#diff-bd2b12135c597b047fffc3b7a8e86e4a965c86ec7763f6ea885b6d8f6f702d10R40-R42 which is unused)

--------------------
d0cc1f6 qt: Disable toolbar when overlay is shown (Hennadii Stepanov)
e74cd20 qt, refactor: Cleanup ModalOverlay slots (Hennadii Stepanov)

Pull request description:

  Keeping the main window toolbar activated while the modal overlay is shown could create the appearance of the non-responsive GUI.

  Fixes dashpay#22.

  ---

  On master (ca05588):

  ![Screenshot from 2020-07-11 13-07-00](https://user-images.githubusercontent.com/32963518/87221791-7504e100-c377-11ea-9689-ddd4b21b98f9.png)

  With this PR:

  ![Screenshot from 2020-07-11 13-07-39](https://user-images.githubusercontent.com/32963518/87221803-8817b100-c377-11ea-92c8-3602dc4d2451.png)

ACKs for top commit:
  harding:
    Tested ACK d0cc1f6.  Tested on Linux/X11 as much as I could given it's a pretty small change; seems like a nice improvement.  I'm not experienced in Qt, but I don't see anything obviously problematic about the code.
  jonatack:
    ACK d0cc1f6 tested on Debian 5.7.6-1 (2020-06-24) x86_64 GNU/Linux
  LarryRuane:
    ACK d0cc1f6 tested on Ubuntu 18.04.4 LTS

Tree-SHA512: e371b34231c01e77118deb100e0f280ba1cdef54e317f7f7d6ac322598bda811bd1bfe3035e90d87f8267f4f5d2095d34a8136911159db63694fd1b1b11335a1
knst pushed a commit to knst/dash that referenced this issue Jan 19, 2024
@knst
partial Merge bitcoin-core/gui#30: Disable the main window toolbar wh…
533c39a 
…en the modal overlay is shown

d0cc1f6 qt: Disable toolbar when overlay is shown (Hennadii Stepanov)
e74cd20 qt, refactor: Cleanup ModalOverlay slots (Hennadii Stepanov)

Pull request description:

  Keeping the main window toolbar activated while the modal overlay is shown could create the appearance of the non-responsive GUI.

  Fixes dashpay#22.

  ---

  On master (ca05588):

  ![Screenshot from 2020-07-11 13-07-00](https://user-images.githubusercontent.com/32963518/87221791-7504e100-c377-11ea-9689-ddd4b21b98f9.png)

  With this PR:

  ![Screenshot from 2020-07-11 13-07-39](https://user-images.githubusercontent.com/32963518/87221803-8817b100-c377-11ea-92c8-3602dc4d2451.png)

ACKs for top commit:
  harding:
    Tested ACK d0cc1f6.  Tested on Linux/X11 as much as I could given it's a pretty small change; seems like a nice improvement.  I'm not experienced in Qt, but I don't see anything obviously problematic about the code.
  jonatack:
    ACK d0cc1f6 tested on Debian 5.7.6-1 (2020-06-24) x86_64 GNU/Linux
  LarryRuane:
    ACK d0cc1f6 tested on Ubuntu 18.04.4 LTS

Tree-SHA512: e371b34231c01e77118deb100e0f280ba1cdef54e317f7f7d6ac322598bda811bd1bfe3035e90d87f8267f4f5d2095d34a8136911159db63694fd1b1b11335a1
knst pushed a commit to knst/dash that referenced this issue Jan 20, 2024
@knst
partial Merge bitcoin-core/gui#30: Disable the main window toolbar wh…
80f3c1f 
…en the modal overlay is shown

d0cc1f6 qt: Disable toolbar when overlay is shown (Hennadii Stepanov)
e74cd20 qt, refactor: Cleanup ModalOverlay slots (Hennadii Stepanov)

Pull request description:

  Keeping the main window toolbar activated while the modal overlay is shown could create the appearance of the non-responsive GUI.

  Fixes dashpay#22.

  ---

  On master (ca05588):

  ![Screenshot from 2020-07-11 13-07-00](https://user-images.githubusercontent.com/32963518/87221791-7504e100-c377-11ea-9689-ddd4b21b98f9.png)

  With this PR:

  ![Screenshot from 2020-07-11 13-07-39](https://user-images.githubusercontent.com/32963518/87221803-8817b100-c377-11ea-92c8-3602dc4d2451.png)

ACKs for top commit:
  harding:
    Tested ACK d0cc1f6.  Tested on Linux/X11 as much as I could given it's a pretty small change; seems like a nice improvement.  I'm not experienced in Qt, but I don't see anything obviously problematic about the code.
  jonatack:
    ACK d0cc1f6 tested on Debian 5.7.6-1 (2020-06-24) x86_64 GNU/Linux
  LarryRuane:
    ACK d0cc1f6 tested on Ubuntu 18.04.4 LTS

Tree-SHA512: e371b34231c01e77118deb100e0f280ba1cdef54e317f7f7d6ac322598bda811bd1bfe3035e90d87f8267f4f5d2095d34a8136911159db63694fd1b1b11335a1
knst pushed a commit to knst/dash that referenced this issue Jan 23, 2024
@knst
partial Merge bitcoin-core/gui#30: Disable the main window toolbar wh…
c075d63 
…en the modal overlay is shown

BACKPORT COMMENT
Central widget is null at this point in our implementation. Also, we have no issues with the toolbar which original PR was aimed to fix.
Code is not presented in this commit is DNM, merged only changes in qt/modaloverlay (except b4c1af9#diff-bd2b12135c597b047fffc3b7a8e86e4a965c86ec7763f6ea885b6d8f6f702d10R40-R42 which is unused)

--------------------
d0cc1f6 qt: Disable toolbar when overlay is shown (Hennadii Stepanov)
e74cd20 qt, refactor: Cleanup ModalOverlay slots (Hennadii Stepanov)

Pull request description:

  Keeping the main window toolbar activated while the modal overlay is shown could create the appearance of the non-responsive GUI.

  Fixes dashpay#22.

  ---

  On master (ca05588):

  ![Screenshot from 2020-07-11 13-07-00](https://user-images.githubusercontent.com/32963518/87221791-7504e100-c377-11ea-9689-ddd4b21b98f9.png)

  With this PR:

  ![Screenshot from 2020-07-11 13-07-39](https://user-images.githubusercontent.com/32963518/87221803-8817b100-c377-11ea-92c8-3602dc4d2451.png)

ACKs for top commit:
  harding:
    Tested ACK d0cc1f6.  Tested on Linux/X11 as much as I could given it's a pretty small change; seems like a nice improvement.  I'm not experienced in Qt, but I don't see anything obviously problematic about the code.
  jonatack:
    ACK d0cc1f6 tested on Debian 5.7.6-1 (2020-06-24) x86_64 GNU/Linux
  LarryRuane:
    ACK d0cc1f6 tested on Ubuntu 18.04.4 LTS

Tree-SHA512: e371b34231c01e77118deb100e0f280ba1cdef54e317f7f7d6ac322598bda811bd1bfe3035e90d87f8267f4f5d2095d34a8136911159db63694fd1b1b11335a1
PastaPastaPasta pushed a commit to knst/dash that referenced this issue Jan 24, 2024
@PastaPastaPasta
partial Merge bitcoin-core/gui#30: Disable the main window toolbar wh…
19ec839 
…en the modal overlay is shown

BACKPORT COMMENT
Central widget is null at this point in our implementation. Also, we have no issues with the toolbar which original PR was aimed to fix.
Code is not presented in this commit is DNM, merged only changes in qt/modaloverlay (except b4c1af9#diff-bd2b12135c597b047fffc3b7a8e86e4a965c86ec7763f6ea885b6d8f6f702d10R40-R42 which is unused)

--------------------
d0cc1f6 qt: Disable toolbar when overlay is shown (Hennadii Stepanov)
e74cd20 qt, refactor: Cleanup ModalOverlay slots (Hennadii Stepanov)

Pull request description:

  Keeping the main window toolbar activated while the modal overlay is shown could create the appearance of the non-responsive GUI.

  Fixes dashpay#22.

  ---

  On master (ca05588):

  ![Screenshot from 2020-07-11 13-07-00](https://user-images.githubusercontent.com/32963518/87221791-7504e100-c377-11ea-9689-ddd4b21b98f9.png)

  With this PR:

  ![Screenshot from 2020-07-11 13-07-39](https://user-images.githubusercontent.com/32963518/87221803-8817b100-c377-11ea-92c8-3602dc4d2451.png)

ACKs for top commit:
  harding:
    Tested ACK d0cc1f6.  Tested on Linux/X11 as much as I could given it's a pretty small change; seems like a nice improvement.  I'm not experienced in Qt, but I don't see anything obviously problematic about the code.
  jonatack:
    ACK d0cc1f6 tested on Debian 5.7.6-1 (2020-06-24) x86_64 GNU/Linux
  LarryRuane:
    ACK d0cc1f6 tested on Ubuntu 18.04.4 LTS

Tree-SHA512: e371b34231c01e77118deb100e0f280ba1cdef54e317f7f7d6ac322598bda811bd1bfe3035e90d87f8267f4f5d2095d34a8136911159db63694fd1b1b11335a1
PastaPastaPasta added a commit that referenced this issue May 24, 2024
@PastaPastaPasta
Merge #6032: backport: bitcoin#28769: build: Update qt package up t…
a6af7d5 
…o 5.15.11 - fix crash at Kubuntu 24.04

b85fc45 Merge bitcoin#28769: build: Update `qt` package up to 5.15.11 (fanquake)

Pull request description:

  ## Issue being fixed or feature implemented
  It fixes crash of qt app on Kubuntu 24.04

  ```
  *** buffer overflow detected ***: terminated

  #0  __pthread_kill_implementation (no_tid=0, signo=6, threadid=<optimized out>) at ./nptl/pthread_kill.c:44
  #1  __pthread_kill_internal (signo=6, threadid=<optimized out>) at ./nptl/pthread_kill.c:78
  #2  __GI___pthread_kill (threadid=<optimized out>, signo=signo@entry=6) at ./nptl/pthread_kill.c:89
  #3  0x00007ffff764526e in __GI_raise (sig=sig@entry=6) at ../sysdeps/posix/raise.c:26
  #4  0x00007ffff76288ff in __GI_abort () at ./stdlib/abort.c:79
  #5  0x00007ffff76297b6 in __libc_message_impl (fmt=fmt@entry=0x7ffff77ce765 "*** %s ***: terminated\n") at ../sysdeps/posix/libc_fatal.c:132
  #6  0x00007ffff7736c19 in __GI___fortify_fail (msg=msg@entry=0x7ffff77ce74c "buffer overflow detected") at ./debug/fortify_fail.c:24
  #7  0x00007ffff77365d4 in __GI___chk_fail () at ./debug/chk_fail.c:28
  #8  0x00007ffff7737a67 in __readlink_chk (path=<optimized out>, buf=<optimized out>, len=<optimized out>, buflen=<optimized out>) at ./debug/readlink_chk.c:31
  #9  0x0000555556988ab3 in qt_readlink(char const*) ()
  #10 0x0000555556a1f18b in QLockFilePrivate::processNameByPid(long long) ()
  #11 0x0000555556a1aa7b in QLockFilePrivate::lockFileContents() const ()
  #12 0x0000555556a1eccf in QLockFilePrivate::tryLock_sys() ()
  #13 0x0000555556a1bf01 in QLockFile::tryLock(int) ()
  #14 0x0000555556a1c094 in QLockFile::tryLock(int) ()
  #15 0x0000555556a1c094 in QLockFile::tryLock(int) ()
  #16 0x00005555568d8dd3 in QConfFileSettingsPrivate::syncConfFile(QConfFile*) ()
  #17 0x00005555568d9753 in QConfFileSettingsPrivate::sync() ()
  #18 0x00005555568c8ef5 in QSettings::~QSettings() ()
  #19 0x0000555555721f82 in Intro::showIfNeeded (did_show_intro=<optimized out>, prune_MiB=@0x7fffffffd2f0: 0) at qt/intro.cpp:275
  #20 0x00005555556ddab6 in GuiMain (argc=3, argv=0x7fffffffd828) at qt/bitcoin.cpp:629
  #21 0x00007ffff762a1ca in __libc_start_call_main (main=main@entry=0x5555556d7f00 <main(int, char**)>, argc=argc@entry=3, argv=argv@entry=0x7fffffffd828) at ../sysdeps/nptl/libc_start_call_main.h:58
  #22 0x00007ffff762a28b in __libc_start_main_impl (main=0x5555556d7f00 <main(int, char**)>, argc=3, argv=0x7fffffffd828, init=<optimized out>, fini=<optimized out>, rtld_fini=<optimized out>, stack_end=0x7fffffffd818) at ../csu/libc-start.c:360
  #23 0x00005555556d7e35 in _start ()
  ```

  Every usage of `QSettings` cause this crash on one of my PC, but not other. `-resetguisettings` doesn't help. gcc/clang - same crash. Removing data doesn't help.

  ## What was done?
  Bump QT to the newer version.
  See also related PR: #6011

  ## How Has This Been Tested?
  Build & Run

  ## Breaking Changes
  N/A

  ## Checklist:
  - [x] I have performed a self-review of my own code
  - [ ] I have commented my code, particularly in hard-to-understand areas
  - [ ] I have added or updated relevant unit/integration/functional/e2e tests
  - [ ] I have made corresponding changes to the documentation
  - [x] I have assigned this pull request to a milestone

Top commit has no ACKs.

Tree-SHA512: 3a9024a860c11aa7a48bfb36b3f29772feb6ff458ecbc0faffe774af08e6c7db5754048b0db2bf8713faf4cba861794b2855931416b8cd77389b31f1e47b8aad
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@schinzelh @vertoe @thelazier