OpenSSL 1.0.1k handling of DER signatures #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New versions of OpenSSL will reject non-canonical DER signatures. However, it'll happily decode them. Decode then re-encode before verification in order to ensure that it is properly consumed. Github-Pull: dashpay#5634 Rebased-From: 488ed32
Github-Pull: dashpay#5634 Rebased-From: 8dccba6
Not necessary for windows or linux, as the intermedate build result doesn't change. However for OSX on 0.9 the builds for the intermediates are not deterministic, so this cannot be assessed. Bump the dep version just in case.
Add some defensive programming on top of dashpay#5634. This copies the respective OpenSSL code in ECDSA_verify in OpenSSL pre-1.0.1k (e.g. https://github.com/openssl/openssl/blob/OpenSSL_1_0_1j/crypto/ecdsa/ecs_vrf.c#L89) more closely. As reported by @SergioDemianLerner. Github-Pull: dashpay#5640 Rebased-From: c6b7b29
vertoe
changed the title
|
heads up: this now includes upstream v0.9.4. i updated docs and release notes accordingly. will post some details in the testing thread. |
darkcoinproject
added a commit
that referenced
this pull request
Jan 12, 2015
OpenSSL 1.0.1k handling of DER signatures
|
Awesome, thanks |
FornaxA
pushed a commit
to ioncoincore/ion
that referenced
this pull request
Jul 6, 2020
…flag AcceptBlock() invalid isBlockFromFork flag
kwvg
pushed a commit
to kwvg/dash
that referenced
this pull request
Dec 21, 2022
kwvg
added a commit
to kwvg/dash
that referenced
this pull request
Dec 17, 2024
0bb5c5b032 Merge pull request dashpay#107 from kwvg/bump_1.3.5 3170e82074 Merge pull request dashpay#106 from UdjinM6/bench_chore 6091f5c056 chore: bump version to 1.3.5 90fd986fa5 chore: drop irrelevant PopSchemeMPL benchmark ba391e681e bench: use BasicSchemeMPL instead of AugSchemeMPL bcc6cf9cda bench: add benchmars for Serialize/SerializeToArray cc649f38ee feat: serialize on the stack (dashpay#75) git-subtree-dir: src/dashbls git-subtree-split: 0bb5c5b03249c463debb5cef5f7e52ee66f3aaab
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upstream discussion: