V0.11.1.x fix ds non i xdepth #151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eduffield222
pushed a commit
that referenced
this pull request
Feb 3, 2015
V0.11.1.x fix ds non i xdepth
FornaxA
pushed a commit
to ioncoincore/ion
that referenced
this pull request
Jul 6, 2020
…shpay#151) update snapcraft and dpkg build process ### GUI - [x] gui - update qt images, add new splash, replace banner (5456831) - [x] gui - qt, replace regtest and testnet icons with new (455518c) - [x] gui - update pixmaps from share folder (740dec0) #### New artworks - new QT icons   - new Daemon icons    - new splash screens for normal builds and snapcraft - new main splash   - new testnet splash   - new regtest splash   - new SVG sources for splash screens - add metadata and license info to new and some ionomy sources - **TODO** ***add license and author info to all available old resources, if info not available, replace it*** ### Build System - [x] build - snap, remove snap files from share folder (6e52766) - [x] build - snap, refactor snap (efa1af8) - [x] build - debian, update debian building (e392659) - [x] build - snap, remove desktop-qt5 as it is not available with core18 (a1b16b1) ### Docs - [x] docs - snap, create snap readme in doc folder (be5674d) - ### Protocol - [x] set min protocol version to current (1d5f0b0) ## squashed commits * gui - artworks, update SVG sources and cleanup - remove obsolete xcf images - rename ion-ionlogowhite.svg to ion_logo_white.svg - recreate new daemon icon vector graphics * gui - update qt images, add new splash, replace banner - replace ion_logo_horizontal.png - replace all splash screens - add new snapcraft splash screens * gui - qt, replace regtest and testnet icons with new * build - snap, remove snap files from share folder * build - snap, refactor snap - cleanup comments - restructure - add more info in log - added list variables at the end of the job - replace splash by snapcrafts splash - move priming data to snap/desktop - move priming patches to snap/patches (_is not required as all current patches are only applied during compilation_) * gui - update pixmaps from share folder - create new icons - create new pngs - use naming scheme ion_NETWORK - added *48.xpm - added testnet and regtest icons * docs - snap, create snap readme in doc folder * build - debian, update debian building - update control file, add missing build libs - create new icons - use naming scheme ion_NETWORK - update *.desktop files - minor fixes in *.desktop files - create daemon icons for main, testnet and regtest - update installation configs * set min protocol version to current * build - snap, remove desktop-qt5 as it is not available with core18 * travis - add snapcraft.yaml to lint-whitespace whitelist, remove build-dpkd.sh * network - update hardcoded seeds
cryptolinux
pushed a commit
to cryptolinux/ion
that referenced
this pull request
Feb 6, 2021
…shpay#151) update snapcraft and dpkg build process ### GUI - [x] gui - update qt images, add new splash, replace banner (5456831) - [x] gui - qt, replace regtest and testnet icons with new (455518c) - [x] gui - update pixmaps from share folder (740dec0) #### New artworks - new QT icons   - new Daemon icons    - new splash screens for normal builds and snapcraft - new main splash   - new testnet splash   - new regtest splash   - new SVG sources for splash screens - add metadata and license info to new and some ionomy sources - **TODO** ***add license and author info to all available old resources, if info not available, replace it*** ### Build System - [x] build - snap, remove snap files from share folder (6e52766) - [x] build - snap, refactor snap (efa1af8) - [x] build - debian, update debian building (e392659) - [x] build - snap, remove desktop-qt5 as it is not available with core18 (a1b16b1) ### Docs - [x] docs - snap, create snap readme in doc folder (be5674d) - ### Protocol - [x] set min protocol version to current (1d5f0b0) ## squashed commits * gui - artworks, update SVG sources and cleanup - remove obsolete xcf images - rename ion-ionlogowhite.svg to ion_logo_white.svg - recreate new daemon icon vector graphics * gui - update qt images, add new splash, replace banner - replace ion_logo_horizontal.png - replace all splash screens - add new snapcraft splash screens * gui - qt, replace regtest and testnet icons with new * build - snap, remove snap files from share folder * build - snap, refactor snap - cleanup comments - restructure - add more info in log - added list variables at the end of the job - replace splash by snapcrafts splash - move priming data to snap/desktop - move priming patches to snap/patches (_is not required as all current patches are only applied during compilation_) * gui - update pixmaps from share folder - create new icons - create new pngs - use naming scheme ion_NETWORK - added *48.xpm - added testnet and regtest icons * docs - snap, create snap readme in doc folder * build - debian, update debian building - update control file, add missing build libs - create new icons - use naming scheme ion_NETWORK - update *.desktop files - minor fixes in *.desktop files - create daemon icons for main, testnet and regtest - update installation configs * set min protocol version to current * build - snap, remove desktop-qt5 as it is not available with core18 * travis - add snapcraft.yaml to lint-whitespace whitelist, remove build-dpkd.sh * network - update hardcoded seeds
ckti
pushed a commit
to ckti-gitian-ion/ion
that referenced
this pull request
Mar 29, 2021
…shpay#151) update snapcraft and dpkg build process - [x] gui - update qt images, add new splash, replace banner (5456831) - [x] gui - qt, replace regtest and testnet icons with new (455518c) - [x] gui - update pixmaps from share folder (740dec0) - new QT icons   - new Daemon icons    - new splash screens for normal builds and snapcraft - new main splash   - new testnet splash   - new regtest splash   - new SVG sources for splash screens - add metadata and license info to new and some ionomy sources - **TODO** ***add license and author info to all available old resources, if info not available, replace it*** - [x] build - snap, remove snap files from share folder (6e52766) - [x] build - snap, refactor snap (efa1af8) - [x] build - debian, update debian building (e392659) - [x] build - snap, remove desktop-qt5 as it is not available with core18 (a1b16b1) - [x] docs - snap, create snap readme in doc folder (be5674d) - - [x] set min protocol version to current (1d5f0b0) * gui - artworks, update SVG sources and cleanup - remove obsolete xcf images - rename ion-ionlogowhite.svg to ion_logo_white.svg - recreate new daemon icon vector graphics * gui - update qt images, add new splash, replace banner - replace ion_logo_horizontal.png - replace all splash screens - add new snapcraft splash screens * gui - qt, replace regtest and testnet icons with new * build - snap, remove snap files from share folder * build - snap, refactor snap - cleanup comments - restructure - add more info in log - added list variables at the end of the job - replace splash by snapcrafts splash - move priming data to snap/desktop - move priming patches to snap/patches (_is not required as all current patches are only applied during compilation_) * gui - update pixmaps from share folder - create new icons - create new pngs - use naming scheme ion_NETWORK - added *48.xpm - added testnet and regtest icons * docs - snap, create snap readme in doc folder * build - debian, update debian building - update control file, add missing build libs - create new icons - use naming scheme ion_NETWORK - update *.desktop files - minor fixes in *.desktop files - create daemon icons for main, testnet and regtest - update installation configs * set min protocol version to current * build - snap, remove desktop-qt5 as it is not available with core18 * travis - add snapcraft.yaml to lint-whitespace whitelist, remove build-dpkd.sh * network - update hardcoded seeds
kwvg
pushed a commit
to kwvg/dash
that referenced
this pull request
Dec 21, 2022
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Mar 17, 2024
… blank wallet checkbox 915e341 qt: fix issue when disabling the auto-enabled blank wallet checkbox (Jarol Rodriguez) Pull request description: As detailed by dashpay#151, On `master` a user can create the confusing scenario where you have a disabled `Encrypt Wallet` checkbox and a selected `Disable Private Keys` checkbox after unselecting the auto-enabled `Blank Wallet` checkbox. This commit makes it so that when the `Blank Wallet` checkbox is auto-selected after the user selects `Disable Private keys`, unselecting it will also unselect the `Disable Private Keys` checkbox, which in turn re-enables the `Encrypt Wallet` checkbox. Below are screenshots comparing the behavior of selecting `Disable Private Keys` then unselecting the `Blank Wallet` between `master` and this `PR`: **Master:** | Select `Disable Private Keys` | Unselect `Blank Wallet` | | ----------------------------- | ------------------------ | |  |  | **PR:** | Select `Disable Private Keys` | Unselect `Blank Wallet` | | ----------------------------- | ------------------------ | |  |  | ACKs for top commit: hebasto: ACK 915e341 Talkless: ACK 915e341 Tree-SHA512: ce6ecbc35b94a08cabf0b8a24dbdfc874d82cc8918cc8623dce8172c7fc9c75d63a13b036bae5f7ab2c090f8d020574a542285d1651600813faf5d91e2506a8d
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Mar 23, 2024
… blank wallet checkbox 915e341 qt: fix issue when disabling the auto-enabled blank wallet checkbox (Jarol Rodriguez) Pull request description: As detailed by dashpay#151, On `master` a user can create the confusing scenario where you have a disabled `Encrypt Wallet` checkbox and a selected `Disable Private Keys` checkbox after unselecting the auto-enabled `Blank Wallet` checkbox. This commit makes it so that when the `Blank Wallet` checkbox is auto-selected after the user selects `Disable Private keys`, unselecting it will also unselect the `Disable Private Keys` checkbox, which in turn re-enables the `Encrypt Wallet` checkbox. Below are screenshots comparing the behavior of selecting `Disable Private Keys` then unselecting the `Blank Wallet` between `master` and this `PR`: **Master:** | Select `Disable Private Keys` | Unselect `Blank Wallet` | | ----------------------------- | ------------------------ | |  |  | **PR:** | Select `Disable Private Keys` | Unselect `Blank Wallet` | | ----------------------------- | ------------------------ | |  |  | ACKs for top commit: hebasto: ACK 915e341 Talkless: ACK 915e341 Tree-SHA512: ce6ecbc35b94a08cabf0b8a24dbdfc874d82cc8918cc8623dce8172c7fc9c75d63a13b036bae5f7ab2c090f8d020574a542285d1651600813faf5d91e2506a8d
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Mar 24, 2024
… blank wallet checkbox 915e341 qt: fix issue when disabling the auto-enabled blank wallet checkbox (Jarol Rodriguez) Pull request description: As detailed by dashpay#151, On `master` a user can create the confusing scenario where you have a disabled `Encrypt Wallet` checkbox and a selected `Disable Private Keys` checkbox after unselecting the auto-enabled `Blank Wallet` checkbox. This commit makes it so that when the `Blank Wallet` checkbox is auto-selected after the user selects `Disable Private keys`, unselecting it will also unselect the `Disable Private Keys` checkbox, which in turn re-enables the `Encrypt Wallet` checkbox. Below are screenshots comparing the behavior of selecting `Disable Private Keys` then unselecting the `Blank Wallet` between `master` and this `PR`: **Master:** | Select `Disable Private Keys` | Unselect `Blank Wallet` | | ----------------------------- | ------------------------ | |  |  | **PR:** | Select `Disable Private Keys` | Unselect `Blank Wallet` | | ----------------------------- | ------------------------ | |  |  | ACKs for top commit: hebasto: ACK 915e341 Talkless: ACK 915e341 Tree-SHA512: ce6ecbc35b94a08cabf0b8a24dbdfc874d82cc8918cc8623dce8172c7fc9c75d63a13b036bae5f7ab2c090f8d020574a542285d1651600813faf5d91e2506a8d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To prevent creating invalid txes every ds related function should ignore ix depth and use blockchain depth instead also we should not use IX coins until we have at least 1 blockchain confirmation.