Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added link to Transifex translation site for missing languages #171

Merged
merged 2 commits into from
Feb 12, 2015
Merged

Added link to Transifex translation site for missing languages #171

merged 2 commits into from
Feb 12, 2015

Conversation

crowning-
Copy link

I guess it doesn't make sense to translate this one :-)

optionsdialog

@vertoe
Copy link

vertoe commented Feb 10, 2015

Hi, cool move! 👍

Can we have some native english speaker to reword this a little bit? "Language missing or translation incomplete? Help contributing translations here: https://..."

And please remove the brackets ;)

@crowning-
Copy link
Author

Commited an update to patch-2, looks like this now:
optionsdialog

@eduffield222
Copy link

great idea!

eduffield222 pushed a commit that referenced this pull request Feb 12, 2015
Added link to Transifex translation site for missing languages
@eduffield222 eduffield222 merged commit 1165740 into dashpay:master Feb 12, 2015
@crowning- crowning- deleted the patch-2 branch February 12, 2015 06:38
@vertoe
Copy link

vertoe commented Feb 12, 2015

@crowning- is there a specific reason why this has the flag <string notr="true"> ?

@crowning-
Copy link
Author

@vertoe : yes...if a language does not exist it will be displayed in English anyway :-)

I can change this for the cases when a) a language partially exists AND b) this string is already translated to that language, no problem.

You decide..

PastaPastaPasta added a commit that referenced this pull request Apr 12, 2024
…itcoin#20813, bitcoin#21531, bitcoin-core/gui#13, #72, 115, #139, #171

a2f190d Merge bitcoin-core/gui#115: Replace "Hide tray icon" option with positive "Show tray icon" one (Jonas Schnelli)
65b80e7 Merge bitcoin#21531: test: remove qt byteswap compattests (MarcoFalke)
ba883c5 Merge bitcoin-core/gui#139: doc: Improve gui/src/qt README.md (MarcoFalke)
368c65d Merge bitcoin-core/gui#72: util: Log static plugins meta data and used style (Jonas Schnelli)
317777e Merge bitcoin-core/gui#171: Use layout manager for Create Wallet dialog (MarcoFalke)
83313a5 Merge bitcoin#20789: Rework strong and weak net enum fuzzing (MarcoFalke)
4a3e3af Merge bitcoin#20813: scripted-diff: Bump copyright headers (MarcoFalke)
e36eacd Merge bitcoin#18772: rpc: calculate fees in getblock using BlockUndo data (MarcoFalke)
41a1e10 Merge bitcoin#20690: Clean up logging of outbound connection type (MarcoFalke)
648d6f0 Merge bitcoin-core/gui#13: Hide peer detail view if multiple are selected (Jonas Schnelli)

Pull request description:

  ## Issue being fixed or feature implemented
  Regular backports from bitcoin v22

  ## What was done?
   - bitcoin-core/gui#13
   - bitcoin-core/gui#115
   - bitcoin#20690
   - bitcoin#18772
   - bitcoin#20813
   - bitcoin#20789
   - bitcoin-core/gui#171
   - bitcoin-core/gui#72
   - bitcoin-core/gui#139
   - bitcoin#21531

  ## How Has This Been Tested?
  Run unit/functional tests

  ## Breaking Changes
  N/A

  ## Checklist:
  - [x] I have performed a self-review of my own code
  - [ ] I have commented my code, particularly in hard-to-understand areas
  - [ ] I have added or updated relevant unit/integration/functional/e2e tests
  - [ ] I have made corresponding changes to the documentation
  - [x] I have assigned this pull request to a milestone

ACKs for top commit:
  PastaPastaPasta:
    utACK a2f190d

Tree-SHA512: 29421e7ca38583c47f49c2605775f34b64ae2fb6aeb45ac42941fbc78598fc26e7f7a248b40fcc2c9fd21154b0a6f2aed64287a8b7cca43de1b99ae3dccd990f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants