Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace boost::lexical_cast<int> with atoi #1926

Merged
merged 1 commit into from
Feb 12, 2018
Merged

Replace boost::lexical_cast<int> with atoi #1926

merged 1 commit into from
Feb 12, 2018

Conversation

UdjinM6
Copy link

@UdjinM6 UdjinM6 commented Feb 12, 2018

atoi seems to be faster and does the job just fine in our cases (rpc + parsing local strings).

int_atoi,46137344,0.000000020275820,0.000000026102043,0.000000022219074,46,60,51
int_lexical_cast,31457280,0.000000030697834,0.000000037103746,0.000000032865842,70,85,75

Also cleanup existing atoi-s in Dash code.

@UdjinM6
Replace boost::lexical_cast<int> with atoi
06ff1a2 
Also cleanup existing atoi-s in Dash code
@UdjinM6 UdjinM6 added this to the 12.3 milestone Feb 12, 2018
codablock
codablock approved these changes Feb 12, 2018
View reviewed changes
Copy link

@codablock codablock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

nmarley
nmarley approved these changes Feb 12, 2018
View reviewed changes
Copy link

@nmarley nmarley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@UdjinM6 UdjinM6 merged commit 2e04864 into dashpay:develop Feb 12, 2018
andvgal pushed a commit to energicryptocurrency/gen2-energi that referenced this pull request Jan 6, 2019
@UdjinM6 @andvgal
Replace boost::lexical_cast<int> with atoi (dashpay#1926)
d48ebc2 
Also cleanup existing atoi-s in Dash code
CryptoCentric pushed a commit to absolute-community/absolute that referenced this pull request Feb 28, 2019
@UdjinM6 @CryptoCentric
Replace boost::lexical_cast<int> with atoi (dashpay#1926)
79b353b 
Also cleanup existing atoi-s in Dash code
CryptoCentric pushed a commit to absolute-community/absolute that referenced this pull request Mar 2, 2019
@UdjinM6 @CryptoCentric
Replace boost::lexical_cast<int> with atoi (dashpay#1926)
f23b405 
Also cleanup existing atoi-s in Dash code
@UdjinM6 UdjinM6 deleted the useatoi branch November 26, 2020 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codablock codablock codablock approved these changes

@nmarley nmarley nmarley approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
12.3
Development

Successfully merging this pull request may close these issues.
3 participants
@UdjinM6 @nmarley @codablock